)]}'
{"swift/common/daemon.py":[{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"7524234fc1691892ab413b383e93824f6597ae75","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.options_by_pid \u003d {}"},{"line_number":130,"context_line":"        self.unspawned_worker_options \u003d []"},{"line_number":131,"context_line":"        self.healthcheck_interval \u003d float("},{"line_number":132,"context_line":"            self.daemon.conf.get(\u0027healthcheck_interval\u0027, 0.1))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def setup(self, **kwargs):"},{"line_number":135,"context_line":"        utils.validate_configuration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_48086f2b","line":132,"updated":"2020-03-25 15:59:56.000000000","message":"I\u0027m not sure \"healthcheck_interval\" is a great name, suggestions welcome","commit_id":"38be0d7297deae1c4ac81a55f106cfa0854695d1"},{"author":{"_account_id":25251,"name":"Alexandre Lécuyer","email":"alexandre.lecuyer@corp.ovh.com","username":"alecuyer"},"change_message_id":"b0e72c67c738f004d26c4c7f5903ec2b9597e22b","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.options_by_pid \u003d {}"},{"line_number":130,"context_line":"        self.unspawned_worker_options \u003d []"},{"line_number":131,"context_line":"        self.healthcheck_interval \u003d float("},{"line_number":132,"context_line":"            self.daemon.conf.get(\u0027healthcheck_interval\u0027, 0.1))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def setup(self, **kwargs):"},{"line_number":135,"context_line":"        utils.validate_configuration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b60519c5","line":132,"in_reply_to":"df33271e_1637a5e5","updated":"2020-03-25 20:54:11.000000000","message":"For context, as was mentionned in another review: This came up because the health checks are relatively costly on atom servers. (indeed, not just for LOSF).","commit_id":"38be0d7297deae1c4ac81a55f106cfa0854695d1"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"861073b9c3211eb7f92a0817f8b42692f47376c2","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.options_by_pid \u003d {}"},{"line_number":130,"context_line":"        self.unspawned_worker_options \u003d []"},{"line_number":131,"context_line":"        self.healthcheck_interval \u003d float("},{"line_number":132,"context_line":"            self.daemon.conf.get(\u0027healthcheck_interval\u0027, 0.1))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def setup(self, **kwargs):"},{"line_number":135,"context_line":"        utils.validate_configuration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_1637a5e5","line":132,"in_reply_to":"df33271e_22b26795","updated":"2020-03-25 20:39:45.000000000","message":"Agree with not adding knobs unless absolutely necesary. But why not -1 the review?","commit_id":"38be0d7297deae1c4ac81a55f106cfa0854695d1"},{"author":{"_account_id":13852,"name":"Romain LE DISEZ","email":"romain.le-disez@corp.ovh.com","username":"rledisez"},"change_message_id":"fc4698fe83d29661c3c287dded273ff93d5a1aab","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        self.options_by_pid \u003d {}"},{"line_number":130,"context_line":"        self.unspawned_worker_options \u003d []"},{"line_number":131,"context_line":"        self.healthcheck_interval \u003d float("},{"line_number":132,"context_line":"            self.daemon.conf.get(\u0027healthcheck_interval\u0027, 0.1))"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def setup(self, **kwargs):"},{"line_number":135,"context_line":"        utils.validate_configuration()"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_22b26795","line":132,"in_reply_to":"df33271e_48086f2b","updated":"2020-03-25 18:21:49.000000000","message":"I don\u0027t like that it\u0027s up to the operator to choose the right interval. We should do the right thing by default on this internal plumbing. I would prefer that we set the default value here and the inheriting classes can override it when necessary (aka: not possible to optimize the code).","commit_id":"38be0d7297deae1c4ac81a55f106cfa0854695d1"}]}