)]}'
{"swift/common/middleware/s3api/s3api.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"603b46d788870c16d1fd3edf775dd438ef51249f","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"        if isinstance(resp, S3ResponseBase):"},{"line_number":310,"context_line":"            # Current request is a S3 API request, increase s3api.* metrics"},{"line_number":311,"context_line":"            self.logger.increment(\u0027s3api.%s.%s\u0027 % (env[\u0027REQUEST_METHOD\u0027].upper(),"},{"line_number":312,"context_line":"                                                   resp.status_int))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return resp(env, start_response)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b97c2a73","line":311,"updated":"2020-04-03 21:58:35.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"d491525a478d90423aef083f10ecd9829ed75969"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a4a58c510d3038d239c07f42e2d71250b37900c9","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        if isinstance(resp, S3ResponseBase):"},{"line_number":310,"context_line":"            # Current request is a S3 API request, increase s3api.* metrics"},{"line_number":311,"context_line":"            self.logger.increment(\u0027s3api.%s.%s\u0027 % (env[\u0027REQUEST_METHOD\u0027].upper(),"},{"line_number":312,"context_line":"                                                   resp.status_int))"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        return resp(env, start_response)"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7c6842b8","line":312,"updated":"2020-03-30 21:49:06.000000000","message":"Should we try to break this down further? Like whether it was for the service vs. bucket vs. key, maybe? I\u0027m mainly looking at the metric names in proxy_logging for precedents -- do you know of anywhere else I should be looking or thinking about?\n\nDo we just want to track counts, or are we interested in timings as well? Since an s3api request often translates into multiple backend requests, there might be some utility in tracking S3 separately... but maybe that\u0027s best as a separate patch.","commit_id":"d491525a478d90423aef083f10ecd9829ed75969"}]}