)]}'
{"swift/common/ring/composite_builder.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4ac4130f5adbe17e9533c3480129af97b4714d06","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    The ``id`` of each component RingBuilder is therefore stored in metadata of"},{"line_number":81,"context_line":"    the composite and used to check for the component ordering when the same"},{"line_number":82,"context_line":"    composite ring is re-composed. RingBuilder ``id``\\s are normally assigned"},{"line_number":83,"context_line":"    when a RingBuilder instance is first saved. Older RingBuilder instances"},{"line_number":84,"context_line":"    loaded from file may not have an ``id`` assigned and will need to be saved"},{"line_number":85,"context_line":"    before they can be used as components of a composite ring. This can be"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_90cae29e","side":"PARENT","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":54},"updated":"2020-04-03 18:14:51.000000000","message":"Pretty sure the backslash is significant -- the note at https://46f0fe2d889c9344d81d-b65aba79d26aa5ef33fd003933b1dd3e.ssl.cf1.rackcdn.com/717271/2/check/openstack-tox-docs/6d1aec5/docs/ring.html#composite-builder looks pretty screwy. I guess we need two of them, though?","commit_id":"b4b0ebd4aa0a710af288a69ae787e10420fdeb1a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"33123d47b07b4935b27ac32a1dc48c203e7ca75b","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    The ``id`` of each component RingBuilder is therefore stored in metadata of"},{"line_number":81,"context_line":"    the composite and used to check for the component ordering when the same"},{"line_number":82,"context_line":"    composite ring is re-composed. RingBuilder ``id``\\s are normally assigned"},{"line_number":83,"context_line":"    when a RingBuilder instance is first saved. Older RingBuilder instances"},{"line_number":84,"context_line":"    loaded from file may not have an ``id`` assigned and will need to be saved"},{"line_number":85,"context_line":"    before they can be used as components of a composite ring. This can be"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_2d20d8f7","side":"PARENT","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":54},"in_reply_to":"df33271e_90cae29e","updated":"2020-04-03 18:37:14.000000000","message":"I\u0027ll fix...","commit_id":"b4b0ebd4aa0a710af288a69ae787e10420fdeb1a"}],"test/unit/obj/test_ssync_receiver.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4ac4130f5adbe17e9533c3480129af97b4714d06","unresolved":false,"context_lines":[{"line_number":1168,"context_line":"            self.assertFalse(mock_wsgi_input.mock_socket.close.called)"},{"line_number":1169,"context_line":""},{"line_number":1170,"context_line":"    def test_UPDATES_bad_subrequest_line(self):"},{"line_number":1171,"context_line":"        self.controller.logger \u003d mock.MagicMock()"},{"line_number":1172,"context_line":"        req \u003d swob.Request.blank("},{"line_number":1173,"context_line":"            \u0027/device/partition\u0027,"},{"line_number":1174,"context_line":"            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027SSYNC\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_d0cd8a87","line":1171,"updated":"2020-04-03 18:14:51.000000000","message":"Looks like the diff in gerrit is a red herring, and it\u0027s all just cleaning up unnecessary indent like below.","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"}],"tox.ini":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4ac4130f5adbe17e9533c3480129af97b4714d06","unresolved":false,"context_lines":[{"line_number":129,"context_line":"# H501: Do not use self.__dict__ for string formatting"},{"line_number":130,"context_line":"# Disabled with going to hacking 2.0, needs further investigation and"},{"line_number":131,"context_line":"# changes to enable:"},{"line_number":132,"context_line":"# E305 expected 2 blank lines after class or function definition, found 1"},{"line_number":133,"context_line":"# E402: module level import not at top of file"},{"line_number":134,"context_line":"# E501 line too long (80 \u003e 79 characters)"},{"line_number":135,"context_line":"# E731 do not assign a lambda expression, use a def"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_8a5aaa27","line":132,"updated":"2020-04-03 18:14:51.000000000","message":"Seems related to https://github.com/PyCQA/pycodestyle/issues/400","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4ac4130f5adbe17e9533c3480129af97b4714d06","unresolved":false,"context_lines":[{"line_number":131,"context_line":"# changes to enable:"},{"line_number":132,"context_line":"# E305 expected 2 blank lines after class or function definition, found 1"},{"line_number":133,"context_line":"# E402: module level import not at top of file"},{"line_number":134,"context_line":"# E501 line too long (80 \u003e 79 characters)"},{"line_number":135,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":136,"context_line":"# W503: line break before binary operator"},{"line_number":137,"context_line":"# W504: line break after binary operator"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_16208af7","line":134,"updated":"2020-04-03 18:14:51.000000000","message":"Yeah, this one\u0027s weird -- seems to be some change between pep8 1.5.7 and 1.6, but I\u0027m not seeing any difference between https://github.com/PyCQA/pycodestyle/blob/1.5.7/pep8.py#L190 and https://github.com/PyCQA/pycodestyle/blob/1.6/pep8.py#L198\n\nBut won\u0027t disabling it mean we no longer catch even longer lines? Probably better to just set\n\n max_line_length \u003d 80","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"33123d47b07b4935b27ac32a1dc48c203e7ca75b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"# changes to enable:"},{"line_number":132,"context_line":"# E305 expected 2 blank lines after class or function definition, found 1"},{"line_number":133,"context_line":"# E402: module level import not at top of file"},{"line_number":134,"context_line":"# E501 line too long (80 \u003e 79 characters)"},{"line_number":135,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":136,"context_line":"# W503: line break before binary operator"},{"line_number":137,"context_line":"# W504: line break after binary operator"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_8d8644db","line":134,"in_reply_to":"df33271e_16208af7","updated":"2020-04-03 18:37:14.000000000","message":"let me try what the line limit is.","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4ac4130f5adbe17e9533c3480129af97b4714d06","unresolved":false,"context_lines":[{"line_number":133,"context_line":"# E402: module level import not at top of file"},{"line_number":134,"context_line":"# E501 line too long (80 \u003e 79 characters)"},{"line_number":135,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":136,"context_line":"# W503: line break before binary operator"},{"line_number":137,"context_line":"# W504: line break after binary operator"},{"line_number":138,"context_line":"ignore \u003d H101,H202,H301,H306,H404,H405,H501,W503,W504,E305,E402,E501,E731"},{"line_number":139,"context_line":"exclude \u003d .venv,.tox,dist,*egg"},{"line_number":140,"context_line":"filename \u003d *.py,bin/*"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_f0024e0b","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":40},"updated":"2020-04-03 18:14:51.000000000","message":":exploding_head:","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"33123d47b07b4935b27ac32a1dc48c203e7ca75b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"# E402: module level import not at top of file"},{"line_number":134,"context_line":"# E501 line too long (80 \u003e 79 characters)"},{"line_number":135,"context_line":"# E731 do not assign a lambda expression, use a def"},{"line_number":136,"context_line":"# W503: line break before binary operator"},{"line_number":137,"context_line":"# W504: line break after binary operator"},{"line_number":138,"context_line":"ignore \u003d H101,H202,H301,H306,H404,H405,H501,W503,W504,E305,E402,E501,E731"},{"line_number":139,"context_line":"exclude \u003d .venv,.tox,dist,*egg"},{"line_number":140,"context_line":"filename \u003d *.py,bin/*"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_ad8188c6","line":137,"range":{"start_line":136,"start_character":0,"end_line":137,"end_character":40},"in_reply_to":"df33271e_f0024e0b","updated":"2020-04-03 18:37:14.000000000","message":"you need to decide as team which of these to disable - and which to enable. There\u0027s no consistency currently in the repo. Or you can decide you don\u0027t care...","commit_id":"9fda80b045634e2e1640684c8a6396b84aebc93c"}]}