)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7e928de0cd35d34d2f508cf77e7ee32c5199c1a3","unresolved":false,"context_lines":[{"line_number":3064,"context_line":"                        policy\u003dself._diskfile.policy)"},{"line_number":3065,"context_line":"                    # We \"succeeded\" if another writer cleaned up our data"},{"line_number":3066,"context_line":"                    ts_info \u003d results.get(\u0027ts_info\u0027)"},{"line_number":3067,"context_line":"                    durables \u003d results.get(\u0027durable_frag_set\u0027, [])"},{"line_number":3068,"context_line":"                    if ts_info and ts_info[\u0027timestamp\u0027] \u003e timestamp:"},{"line_number":3069,"context_line":"                        return"},{"line_number":3070,"context_line":"                    elif any(frag_set[\u0027timestamp\u0027] \u003e timestamp"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_693c2bc8","line":3067,"updated":"2020-04-24 20:00:05.000000000","message":"I feel like get_ondisk_files results should just add a key for the canonical \"this is the latest timestamp representing this object\" if it doesn\u0027t already have one so we don\u0027t have to do the precedence handling inline","commit_id":"b6be32db8c1e690e784f460129b2c1e990f0b8e2"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7e928de0cd35d34d2f508cf77e7ee32c5199c1a3","unresolved":false,"context_lines":[{"line_number":3071,"context_line":"                             for frag_set in durables):"},{"line_number":3072,"context_line":"                        return"},{"line_number":3073,"context_line":""},{"line_number":3074,"context_line":"                if err.errno not in (errno.ENOSPC, errno.EDQUOT):"},{"line_number":3075,"context_line":"                    # re-raise to catch all handler"},{"line_number":3076,"context_line":"                    raise"},{"line_number":3077,"context_line":"                params \u003d {\u0027file\u0027: durable_data_file_path, \u0027err\u0027: err}"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_a503f90e","line":3074,"updated":"2020-04-24 20:00:05.000000000","message":"if it\u0027s this handle it, unless we don\u0027t then or if not one of these then raise it else handle it...\n\nI feel like a single pattern here for handled vs un-handled exceptions it would be a little easier to read","commit_id":"b6be32db8c1e690e784f460129b2c1e990f0b8e2"}],"test/unit/obj/test_diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7e928de0cd35d34d2f508cf77e7ee32c5199c1a3","unresolved":false,"context_lines":[{"line_number":3743,"context_line":"            thread.start()"},{"line_number":3744,"context_line":"        for thread in threads:"},{"line_number":3745,"context_line":"            thread.join()"},{"line_number":3746,"context_line":"        self.assertFalse(errors)"},{"line_number":3747,"context_line":""},{"line_number":3748,"context_line":"    def _get_open_disk_file(self, invalid_type\u003dNone, obj_name\u003d\u0027o\u0027, fsize\u003d1024,"},{"line_number":3749,"context_line":"                            csize\u003d8, mark_deleted\u003dFalse, prealloc\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f493fa4_253fe9d6","line":3746,"updated":"2020-04-24 20:00:05.000000000","message":"I really rather like this test...\n\n\tFAIL: test_disk_file_concurrent_writes (test.unit.obj.test_diskfile.TestECDiskFile)\n\t----------------------------------------------------------------------\n\tTraceback (most recent call last):\n\t  File \"/home/vagrant/swift/test/unit/obj/test_diskfile.py\", line 3746, in test_disk_file_concurrent_writes\n\t    self.assertFalse(errors)\n\tAssertionError: [DiskFileError(\u0027Problem making data file durable /srv/node1/sdb1/tmp/tmpefVvFj/tmp_test_obj_server_DiskFile/sda1/objects/0/bbe/609099584d4a31526e840b664cb0dbbe/1587757931.00000#2#d.data ([Errno 2] No such file or directory)\u0027,)] is not false","commit_id":"b6be32db8c1e690e784f460129b2c1e990f0b8e2"}]}