)]}'
{"id":"openstack%2Fswift~725288","triplet_id":"openstack%2Fswift~master~I6431af7975f794ef264bd319b68db52ce4062c4b","project":"openstack/swift","branch":"master","topic":"bug/1863021","hashtags":[],"change_id":"I6431af7975f794ef264bd319b68db52ce4062c4b","subject":"Monkey patch original current_thread _active","status":"ABANDONED","created":"2020-05-04 14:31:26.000000000","updated":"2020-12-15 19:17:25.000000000","total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1a612693f13c6dce4729fc0254249b45015a1773","_number":725288,"virtual_id_number":725288,"owner":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-05-06 07:41:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-05-07 14:17:06.000000000","_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"date":"2020-05-07 08:02:54.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-06 07:41:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-07 08:02:54.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2020-05-07 14:17:06.000000000","updated_by":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"reviewer":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"state":"REVIEWER"}],"messages":[{"id":"ae95341ce6fc787b5b7bb7c9f2410364656ac160","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2020-05-04 14:31:26.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"35caedfe3ead200ecde9c4e7638d2cc22410e6c5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-04 16:13:13.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8818adbbda9f40d79f7cdd593a97eb1d : SUCCESS in 12m 24s\n- grenade https://zuul.opendev.org/t/openstack/build/95c3efece6fd4452833deed48a543b5c : SUCCESS in 1h 02m 00s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/97ecb242ba064009970f08b14833ec65 : SUCCESS in 1h 07m 42s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/d9e92f44ad8a4ed7ac9fdcefcda22d6d : SUCCESS in 10m 26s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/80d5dc018ed4471fadcda1fc2aaa5d42 : SUCCESS in 10m 36s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/bc53191b3f494830809cd3566027ba35 : TIMED_OUT in 42m 25s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/98a712cd77874711a21ac0cfeecfc7ae : TIMED_OUT in 41m 29s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/379f9e0f4b944b96a3ef3e442b836e62 : TIMED_OUT in 42m 07s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/00be515747d946289a3d657885e0e8c7 : TIMED_OUT in 41m 11s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/cc184aabab5143abaa127b79a6750faf : SUCCESS in 23m 33s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/1b8bec728b6e4c779673abb67ae23c24 : SUCCESS in 34m 42s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/99b0e4fc278044d79fef26a9682169e9 : SUCCESS in 12m 44s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/961c4a112b3a4858a9324c156447a86a : SUCCESS in 13m 36s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/5680346b5095416c8f4eaa6127de5065 : SUCCESS in 37m 15s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/f6f2fb75ec2846debfba404f23596a8f : SUCCESS in 21m 37s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/49bc36de247944d58f6af28d516c23ae : SUCCESS in 26m 09s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/4ad5d7e72e6f42fcb63911b4e98165b6 : SUCCESS in 11m 04s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/6bc93fe1fd0346f39d8b535c29ff62ee : SUCCESS in 11m 57s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/1a3fcdf1517d4265b5043c25160f8f73 : SUCCESS in 20m 08s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/81ec29a17daa4ed2bfbbe43d679275dd : SUCCESS in 24m 18s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7546180090f94dd7b3961075e7ff8ac2 : SUCCESS in 44m 50s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/5f30e2ccec464ea3bd0786d7527e6450 : SUCCESS in 30m 58s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/4dfc6bcc8425472d9fbef9ea722c813f : SUCCESS in 28m 38s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/96e4388b491247e1bac80a261f2cc4fc : SUCCESS in 34m 59s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5d3f89e24b0d4d15acd4c8db3b5e9e25 : TIMED_OUT in 41m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e224a01097bb41feb8ac31cbf83e90d5 : FAILURE in 5m 58s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/5d720b66e89748a694a3058b72b99a66 : FAILURE in 27m 48s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2d753548a14f45908e7764dcfb0b0069 : SUCCESS in 1h 01m 10s\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/d719d9173efa481eab9188336debb1c0 : SUCCESS in 1h 23m 03s","accounts_in_message":[],"_revision_number":1},{"id":"6808143409821b523d792803f3dfa197d29cdfad","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-05 14:09:00.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0539e333fb781979db8926557c7e010f1a5afdd7","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-05 14:12:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"90cad9980d6530199b1b3490a44e6d07f7a212f8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-05 15:35:31.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bdec707c75f546e3ab85dda879d2e212 : SUCCESS in 9m 55s\n- grenade https://zuul.opendev.org/t/openstack/build/aaa9d680e6c74b5a9756d37c1573a793 : SUCCESS in 1h 03m 57s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/4579d24f9ceb4477993ec92c9b5feeca : SUCCESS in 56m 30s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/8d4e653e475043adaa9fdd627d55b2e3 : SUCCESS in 17m 44s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f2fa35ec5de641579a2f48ecb8b90753 : SUCCESS in 12m 59s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/fc17eb162ce042fd973f2dfc12540fe7 : TIMED_OUT in 42m 25s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/39c56f75975c41c6a2bbc1d61e36bedb : TIMED_OUT in 42m 34s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/a8d7afb2943943acabbd3f0d44048cac : TIMED_OUT in 42m 37s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/b01d95a3eaae47569ad4ed0fc313f8d7 : TIMED_OUT in 42m 34s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/c991a2cd33d1418e97c5dd83b27f6521 : SUCCESS in 22m 03s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/fb2bd3db2c3d405abe31606ac79d9a54 : SUCCESS in 23m 52s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/daa224d11bcb40e68dbc63055a4224cf : SUCCESS in 16m 12s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/03e2142a65634d94b43e4161d119bf88 : SUCCESS in 17m 49s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/9288c9caa34c4475ada685e086e7da09 : SUCCESS in 24m 32s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/382a325770564a16b4e4aebacfa04d0c : SUCCESS in 20m 12s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/6669c08b158745108e73eb5519388ab2 : SUCCESS in 18m 48s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/5baa84a5df5b4e40bc590152c2c42ecd : SUCCESS in 15m 46s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/e092899fd75349bba7585a29b3407309 : FAILURE in 21m 28s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/c8f78eff429a4991879813d344c988c0 : SUCCESS in 26m 43s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/2b14a5688c67447c9cb59c80c6642d97 : SUCCESS in 27m 01s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/47962d0cb1ed4893ada8cc2bac233118 : SUCCESS in 50m 41s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/9d7d7f13fe784d4a891488233dff1c5d : SUCCESS in 34m 51s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/5944f56bf03c4cef89ddf34cc382458a : SUCCESS in 32m 52s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/9b7e14685fdc46b098e00b9d110be492 : SUCCESS in 35m 44s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e577b717083b471dbe8fd05c7a98b561 : TIMED_OUT in 42m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3832b26e434c447eb5313edfe4426c5f : SUCCESS in 8m 03s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/435762c5acf44e7fbb47c06d1fabb07b : FAILURE in 24m 21s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/3488c1b9e8d54cb093f1415e5c9f317b : SUCCESS in 1h 17m 57s","accounts_in_message":[],"_revision_number":2},{"id":"683d75487f59b44e28cdaba8bdcb529faf2bbd9e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-05-05 19:09:02.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nHuh. I can repro the unit test hang, though I\u0027m not at all sure *why* it happens:\n\n$ nosetests \\\n test/unit/container/test_server.py:TestNonLegacyDefaultStoragePolicy.test_GET_plain \\\n test/unit/container/test_updater.py:TestContainerUpdater.test_run_once \\\n test/unit/obj/test_diskfile.py:TestSuffixHashes.test_get_hashes_race_existing_partition\nUnable to read test config /etc/swift/test.conf - file not found\ntest_GET_plain (test.unit.container.test_server.TestNonLegacyDefaultStoragePolicy) ... ok\ntest_run_once (test.unit.container.test_updater.TestContainerUpdater) ... ok\ntest_get_hashes_race_existing_partition (test.unit.obj.test_diskfile.TestSuffixHashes) ... Traceback (most recent call last):\n  File \"/home/tburke/py37/lib64/python3.7/site-packages/eventlet/hubs/hub.py\", line 461, in fire_timers\n    timer()\n  File \"/home/tburke/py37/lib64/python3.7/site-packages/eventlet/hubs/timer.py\", line 59, in __call__\n    cb(*args, **kw)\n  File \"/home/tburke/py37/lib64/python3.7/site-packages/eventlet/event.py\", line 175, in _do_send\n    waiter.switch(result)\ngreenlet.error: cannot switch to a different thread\n*** hang ***\n\nIt\u0027s weird: drop either of those two preliminary tests, and the third won\u0027t hang. I strongly suspect (though I\u0027m not sure it\u0027s worth the time to confirm) that there are other lead-in tests that would produce the same issue.\n\nFWIW, if I apply something like\n\ndiff --git a/test/unit/obj/test_diskfile.py b/test/unit/obj/test_diskfile.py\nindex 6d1a53b51..6f02bd3c9 100644\n--- a/test/unit/obj/test_diskfile.py\n+++ b/test/unit/obj/test_diskfile.py\n@@ -8232,6 +8232,7 @@ class TestSuffixHashes(unittest.TestCase):\n             self.assertEqual(hashes, {})\n \n     def _test_get_hashes_race(self, hash_breaking_function):\n+        utils.eventlet_monkey_patch()\n         for policy in self.iter_policies():\n             df_mgr \u003d self.df_router[policy]\n \nI can get just\n\n nosetests test/unit/obj/test_diskfile.py:TestSuffixHashes\n\nto hang at the same test, though running the single test in isolation still *doesn\u0027t* hang.","accounts_in_message":[],"_revision_number":2},{"id":"21f98c8f5c962c4d8ff73c276718896daa53e7c1","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-05 20:15:03.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nThe timeouts are worrisome. I just ran a \u0027tox -e py38\u0027 on ubuntu focal and it completed successfully.","accounts_in_message":[],"_revision_number":2},{"id":"c4da8f8e273e43c06ef027f171dbe360654c016f","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-05 20:21:01.000000000","message":"Patch Set 2:\n\nWell maybe this explains the success: test_get_hashes_race_existing_partition (test.unit.obj.test_diskfile.TestSuffixHashes) ... SKIP: Large xattrs not supported in `/tmp`. Skipping test","accounts_in_message":[],"_revision_number":2},{"id":"90c378ba7f7bc5470259762fde0c7311cc21bc89","author":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"date":"2020-05-06 06:09:33.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"2167798e990aff617d6ad49a0c489a31d299027e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-06 07:41:48.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8f93eeae0c804407928a80823bd96954 : SUCCESS in 14m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/e70cdd0d2a27487c9fab18508a67bfab : SUCCESS in 1h 09m 05s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/ac60a2a8e4e54f79b8bbf191f6c265b6 : SUCCESS in 49m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/1dee8a076d5a4e8e963e4e0ed21eb030 : SUCCESS in 11m 29s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/85efe74f9c0f422ba9d5d4ce6d5ae365 : SUCCESS in 14m 48s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/595fa1669fa446d29ce878f6d28ae7e0 : TIMED_OUT in 41m 11s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/6d8fb4be44114207a2faa798087a872d : TIMED_OUT in 41m 15s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/d8ee7afde660438b91335b322d6a2670 : TIMED_OUT in 41m 06s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/9430e3e752514224b8417f2d3102b509 : TIMED_OUT in 41m 17s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/86946272e7bb429d8c338369b1689992 : SUCCESS in 20m 35s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/14e7ac16dd2c45da91511f01f20ead9b : SUCCESS in 24m 28s\n- swift-tox-func-domain-remap-staticweb-py27 https://zuul.opendev.org/t/openstack/build/6bab6888e4e94948852b5ca87c89a1a0 : SUCCESS in 20m 23s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/63f91801bf61486fabd0ed74daefa528 : SUCCESS in 19m 09s\n- swift-tox-func-s3api-py27 https://zuul.opendev.org/t/openstack/build/09920b9bbccc4da082a0e7dac6fa8746 : SUCCESS in 20m 18s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/3e60e6a6a9f44bd2925643399c06105c : SUCCESS in 12m 58s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/e3cc047f5bab43f7bcb293030faf1cc0 : SUCCESS in 40m 11s\n- swift-tox-func-domain-remap-staticweb-py37 https://zuul.opendev.org/t/openstack/build/7f11c1cce4ce46a8ae58be0c48579cc0 : SUCCESS in 14m 26s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/2091efa1485f4decb4a006d5df8face1 : SUCCESS in 15m 28s\n- swift-tox-func-s3api-py37 https://zuul.opendev.org/t/openstack/build/92fd7cec13b3494bb22ee80b3ebe2384 : SUCCESS in 19m 44s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0f36aec2dc654516898aa7fd5e590cb5 : SUCCESS in 39m 08s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a34671570c9449e6b64ae420cfeee51c : SUCCESS in 54m 38s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/d6ec6d6f24df4c8bb672d30664144b20 : SUCCESS in 37m 56s\n- swift-dsvm-functional-py3 https://zuul.opendev.org/t/openstack/build/08d8c21d872d4ad7bc457b0ac1324368 : SUCCESS in 29m 40s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/639b34db74114a23bf7623067f95190f : SUCCESS in 38m 47s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c782bc6fd5f40bcb5de4251ed60fdad : TIMED_OUT in 41m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c0b6ad4bc7184111b64a66faa6a7e6b3 : SUCCESS in 6m 57s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/8ee40ef7607c4a79b66790ad35de5fb4 : FAILURE in 34m 03s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/80393dd6ed654caba3117fea9c3aa937 : SUCCESS in 1h 05m 41s","accounts_in_message":[],"_revision_number":3},{"id":"01105feacf86e8058d224d1cf7b0e0272dbbbc25","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-06 18:52:36.000000000","message":"Patch Set 3:\n\nI was able to recreate the tests in a lxd focal container using zfs. I\u0027m not sure what\u0027s going on though. Maybe some eventlet patching that isn\u0027t getting cleaned up somewhere in unit tests.","accounts_in_message":[],"_revision_number":3},{"id":"4f4a475e9100b569e59c0c2e41162a98d752c635","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-06 21:23:15.000000000","message":"Patch Set 3:\n\nI\u0027m still not quite sure what is going on. If I drop the new code from swift/common/utils.py then the 3 tests run successfully. Similarly, if I comment out the call to eventlet_monkey_patch() in run_once() in swift/container/updater.py the tests run successfully (test_run_once calls cu.run_once()). One observation on swift vs most all other projects is that swift doesn\u0027t call monkey_patch() quite as early. The eventlet documentation says it\u0027s important to call monkey_patch() as early in the lifetime of the application as possible: https://eventlet.net/doc/patching.html. With that said this code\u0027s been there for at least 4 years, so maybe it\u0027s just fine. I\u0027m just wondering if this new code is exposing an issue with that regard.","accounts_in_message":[],"_revision_number":3},{"id":"907ac2f2e74ee2107a0f8e8776d876cb7195f847","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-05-07 00:37:02.000000000","message":"Patch Set 3:\n\nSwift tends to have reasonably good hygiene around subprocesses, pthreads, and greenthreads -- I\u0027m not actually sure that the existing code has a problem, though the (ignored) assertion error sure is noisy. I added a comment with some findings to the eventlet bug; I wonder if the eventlet test failures I saw are related to the hangs we see in swift\u0027s unit tests.\n\nI\u0027m going to see where registering a new at_fork hook gets me, will report back. On the whole, though, I kinda feel like eventlet is the right place to do a fix.","accounts_in_message":[],"_revision_number":3},{"id":"8e342d3dae6cdc1e3c350b841c9e90d8ec147cd9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-05-07 08:02:54.000000000","message":"Patch Set 3:\n\nLocal testing (both unit and functional) make me think registering a new set of at_fork functions will work out well -- though I realized I forgot to include a python-version check in the patch I left in the GH comment. I\u0027ll work on getting a PR together for eventlet tomorrow.\n\nHelp me understand the severity here, though -- the [Impact] from the bug says \"services fail\" but then the traceback is immediately preceded by\n\n Exception ignored in: \u003cfunction _after_fork at ...\u003e\n\nSo did services fail, or was the \"problem\" ignored?\n\nBasically I\u0027m trying to judge the relative merits of having a fix for this in Swift as opposed to pushing for eventlet to fix it for *everyone*. While it seems safe to register at_fork hooks twice, I\u0027m not sure the added complexity (or mass of changes \u0026 backports, when looking at the rest of the OpenStack ecosystem) is worth it if this amounts to a somewhat noisy and hard-to-suppress warning. (I might also make some argument about needing to know too much about eventlet\u0027s implementation details, but I don\u0027t think Swift can really take that position with any sort of credibility ;-)","accounts_in_message":[],"_revision_number":3},{"id":"cf1ff1c806b5e7c04ba5953032272ee545f56ec3","author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"date":"2020-05-07 14:17:06.000000000","message":"Patch Set 3:\n\nIt would be great to fix this in eventlet. This affects a lot of projects so I have to admit we haven\u0027t tested every project. For projects like cinder, nova, neutron, and glance this resulted in errors that weren\u0027t ignored. I did just test a swift object upload/download and they worked fine. So maybe we don\u0027t need this for swift after all.\n\nAlso yes the fix really belongs in eventlet. I\u0027m not sure how backportable that would be and we\u0027re in a bind with ussuri release next week at this point, thus the mass openstack patching.","accounts_in_message":[],"_revision_number":3},{"id":"1a612693f13c6dce4729fc0254249b45015a1773","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-12-15 19:17:25.000000000","message":"Abandoned\n\nThere\u0027s an upstream eventlet fix (https://github.com/eventlet/eventlet/pull/654, though there were follow-ons in https://github.com/eventlet/eventlet/pull/654 and https://github.com/eventlet/eventlet/pull/661). If we still really want to carry cruft for older eventlet versions, that\u0027s probably the best starting point for how we\u0027d want to do it, but given that I haven\u0027t seen any demonstrable harm (at least here with Swift) from the noisy ignored errors, I\u0027m inclined to just recommend people upgrade eventlet.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"c4267c94f53d93d6bd90cfe403a1d12e84e42805","revisions":{"ec73cee8e614484abaa17421f4cfee85144d2b59":{"kind":"REWORK","_number":1,"created":"2020-05-04 14:31:26.000000000","uploader":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"ref":"refs/changes/88/725288/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/725288/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/725288/1"}}},"commit":{"parents":[{"commit":"207e08c64bc933afbfd5f5c4ddca9a75a1c7d07f","subject":"Merge \"sharding: Add probe test that exercises swift-manage-shard-ranges\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/207e08c64bc933afbfd5f5c4ddca9a75a1c7d07f"}]}],"author":{"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","date":"2020-05-04 14:29:47.000000000","tz":120},"committer":{"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","date":"2020-05-04 14:31:24.000000000","tz":120},"subject":"Monkey patch original current_thread _active","message":"Monkey patch original current_thread _active\n\nMonkey patch the original current_thread to use the up-to-date _active\nglobal variable. This solution is based on that documented at:\nhttps://github.com/eventlet/eventlet/issues/592\n\nChange-Id: I6431af7975f794ef264bd319b68db52ce4062c4b\nCloses-Bug: #1863021\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ec73cee8e614484abaa17421f4cfee85144d2b59"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ec73cee8e614484abaa17421f4cfee85144d2b59"}]},"branch":"refs/heads/master"},"aa4d6fbf84de984a6dde849b0e55d60e5ed42310":{"kind":"REWORK","_number":2,"created":"2020-05-05 14:12:01.000000000","uploader":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"ref":"refs/changes/88/725288/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/725288/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/725288/2"}}},"commit":{"parents":[{"commit":"e00ba15f43b9b62182aaeab0f35ca89c7943d92b","subject":"Merge \"Switch to new grenade job name\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e00ba15f43b9b62182aaeab0f35ca89c7943d92b"}]}],"author":{"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","date":"2020-05-04 14:29:47.000000000","tz":120},"committer":{"name":"Corey Bryant","email":"corey.bryant@canonical.com","date":"2020-05-05 14:12:00.000000000","tz":-240},"subject":"Monkey patch original current_thread _active","message":"Monkey patch original current_thread _active\n\nMonkey patch the original current_thread to use the up-to-date _active\nglobal variable. This solution is based on that documented at:\nhttps://github.com/eventlet/eventlet/issues/592\n\nChange-Id: I6431af7975f794ef264bd319b68db52ce4062c4b\nCloses-Bug: #1863021\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/aa4d6fbf84de984a6dde849b0e55d60e5ed42310"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/aa4d6fbf84de984a6dde849b0e55d60e5ed42310"}]},"branch":"refs/heads/master"},"c4267c94f53d93d6bd90cfe403a1d12e84e42805":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2020-05-06 06:09:33.000000000","uploader":{"_account_id":20634,"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","username":"Chris.MacNaughton"},"ref":"refs/changes/88/725288/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/725288/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/725288/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/725288/3"}}},"commit":{"parents":[{"commit":"207e08c64bc933afbfd5f5c4ddca9a75a1c7d07f","subject":"Merge \"sharding: Add probe test that exercises swift-manage-shard-ranges\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/207e08c64bc933afbfd5f5c4ddca9a75a1c7d07f"}]}],"author":{"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","date":"2020-05-04 14:29:47.000000000","tz":120},"committer":{"name":"Chris MacNaughton","email":"chris.macnaughton@canonical.com","date":"2020-05-06 06:09:25.000000000","tz":120},"subject":"Monkey patch original current_thread _active","message":"Monkey patch original current_thread _active\n\nMonkey patch the original current_thread to use the up-to-date _active\nglobal variable. This solution is based on that documented at:\nhttps://github.com/eventlet/eventlet/issues/592\n\nChange-Id: I6431af7975f794ef264bd319b68db52ce4062c4b\nCloses-Bug: #1863021\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c4267c94f53d93d6bd90cfe403a1d12e84e42805"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c4267c94f53d93d6bd90cfe403a1d12e84e42805"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}