)]}'
{"swift/common/middleware/proxy_logging.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"b5813c8ec69ac21d7a0063f567f60f7e790e7873","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        acc, cont, obj \u003d None, None, None"},{"line_number":228,"context_line":"        if req.path.startswith(\u0027/v1/\u0027):"},{"line_number":229,"context_line":"            _, acc, cont, obj \u003d split_path(req.path, 1, 4, True)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        replacements \u003d {"},{"line_number":232,"context_line":"            # Time information"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_43e905b5","side":"PARENT","line":229,"updated":"2020-05-18 16:15:08.000000000","message":"so I guess currently in the s3api case the message still gets LOGGED, but (a, c, o) are just None.\n\nSo maybe this is always an improvement?  should there be an s3api \u003d True replacement or something?","commit_id":"08db36a295377fc437c56f6fc470be035fd74c4f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a8e92a9a442a5b1194101d8da4c32eb739705ff7","unresolved":false,"context_lines":[{"line_number":300,"context_line":"            self.access_logger.update_stats(metric_name_policy + \u0027.xfer\u0027,"},{"line_number":301,"context_line":"                                            bytes_received + bytes_sent)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def get_metric_name_type(self, req):"},{"line_number":304,"context_line":"        if req.path.startswith(\u0027/v1/\u0027):"},{"line_number":305,"context_line":"            try:"},{"line_number":306,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_cb4f8abc","line":303,"updated":"2020-06-08 18:52:02.000000000","message":"Oughta use backend path here, too.","commit_id":"a8c0845739c894ef5c72f941272ad8ffee984638"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"365fe06f2fca1c8949e4a0539d026b317b28d00a","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                            bytes_received + bytes_sent)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def get_metric_name_type(self, req):"},{"line_number":304,"context_line":"        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)"},{"line_number":305,"context_line":"        if swift_path.startswith(\u0027/v1/\u0027):"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff570b3c_4b0d2134","line":304,"updated":"2020-06-23 17:14:50.000000000","message":"So I\u0027m a little nervous that this is going to have us doubling-up our transfer stats for S3 requests -- but at the same time, it\u0027s rather crippling not having good graphs for client-facing response codes :-(","commit_id":"dbf73990207c655d782b6db224e5b711ba4b6403"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"9480e82b6db767180472d5ddee2ed2f777094ba3","unresolved":false,"context_lines":[{"line_number":301,"context_line":"                                            bytes_received + bytes_sent)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def get_metric_name_type(self, req):"},{"line_number":304,"context_line":"        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)"},{"line_number":305,"context_line":"        if swift_path.startswith(\u0027/v1/\u0027):"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_64614f12","line":304,"in_reply_to":"ff570b3c_4b0d2134","updated":"2020-06-30 19:13:49.000000000","message":"I\u0027m getting less and less worried about this -- if you want *accurate* stats, you use firewall counts, and if you need accurate stats per-account, you use something like ceilometermiddleware pretty far to the left of everything else.","commit_id":"dbf73990207c655d782b6db224e5b711ba4b6403"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3949eed263092340ae6e9650b9da403c1328c5b2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        acc, cont, obj \u003d None, None, None"},{"line_number":228,"context_line":"        swift_path \u003d req.environ.get(\u0027swift.backend_path\u0027, req.path)"},{"line_number":229,"context_line":"        if swift_path.startswith(\u0027/v1/\u0027):"},{"line_number":230,"context_line":"            _, acc, cont, obj \u003d split_path(swift_path, 1, 4, True)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"        replacements \u003d {"},{"line_number":233,"context_line":"            # Time information"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_40ece9f2","line":230,"updated":"2020-07-01 14:44:30.000000000","message":"this is the first time we try to *use* backend_path in tree and it\u0027s only set in s3api\n\nthe if .startswith v1 pattern came out the metrics path parsing and was probably carried forward to configurable logging","commit_id":"e9b3adbedf5c40dfb6a218bb76f13978ce194e23"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3949eed263092340ae6e9650b9da403c1328c5b2","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        if swift_path.startswith(\u0027/v1/\u0027):"},{"line_number":306,"context_line":"            try:"},{"line_number":307,"context_line":"                stat_type \u003d [None, \u0027account\u0027, \u0027container\u0027,"},{"line_number":308,"context_line":"                             \u0027object\u0027][swift_path.strip(\u0027/\u0027).count(\u0027/\u0027)]"},{"line_number":309,"context_line":"            except IndexError:"},{"line_number":310,"context_line":"                stat_type \u003d \u0027object\u0027"},{"line_number":311,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_80ca8117","line":308,"updated":"2020-07-01 14:44:30.000000000","message":"there\u0027s some duplication here","commit_id":"e9b3adbedf5c40dfb6a218bb76f13978ce194e23"}]}