)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"071898955a0fc362dfcfc4fb9ce498c3584eae80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7152b08f_7799b15a","updated":"2022-05-02 06:12:48.000000000","message":"Frogot to score. Plus 1 because of inline questions. ","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ec88451448076ef6ef1083b39b26da0a5f3a26ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46318d7e_4a8e51b3","updated":"2022-05-02 06:12:19.000000000","message":"Nice to see a bunch of pickle data being removed. But this will mean another rebase on https://review.opendev.org/c/openstack/swift/+/820648 oh well. Nice to see a banch that removes code 😊\n\nWould we ever be able to remove the PICKLE_FLAG? or because of larger jump upgrades are we stuck with it?","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"86aeacddebb47303140c11405bfc95a7be40179a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ded11933_a5990fdd","updated":"2022-05-05 05:48:55.000000000","message":"This will mean I\u0027ll have to rebase https://review.opendev.org/c/openstack/swift/+/820648 again but, nice to see old cruft gone.","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"161719da364aea11be56a06aa8ef4023fde6066b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0ca9ae6e_d83fa255","updated":"2022-05-03 23:16:59.000000000","message":"recheck\n\nLooks like the eventlet logging deadlock: https://github.com/eventlet/eventlet/issues/742","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"b29d01fe447b81f51f1482bed1bebc4addcf8607","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2f827515_c268ec95","updated":"2022-05-03 17:34:53.000000000","message":"recheck\n\nSlow probe test was resolved by https://review.opendev.org/c/openstack/swift/+/839828/","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"}],"swift/common/memcached.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ec88451448076ef6ef1083b39b26da0a5f3a26ae","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                            size \u003d int(line[3])"},{"line_number":358,"context_line":"                            value \u003d fp.read(size)"},{"line_number":359,"context_line":"                            if int(line[2]) \u0026 PICKLE_FLAG:"},{"line_number":360,"context_line":"                                value \u003d None"},{"line_number":361,"context_line":"                            if int(line[2]) \u0026 JSON_FLAG:"},{"line_number":362,"context_line":"                                value \u003d json.loads(value)"},{"line_number":363,"context_line":"                            fp.readline()"}],"source_content_type":"text/x-python","patch_set":3,"id":"442faa72_7661c90d","line":360,"updated":"2022-05-02 06:12:19.000000000","message":"So if there is anything pickled in memacache still it\u0027ll be as if _allow_unpickle want disabled and returns None. Cool. At what point do you think we can remove the PICKLE flag all together? The flags arbitary right?\nMaybe after next release? or do we keep this here \"forever\" to aid large jump upgrades?","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3365bd495b60203067c820b6ac2f1ac3ce8d0008","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                            size \u003d int(line[3])"},{"line_number":358,"context_line":"                            value \u003d fp.read(size)"},{"line_number":359,"context_line":"                            if int(line[2]) \u0026 PICKLE_FLAG:"},{"line_number":360,"context_line":"                                value \u003d None"},{"line_number":361,"context_line":"                            if int(line[2]) \u0026 JSON_FLAG:"},{"line_number":362,"context_line":"                                value \u003d json.loads(value)"},{"line_number":363,"context_line":"                            fp.readline()"}],"source_content_type":"text/x-python","patch_set":3,"id":"6ab247d7_c6959a92","line":360,"in_reply_to":"442faa72_7661c90d","updated":"2022-05-03 17:37:07.000000000","message":"I was thinking \"forever\" -- it\u0027s pretty lightweight. I could be convinced to drop it now, though.","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"86aeacddebb47303140c11405bfc95a7be40179a","unresolved":true,"context_lines":[{"line_number":357,"context_line":"                            size \u003d int(line[3])"},{"line_number":358,"context_line":"                            value \u003d fp.read(size)"},{"line_number":359,"context_line":"                            if int(line[2]) \u0026 PICKLE_FLAG:"},{"line_number":360,"context_line":"                                value \u003d None"},{"line_number":361,"context_line":"                            if int(line[2]) \u0026 JSON_FLAG:"},{"line_number":362,"context_line":"                                value \u003d json.loads(value)"},{"line_number":363,"context_line":"                            fp.readline()"}],"source_content_type":"text/x-python","patch_set":3,"id":"e1ec9081_ccf6cb1e","line":360,"in_reply_to":"6ab247d7_c6959a92","updated":"2022-05-05 05:48:55.000000000","message":"Nah it\u0027s fine, or we could drop it when later when we\u0027re like, it\u0027s been gone for ages :P \n\nJust thinking ahead.","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"}],"test/unit/common/test_memcached.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"ec88451448076ef6ef1083b39b26da0a5f3a26ae","unresolved":true,"context_lines":[{"line_number":777,"context_line":"        key \u003d next(iter(mock.cache))"},{"line_number":778,"context_line":"        self.assertEqual(mock.cache[key][0], b\u00272\u0027)  # JSON_FLAG"},{"line_number":779,"context_line":"        # Pretend we\u0027ve got some really old pickle data in there"},{"line_number":780,"context_line":"        mock.cache[key] \u003d (b\u00271\u0027,) + mock.cache[key][1:]"},{"line_number":781,"context_line":"        self.assertIsNone(memcache_client.get(\u0027some_key\u0027))"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def test_connection_pooling(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fd59376d_802a207c","line":780,"updated":"2022-05-02 06:12:19.000000000","message":"Nice","commit_id":"11b9761cdf0fb7a00b1add913a0be31d8e8b93da"}]}