)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"6d1afbdb5a8be187853134d9c4aba06c9129447e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0c20ca7_65ea3400","updated":"2026-07-16 23:03:24.000000000","message":"recheck\n\nFailure in set-up for `tempest.api.volume.test_image_metadata.VolumesImageMetadata`: `tempest.exceptions.VolumeResourceBuildErrorException: volume f2bf6d32-899f-449e-9868-607ced30c038 failed to build and is in ERROR status` -- seems like not us.","commit_id":"0def5ae98c719414b705cdb931c5b36d06646a6d"}],"swift/common/middleware/s3api/s3api.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f403b9e6d5d63c66aa2faa747405fbcf1945eb49","unresolved":true,"context_lines":[{"line_number":483,"context_line":"        return resp(env, start_response)"},{"line_number":484,"context_line":""},{"line_number":485,"context_line":"    def handle_request(self, req):"},{"line_number":486,"context_line":"        self.logger.debug(\u0027Calling S3Api Middleware\u0027)"},{"line_number":487,"context_line":"        try:"},{"line_number":488,"context_line":"            controller \u003d req.controller(self.app, self.conf, self.logger)"},{"line_number":489,"context_line":"        except S3NotImplemented:"}],"source_content_type":"text/x-python","patch_set":2,"id":"6198f088_d64ee061","side":"PARENT","line":486,"updated":"2026-07-17 08:41:19.000000000","message":"I *might* miss this, let\u0027s see","commit_id":"977d7c021ebe93b5e82ffef88a64381da7faa032"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f403b9e6d5d63c66aa2faa747405fbcf1945eb49","unresolved":true,"context_lines":[{"line_number":489,"context_line":"        except S3NotImplemented:"},{"line_number":490,"context_line":"            # TODO: Probably we should distinct the error to log this warning"},{"line_number":491,"context_line":"            self.logger.warning(\u0027multipart: No SLO middleware in pipeline\u0027)"},{"line_number":492,"context_line":"            raise"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        acl_handler \u003d get_acl_handler(req.controller_name)(req, self.logger)"},{"line_number":495,"context_line":"        req.set_acl_handler(acl_handler)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c460c4fc_ba3c812e","side":"PARENT","line":492,"updated":"2026-07-17 08:41:19.000000000","message":"+1 for removing:\n\n1. this is anomalous: there\u0027s plenty of other cases when S3NotImplemented is raised, but it is raised when the controller is called, not when it is instantiated, and we\u0027re not logging every one of those.\n\n2. this is fragile: req.controller() could change to raise S3NotImplemented in other cases and we\u0027d still log it as multipart. I think the TODO is hinting at this.\n\n3. It\u0027s apparently not covered by tests!","commit_id":"977d7c021ebe93b5e82ffef88a64381da7faa032"}]}
