)]}'
{"id":"openstack%2Fswift~740828","triplet_id":"openstack%2Fswift~master~I337f8d0f1fbeee7ae927a581eecbbbcc6dc69340","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I337f8d0f1fbeee7ae927a581eecbbbcc6dc69340","subject":"Add a reminder to configure firewall at storage nodes","status":"MERGED","created":"2020-07-13 23:36:38.000000000","updated":"2020-07-14 17:11:19.000000000","submitted":"2020-07-14 16:29:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"740828-1594744157849-bfbdc47d","meta_rev_id":"383f4142d30fce615b312bd35900a5c710c97e73","_number":740828,"virtual_id_number":740828,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22696,"name":"Mike Abrams"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-14 16:29:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"recommended":{"_account_id":22696,"name":"Mike Abrams"},"all":[{"value":1,"date":"2020-07-14 07:27:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22696,"name":"Mike Abrams"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-07-13 23:58:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":22696,"name":"Mike Abrams"},{"value":1,"date":"2020-07-14 15:11:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22696,"name":"Mike Abrams"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-13 23:58:27.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2020-07-14 07:27:03.000000000","updated_by":{"_account_id":22696,"name":"Mike Abrams"},"reviewer":{"_account_id":22696,"name":"Mike Abrams"},"state":"REVIEWER"},{"updated":"2020-07-14 15:11:33.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-07-14 16:29:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"759e6b0705ec68fdf3e5b60c0b0866e954376bde","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-07-13 23:36:38.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7cb34651206a6261eef595905051b00bb9469eb8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-13 23:50:40.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/276014cdbba249d58c8e0aa882f705fb : SUCCESS in 8m 23s","accounts_in_message":[],"_revision_number":1},{"id":"687f49fbe6b2c354cf4115e775ae3851d72a73e0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-13 23:58:27.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)\n\nHandful of questions -- I\u0027m still fairly new to configuring firewalld. But this seems undoubtedly an improvement!","accounts_in_message":[],"_revision_number":1},{"id":"b53df5a8f7d428420b499a4b606b3ad45e5cf4d3","author":{"_account_id":22696,"name":"Mike Abrams"},"date":"2020-07-14 07:27:03.000000000","message":"Patch Set 1: Code-Review+1\n\ngood point Tim, the flow of the doc would make the firewalld settings associate with each section instead of all-in-one.  good idea!\n\ni will convey this to RH docs team.\n\nthnk you","accounts_in_message":[],"_revision_number":1},{"id":"de683e10240ab156d56c20a0f9283a93bd5ac9d1","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-07-14 15:11:33.000000000","message":"Patch Set 1: Workflow+1\n\nThis seems like a welcome improvement to address the related RH bz#\n\nthere may be other ways to address the underlying lack of service port enumeration for firewall configuration in a more comprehensive way, but this change on it\u0027s own is very limited in scope - no harm no foul - we can always make it better down the road.","accounts_in_message":[],"_revision_number":1},{"id":"eae986450b59f42c63f1b6c1322717693cf22c92","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 15:12:01.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8c7099f924cdd40d23703c42a18047ec482c9823","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 16:29:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"84e229c4dabc1efc897c322589aefa15977ca361","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 16:29:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5282b90fbb324526840482cdceb571c9 : SUCCESS in 8m 41s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/670046db888c483891cbe09e0968cf72 : SUCCESS in 10m 03s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/f052c15c912f42fda5bdc1cd2f7c04ff : SUCCESS in 14m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f2994d4b3f4ee9e721f14f56f6c1ddf23ec85281","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 16:31:11.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/09a6319ab9a24210ab4ed6265cf8bd65 : SUCCESS in 1m 32s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/7b962c1358a6428a9732cb38fe2188e4 : SUCCESS in 1m 02s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/78076a893afe471e9deaf0bcfefa6e08 : SUCCESS in 1m 08s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"383f4142d30fce615b312bd35900a5c710c97e73","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-07-14 17:11:19.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a5ec383260303d6b035e19294967a63d092d55b5","revisions":{"a5ec383260303d6b035e19294967a63d092d55b5":{"kind":"REWORK","_number":1,"created":"2020-07-13 23:36:38.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/28/740828/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/28/740828/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/28/740828/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/28/740828/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/28/740828/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/28/740828/1"}}},"commit":{"parents":[{"commit":"2e001431fd0907c97d44b81dd1f3d2d14ae1208b","subject":"s3api: Don\u0027t do naive HEAD request for auth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2e001431fd0907c97d44b81dd1f3d2d14ae1208b"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2020-07-13 23:33:15.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2020-07-13 23:33:15.000000000","tz":-300},"subject":"Add a reminder to configure firewall at storage nodes","message":"Add a reminder to configure firewall at storage nodes\n\nMy customers use the upstream documentation for manual\ninstallation of Swift nodes and they come upon the lack\nof any mention that host firewall ought to accomodate\nservices running on the node. Perhaps we thought it\nself-evident in Swift.\n\nRelated RH bz#: 1797814\n\nChange-Id: I337f8d0f1fbeee7ae927a581eecbbbcc6dc69340\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a5ec383260303d6b035e19294967a63d092d55b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a5ec383260303d6b035e19294967a63d092d55b5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}