)]}'
{"id":"openstack%2Fswift~741016","triplet_id":"openstack%2Fswift~master~I341f5f5d2f480310c83e35a8f3c6c2e0d56dab2e","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I341f5f5d2f480310c83e35a8f3c6c2e0d56dab2e","subject":"sharding: Change default cleave_batch_size to 3","status":"ABANDONED","created":"2020-07-14 17:52:24.000000000","updated":"2026-07-16 22:15:25.000000000","total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"58c041c946b1baa0bb667cc5eebd20e3c1d47e29","_number":741016,"virtual_id_number":741016,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2020-11-08 23:49:10.000000000","_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"date":"2020-10-29 16:18:57.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-07-15 22:21:31.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-07-15 18:10:05.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-15 22:21:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-10-29 16:18:57.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2020-11-08 23:49:10.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"}],"messages":[{"id":"c77a526ae6fec6c731935790e75f09e123897aa8","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-14 17:52:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"584ed9faa3308f99cc201a727372b7b01f588d24","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-14 17:54:03.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nProbe tests may need an update, too.","accounts_in_message":[],"_revision_number":1},{"id":"b1c1162656f5b3e393c5dfe256464673c1c75f65","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-14 19:10:45.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/79b28bf01a574897af6c2439f26f0d80 : SUCCESS in 10m 32s\n- grenade https://zuul.opendev.org/t/openstack/build/16e56ae7030c4eb69473071ecfeb66df : SUCCESS in 1h 04m 24s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/955e50ebdd8e4782a21be181d253381f : SUCCESS in 50m 47s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/58a94679f33e489786624b059e16f8be : SUCCESS in 11m 12s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/adfa535bdf1e4e8c8b8d84cdb1dca4ac : SUCCESS in 13m 12s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/65f26146e7e04c189df7ee387534394b : SUCCESS in 12m 43s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/161e11fd3fff4a47b9b09ab188ac6d8b : SUCCESS in 16m 26s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f6366a00cd8f43818441f784131aaf1c : FAILURE in 19m 38s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/9948daf360574206aba1fbcb8ea5bed5 : SUCCESS in 20m 20s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/71a36440069d4ad09a87963e51c5ecb9 : SUCCESS in 39m 30s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/e34caf3fb9e44e6599d87e3927126bee : SUCCESS in 23m 02s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/57766113c368477fbefceb3eebdfe51c : SUCCESS in 39m 26s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/f5e48a2256a24050b7dc35b9400ba441 : SUCCESS in 17m 17s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/5ced633ea9fa4d4d8589020ab80ce319 : SUCCESS in 31m 14s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/6fb622099df2407da4a7dbfca2134889 : SUCCESS in 24m 14s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/8f3db6644dae416da65d2b408a3cf4f1 : SUCCESS in 21m 23s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a072316c24794143be80c3000bf5c978 : SUCCESS in 45m 53s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/5af98118547946dd84558e26bfa64a74 : SUCCESS in 42m 16s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/0ba5e12070104928b57da781ae98df08 : SUCCESS in 46m 52s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9478db5230ca49fb85d3f07c3341e24c : SUCCESS in 12m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/50e87d50a2e74b4ebd52857a6877dfd4 : SUCCESS in 6m 31s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/e346ac979b4e461f8756f56809d5eaec : FAILURE in 10m 11s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/01a21cd56f8f4468add00608366112e6 : SUCCESS in 1h 04m 24s","accounts_in_message":[],"_revision_number":1},{"id":"a89ab366d14e8df8f338b6c86a5059d09d2b4417","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-15 18:10:05.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"839af708cd9ef1216b12deebf3086681ec62a92e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-15 22:21:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b30ba457da08467abeee9dc6891cff2d : SUCCESS in 9m 45s\n- grenade https://zuul.opendev.org/t/openstack/build/91af8d4acf0244d1917a213f6b5cdbaf : SUCCESS in 1h 10m 58s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/740c5a524fa2444b9dd859a23fdf7b77 : SUCCESS in 32m 49s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/9913fd6d56c0476f9f3fc8dbb262537a : SUCCESS in 9m 21s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f3fb65299c9b47c3abe07b2896c8648c : SUCCESS in 12m 13s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/44631e2b8d43424ba32679a724d299ec : SUCCESS in 20m 50s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/0f1052bff18045e6b1a35bb46d4356cb : SUCCESS in 13m 52s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/b9f72c8237214a13831681ada617279a : SUCCESS in 14m 04s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/3d74eba4f228431db8132896cc220258 : SUCCESS in 13m 40s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/4ffadca95a0d48a5b86c42a225683e02 : SUCCESS in 17m 04s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/bd642829dfda4747b6bc6e032c6f58bb : SUCCESS in 16m 50s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/e839c4f251b047d4a3d2c4f3b7b921a9 : SUCCESS in 27m 28s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/d81c33dd36f34597b692bcde732ce6ad : SUCCESS in 22m 56s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/6350d8cac988441893a771e5b283c9d4 : SUCCESS in 20m 46s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/1e6708435a904b1ba1b9c58dc06d7172 : SUCCESS in 18m 54s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/d8a71e304841402dbde4dc45310356c8 : SUCCESS in 26m 10s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/30b8c157b08e444c8bc27dd76b564b4f : SUCCESS in 1h 23m 37s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/bee87439494c4c5196533b69ddccfa3c : SUCCESS in 41m 31s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/0a9ca15630094a53a7ebe10aecac7854 : SUCCESS in 55m 51s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5e7bb0207e3e42b29b76081a497dd5da : SUCCESS in 15m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6649194b539e4945b3fbc19e662408e6 : SUCCESS in 6m 29s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/46b1d1b85fec412b88ce90e5089a6d33 : FAILURE in 11m 39s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2a8545e56ce04e689040e7c9dd35d6f5 : SUCCESS in 1h 07m 39s","accounts_in_message":[],"_revision_number":1},{"id":"3063fef5e6e121c50dc7e06c7637e72267ea9165","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2020-10-29 16:18:57.000000000","message":"Patch Set 1:\n\nSo, is it 3 or 12?","accounts_in_message":[],"_revision_number":1},{"id":"70d67497f2c0eff3c6d61e680b39db418b8ff48e","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2020-11-08 23:49:10.000000000","message":"Patch Set 1:\n\nYeah looks good, but I wonder if we could do a check in broker.find_shard_ranges to if object_count - progress \u003c shard_container_threshold to stop?\n\nBecause when we have auto sharding on are we going to regularly have a small sr? ie only a few objects big (because we\u0027re checking \u003e shard_threshold before a cleave), that will then get shrunk on the next cycle?","accounts_in_message":[],"_revision_number":1},{"id":"58c041c946b1baa0bb667cc5eebd20e3c1d47e29","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2026-07-16 22:15:25.000000000","message":"Abandoned\n\nI think this is no longer necessary following https://review.opendev.org/c/openstack/swift/+/794582","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"218462fd8a277cea9739e20354cc1eea6dbc4a86","revisions":{"218462fd8a277cea9739e20354cc1eea6dbc4a86":{"kind":"REWORK","_number":1,"created":"2020-07-14 17:52:24.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/16/741016/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/16/741016/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/741016/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/741016/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/16/741016/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/16/741016/1"}}},"commit":{"parents":[{"commit":"2e001431fd0907c97d44b81dd1f3d2d14ae1208b","subject":"s3api: Don\u0027t do naive HEAD request for auth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2e001431fd0907c97d44b81dd1f3d2d14ae1208b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-14 17:44:51.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-14 17:44:55.000000000","tz":-420},"subject":"sharding: Change default cleave_batch_size to 3","message":"sharding: Change default cleave_batch_size to 3\n\nWhen sharding, we use the shard_container_threshold size to determine\nboth when to shard and how many rows to put in each shard (calculated\nas shard_container_threshold // 2). As a result, a sharding container\nin a healthy cluster typically splits into three shards.\n\nWith the previous default batch size, this would mean that sharding\nwould almost always require two sharder cycles to complete. This can\nmake for long delays in objects appearing in listings, particularly if\nyou\u0027re intentionally lengthening sharder and replication cycles in an\neffort to reduce container-layer contention.\n\nChange-Id: I341f5f5d2f480310c83e35a8f3c6c2e0d56dab2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/218462fd8a277cea9739e20354cc1eea6dbc4a86"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/218462fd8a277cea9739e20354cc1eea6dbc4a86"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}