)]}'
{"id":"openstack%2Fswift~741544","triplet_id":"openstack%2Fswift~master~I8f9b5cf7f5749481ef391a2029b0c4263443a89b","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I8f9b5cf7f5749481ef391a2029b0c4263443a89b","subject":"probe tests: Get rid of `server` arg for device_dir() and storage_dir()","status":"MERGED","created":"2020-07-16 20:51:14.000000000","updated":"2020-07-22 04:15:09.000000000","submitted":"2020-07-22 04:12:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"741544-1595391147059-437a17ce","meta_rev_id":"19ab75017bb406fcc3d32a2d3f9216a969aae23c","_number":741544,"virtual_id_number":741544,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-07-22 04:12:26.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"date":"2020-07-21 22:53:05.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":2,"date":"2020-07-20 15:58:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-07-22 03:50:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2020-07-20 15:58:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-20 15:58:54.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2020-07-22 03:50:41.000000000","updated_by":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"reviewer":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"state":"REVIEWER"},{"updated":"2020-07-22 04:12:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"f33c558d920f25130bf5253844fc471c02d3c08c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-16 20:51:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"574342099f1ea2480a538b0a09d0c2a48dc562b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-16 21:54:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/29ab04763d4c4c3b8a390efcfefb0871 : SUCCESS in 9m 17s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/607150ac5c8d46998585c659f6808db2 : SUCCESS in 1h 02m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/925bc875a7cf412d9b37c27e1687a4c0 : SUCCESS in 6m 42s","accounts_in_message":[],"_revision_number":1},{"id":"1fc1de6dde542bddfa2646d7cf5b793376146de1","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-07-20 15:58:54.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(2 comments)\n\nI\u0027ll hope there\u0027s some reasonable explanation of how it came to this but... yeah certainly seems like an improvement at this point.","accounts_in_message":[],"_revision_number":1},{"id":"1f7ba3898cd18646ba566209a4b117030febe446","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-20 15:59:16.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d7008a48fe288e78756350a12ec63bf6b81a0d28","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-20 18:53:28.000000000","message":"Patch Set 1:\n\nYeah, it got refactored out when Darrell added support for servers_per_port: https://github.com/openstack/swift/commit/df134df","accounts_in_message":[],"_revision_number":1},{"id":"e8e67439422e5c07755e0393afff1904c042b562","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-20 18:54:36.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/84d748f2f9a941b19bc38b7a2927cf5a : SUCCESS in 8m 00s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/61c1c2288ab54c05a52082be10f4efb4 : SUCCESS in 10m 00s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/83543c8aaea64cf78ee945966bd27580 : SUCCESS in 8m 57s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a9c58be1a7474ca69f55afb52c3f8ec4 : SUCCESS in 14m 02s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/ee2fdefedc804b54b9f30fe9390c6522 : SUCCESS in 13m 45s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/85126f2c8028460f8fe8b79121521f0e : SUCCESS in 12m 32s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/66e689ab60494a83a13c57f865f5274d : SUCCESS in 17m 27s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/f15319f2e0464acd8a82d133acede263 : SUCCESS in 20m 22s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/fb9de3c8f40241e3a70f9bb2c13e56ae : SUCCESS in 22m 35s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/7b897b2e870640e4ad51d08a17f4570c : SUCCESS in 21m 19s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/adcfd26c55e446fbb9ffa50355ff29b9 : FAILURE in 17m 53s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/3e4d3b8631b64107993ec5a694b68ab7 : FAILURE in 22m 15s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7483daa473354fdf84480f9d2b137898 : RETRY_LIMIT in 5m 44s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/88cc09a7d5124627a7c4c174cf859c72 : SUCCESS in 7m 11s","accounts_in_message":[],"_revision_number":1},{"id":"e1965a5597977af20ec7908be1042ada963f29e0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-21 22:53:05.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6e3e0d74b39177f14627699c0dbf4a478bd0e17e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 02:37:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/54befb10904c488cb105a1887cfa24cd : SUCCESS in 8m 46s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/1dfdcc9939824bfc81d0acb3e1ca16e4 : SUCCESS in 45m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17be5770cb784a66842e31f0edc0c349 : SUCCESS in 6m 08s","accounts_in_message":[],"_revision_number":1},{"id":"8f5b60e11a7bdecee0f202127bffcd0692adce38","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 02:38:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"11d29710979c9a0c1eda902f172364850d16bb02","author":{"_account_id":32029,"name":"likui","email":"likui@yovole.com","username":"likui"},"date":"2020-07-22 03:50:41.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"a83c7da59e2d95b95e44c1ff1480905efcc320bb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 04:12:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2324104b1f2f421fbda9d48f262669e8 : SUCCESS in 8m 40s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/edaf1b00a2fa46b882760b189b12c260 : SUCCESS in 9m 21s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/29daa99ee6534ccb941b10d506d73d4e : SUCCESS in 9m 45s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/bbfc2859983f4728a94ef8d097f223c9 : SUCCESS in 12m 27s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/76f270c236774f24bee00a48a894fcc7 : SUCCESS in 13m 17s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/3542ebe7480c414faf81eb853060060d : SUCCESS in 14m 40s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/3919873d2f66484393166a1a236a03c6 : SUCCESS in 12m 32s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/00438112701e442b83f2390979b3dc5b : SUCCESS in 17m 06s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/36d434e21f8e4a628e3a78c8ded9fb6d : SUCCESS in 16m 02s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/cb0cbf8b12f34a6b99b585a57107ef17 : SUCCESS in 18m 02s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/f3833cbff4064e699d36ca2f85746561 : SUCCESS in 19m 17s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/29718f4092c6458e94763f682e7af461 : SUCCESS in 17m 47s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/324a4b2182af4bf2abb89286e6111114 : SUCCESS in 41m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/250cbf9cef0f44729887e5e78520ff86 : SUCCESS in 6m 16s","accounts_in_message":[],"_revision_number":1},{"id":"434294881c1953291a94e5f0bc9d939be83abed6","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 04:12:27.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"19ab75017bb406fcc3d32a2d3f9216a969aae23c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-22 04:15:09.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a292e1eda9b4dc5acd9cd5b39cf68e9 : SUCCESS in 1m 02s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/4217300c168948ae8f3268baf9c92d6f : FAILURE in 42s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/41d69712200c418e822e778506935321 : FAILURE in 43s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5bd95cf2b75d30f97b301b0c4752edeb8b311fd0","revisions":{"5bd95cf2b75d30f97b301b0c4752edeb8b311fd0":{"kind":"REWORK","_number":1,"created":"2020-07-16 20:51:14.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/44/741544/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/44/741544/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/741544/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/741544/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/44/741544/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/44/741544/1"}}},"commit":{"parents":[{"commit":"2e001431fd0907c97d44b81dd1f3d2d14ae1208b","subject":"s3api: Don\u0027t do naive HEAD request for auth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2e001431fd0907c97d44b81dd1f3d2d14ae1208b"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-16 20:50:58.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-16 20:50:58.000000000","tz":-420},"subject":"probe tests: Get rid of `server` arg for device_dir() and storage_dir()","message":"probe tests: Get rid of `server` arg for device_dir() and storage_dir()\n\nIt\u0027s not actually *used* anywhere.\n\nChange-Id: I8f9b5cf7f5749481ef391a2029b0c4263443a89b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5bd95cf2b75d30f97b301b0c4752edeb8b311fd0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5bd95cf2b75d30f97b301b0c4752edeb8b311fd0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
