)]}'
{"swift/obj/replicator.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":502,"context_line":"            suffixes \u003d tpool.execute(tpool_get_suffixes, job[\u0027path\u0027])"},{"line_number":503,"context_line":"            synced_remote_regions \u003d {}"},{"line_number":504,"context_line":"            delete_objs \u003d None"},{"line_number":505,"context_line":"            hashed, local_hash \u003d tpool_reraise("},{"line_number":506,"context_line":"                get_hashes, job[\u0027path\u0027],"},{"line_number":507,"context_line":"                do_listdir\u003d(self.replication_count % 10) \u003d\u003d 0,"},{"line_number":508,"context_line":"                reclaim_age\u003dself.reclaim_age)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_61d593b7","line":505,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: F821 undefined name \u0027tpool_reraise\u0027","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":503,"context_line":"            synced_remote_regions \u003d {}"},{"line_number":504,"context_line":"            delete_objs \u003d None"},{"line_number":505,"context_line":"            hashed, local_hash \u003d tpool_reraise("},{"line_number":506,"context_line":"                get_hashes, job[\u0027path\u0027],"},{"line_number":507,"context_line":"                do_listdir\u003d(self.replication_count % 10) \u003d\u003d 0,"},{"line_number":508,"context_line":"                reclaim_age\u003dself.reclaim_age)"},{"line_number":509,"context_line":"            if suffixes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_c1e29fa0","line":506,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: F821 undefined name \u0027get_hashes\u0027","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                            self.logger.error("},{"line_number":526,"context_line":"                                _(\u0027%(replication_ip)s/%(device)s \u0027"},{"line_number":527,"context_line":"                                  \u0027responded as unmounted\u0027), node)"},{"line_number":528,"context_line":"                            attempts_left +\u003d 1"},{"line_number":529,"context_line":"                            failure_devs_info.add((node[\u0027replication_ip\u0027],"},{"line_number":530,"context_line":"                                                   node[\u0027device\u0027]))"},{"line_number":531,"context_line":"                            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_a1dfabd4","line":528,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: F821 undefined name \u0027attempts_left\u0027","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                            self.logger.error("},{"line_number":526,"context_line":"                                _(\u0027%(replication_ip)s/%(device)s \u0027"},{"line_number":527,"context_line":"                                  \u0027responded as unmounted\u0027), node)"},{"line_number":528,"context_line":"                            attempts_left +\u003d 1"},{"line_number":529,"context_line":"                            failure_devs_info.add((node[\u0027replication_ip\u0027],"},{"line_number":530,"context_line":"                                                   node[\u0027device\u0027]))"},{"line_number":531,"context_line":"                            continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_01ee578a","line":528,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: F841 local variable \u0027attempts_left\u0027 is assigned to but never used","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":540,"context_line":"                        remote_hash \u003d pickle.loads(resp.read())"},{"line_number":541,"context_line":"                        del resp"},{"line_number":542,"context_line":"                    node_suffixes \u003d [suffix for suffix in local_hash if"},{"line_number":543,"context_line":"                                local_hash[suffix] !\u003d"},{"line_number":544,"context_line":"                                remote_hash.get(suffix, -1)]"},{"line_number":545,"context_line":"                    if not node_suffixes:"},{"line_number":546,"context_line":"                        continue"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_e1f2436f","line":543,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                        del resp"},{"line_number":542,"context_line":"                    node_suffixes \u003d [suffix for suffix in local_hash if"},{"line_number":543,"context_line":"                                local_hash[suffix] !\u003d"},{"line_number":544,"context_line":"                                remote_hash.get(suffix, -1)]"},{"line_number":545,"context_line":"                    if not node_suffixes:"},{"line_number":546,"context_line":"                        continue"},{"line_number":547,"context_line":"                    success, candidates \u003d self.sync("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_41e84f7b","line":544,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"8f313c01e66a3e03dfe4cb4e37560e53b989dd9d","unresolved":false,"context_lines":[{"line_number":541,"context_line":"                        del resp"},{"line_number":542,"context_line":"                    node_suffixes \u003d [suffix for suffix in local_hash if"},{"line_number":543,"context_line":"                                local_hash[suffix] !\u003d"},{"line_number":544,"context_line":"                                remote_hash.get(suffix, -1)]"},{"line_number":545,"context_line":"                    if not node_suffixes:"},{"line_number":546,"context_line":"                        continue"},{"line_number":547,"context_line":"                    success, candidates \u003d self.sync("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_fb867565","line":544,"updated":"2020-07-21 14:13:06.000000000","message":"so one of the reasons we\u0027ve not attempted to limit suffixes is we expect most of them to mismatch ... either in a handoff or rebalance situation.\n\nCan you add some stats so that we can quantify this change some how?","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"dcd11468b7809a81f2dc15d8d5f808dc50d09ec2","unresolved":false,"context_lines":[{"line_number":569,"context_line":""},{"line_number":570,"context_line":"            if self.handoff_delete:"},{"line_number":571,"context_line":"                # delete handoff if we have had handoff_delete successes"},{"line_number":572,"context_line":"                delete_handoff \u003d len([resp for resp in responses if resp]) \u003e\u003d \\"},{"line_number":573,"context_line":"                    self.handoff_delete"},{"line_number":574,"context_line":"            else:"},{"line_number":575,"context_line":"                # delete handoff if all syncs were successful"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_21ed5b8b","line":572,"updated":"2020-07-21 18:14:31.000000000","message":"pep8: F812 list comprehension redefines \u0027resp\u0027 from line 520","commit_id":"785ee913f1de4e509d0905924c42b89ae421bc61"}]}
