)]}'
{"id":"openstack%2Fswift~743637","triplet_id":"openstack%2Fswift~master~Ic9ed3b4a4cd8c49a1e0d7ceb730c1c389d2d60ac","project":"openstack/swift","branch":"master","topic":"better-waterfall-ec-patch4","hashtags":[],"change_id":"Ic9ed3b4a4cd8c49a1e0d7ceb730c1c389d2d60ac","subject":"squash: Waterfall EC cleanup","status":"ABANDONED","created":"2020-07-28 21:54:49.000000000","updated":"2020-08-04 18:47:32.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1eea71a5bc56924c2aad08b278ee14f105fe55ee","_number":743637,"virtual_id_number":743637,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-07-28 23:51:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-07-30 19:04:04.000000000","_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":1,"date":"2020-07-30 14:27:03.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-07-28 23:51:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-30 14:27:03.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"bbd99037d5d285b85205780231a0961706377d85","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-28 21:54:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"725532cf1b2c66eb8ca14b07ed17946f4a2e0047","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-28 22:30:41.000000000","message":"Patch Set 1:\n\n(2 comments)","accounts_in_message":[],"_revision_number":1},{"id":"e897c2c5165bf9cd670fb4b7cfe22736401d86b5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-07-28 23:51:26.000000000","message":"Patch Set 1: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a1d56e56e28449079d0ce003b0133055 : SUCCESS in 10m 40s\n- grenade https://zuul.opendev.org/t/openstack/build/9ad816e8e68c4519b575f5bcbfeaeaa2 : SUCCESS in 58m 54s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b30bf131710144948566b4f6bbd2ed24 : SUCCESS in 47m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/ba8e60bdaaef4c6d9cad2865d1b76a06 : SUCCESS in 9m 51s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f4f6673359cf41a0a4e3a403f960f7f4 : SUCCESS in 9m 24s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a5f00e6ac5e54575b26e80466c462a3c : SUCCESS in 14m 05s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/65b4f29934da4d989ffd4a9b0e751ef1 : SUCCESS in 13m 12s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/3f79a69553cc4bdaa225cc20cbbc23c7 : SUCCESS in 14m 20s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/725a68eb274d43b1bdc9924f809f7336 : SUCCESS in 15m 32s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/3ad11e22af2241bca6287afa4c050bdc : SUCCESS in 18m 47s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/b90f9e65fd10458d84c238441c017be6 : SUCCESS in 18m 37s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/ee6cc723754b499d870c05da41dab104 : SUCCESS in 17m 36s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/ea5595037ab4487b879baf58653d492f : SUCCESS in 19m 32s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/a677e101a46842b98d5095d1e2f4fe87 : SUCCESS in 21m 35s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/3335fb11f1114f9686dfe4126292a6d8 : SUCCESS in 21m 08s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/53caba9320ef4122abe29569d963e232 : SUCCESS in 20m 09s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/bb18e86a63d14edf985ccedbdf328eb2 : SUCCESS in 46m 25s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/2d4c7ca76e0a41789af92514c768ef32 : SUCCESS in 42m 37s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/7ac2b7675eec486aa3f8d33d7148676f : SUCCESS in 41m 15s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f63f865e5f6c49c3a603a66ef7fb1f9a : SUCCESS in 13m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1a65730dcc754fe7b55f960e3930b3b8 : FAILURE in 6m 23s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/91117bb15bec41c8b915290acf29c0f8 : FAILURE in 7m 39s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1abdeb4e6e27439da1bd7608bad2f6e9 : SUCCESS in 1h 01m 40s","accounts_in_message":[],"_revision_number":1},{"id":"aedfa40467458ccb444d29b8571562823213164c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-07-30 14:27:03.000000000","message":"Patch Set 1: Code-Review+1\n\noh man there is a ton of great stuff on here\n\nYou\u0027re thinking squash it all down to p 711342?","accounts_in_message":[],"_revision_number":1},{"id":"743e8e63e1149d7273297a71f301ef1a88ba047d","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-07-30 19:04:04.000000000","message":"Patch Set 1:\n\n\u003e You\u0027re thinking squash it all down to p 711342?\n\nYeah, I *think* it\u0027ll all apply cleanly there. Might also want to apply\n\ndiff --git a/swift/proxy/controllers/base.py b/swift/proxy/controllers/base.py\nindex fb6eb1bab..ae9e183cb 100644\n--- a/swift/proxy/controllers/base.py\n+++ b/swift/proxy/controllers/base.py\n@@ -1288,9 +1288,8 @@ class GetOrHeadHandler(object):\n                 close_swift_conn(possible_source)\n             else:\n                 if self.used_source_etag and \\\n-                    self.used_source_etag !\u003d normalize_etag(src_headers.get(\n-                        \u0027x-object-sysmeta-ec-etag\u0027,\n-                        src_headers.get(\u0027etag\u0027, \u0027\u0027))):\n+                    self.used_source_etag !\u003d normalize_etag(\n+                        src_headers.get(\u0027etag\u0027, \u0027\u0027)):\n                     self.statuses.append(HTTP_NOT_FOUND)\n                     self.reasons.append(\u0027\u0027)\n                     self.bodies.append(\u0027\u0027)\n@@ -1391,12 +1390,10 @@ class GetOrHeadHandler(object):\n \n             # Save off the source etag so that, if we lose the connection\n             # and have to resume from a different node, we can be sure that\n-            # we have the same object (replication) or a fragment archive\n-            # from the same object (EC). Otherwise, if the cluster has two\n-            # versions of the same object, we might end up switching between\n-            # old and new mid-stream and giving garbage to the client.\n-            self.used_source_etag \u003d normalize_etag(src_headers.get(\n-                \u0027x-object-sysmeta-ec-etag\u0027, src_headers.get(\u0027etag\u0027, \u0027\u0027)))\n+            # we have the same object (replication). Otherwise, if the cluster\n+            # has two versions of the same object, we might end up switching\n+            # between old and new mid-stream and giving garbage to the client.\n+            self.used_source_etag \u003d normalize_etag(src_headers.get(\u0027etag\u0027, \u0027\u0027))\n             self.node \u003d node\n             return source, node\n         return None, None","accounts_in_message":[],"_revision_number":1},{"id":"59f31e1f8991db4e6369698422ebe6f5267712c2","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-08-04 18:47:32.000000000","message":"Abandoned\n\nthis was successfully squashed, mostly into https://review.opendev.org/#/c/711342/15","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a6192f61080d5f61c941ef2a4d50e73c5cc543d4","revisions":{"a6192f61080d5f61c941ef2a4d50e73c5cc543d4":{"kind":"REWORK","_number":1,"created":"2020-07-28 21:54:49.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/37/743637/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/37/743637/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/743637/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/743637/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/743637/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/37/743637/1"}}},"commit":{"parents":[{"commit":"67695100b413a03eb14e2936d50e4f5f8c40a476","subject":"Add concurrent_ec_extra_requests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/67695100b413a03eb14e2936d50e4f5f8c40a476"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-28 19:53:14.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-07-28 21:49:13.000000000","tz":-420},"subject":"squash: Waterfall EC cleanup","message":"squash: Waterfall EC cleanup\n\nChange-Id: Ic9ed3b4a4cd8c49a1e0d7ceb730c1c389d2d60ac\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a6192f61080d5f61c941ef2a4d50e73c5cc543d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/a6192f61080d5f61c941ef2a4d50e73c5cc543d4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}