)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6908c4e9a9ca54e94d069922a60b400d2253641a","unresolved":false,"context_lines":[{"line_number":2502,"context_line":"                        if new_source:"},{"line_number":2503,"context_line":"                            self.app.error_occurred("},{"line_number":2504,"context_line":"                                self.node, _(\u0027Trying to read object during \u0027"},{"line_number":2505,"context_line":"                                           \u0027GET (retrying)\u0027))"},{"line_number":2506,"context_line":"                            # Close-out the connection as best as possible."},{"line_number":2507,"context_line":"                            if getattr(self.source, \u0027swift_conn\u0027, None):"},{"line_number":2508,"context_line":"                                close_swift_conn(self.source)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_fc62933d","line":2505,"updated":"2020-08-21 01:40:27.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"bd7a6c81c35a19fe5b6d31da475ea65a9169bf86"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6908c4e9a9ca54e94d069922a60b400d2253641a","unresolved":false,"context_lines":[{"line_number":2544,"context_line":"                        if new_source:"},{"line_number":2545,"context_line":"                            self.app.error_occurred("},{"line_number":2546,"context_line":"                                self.node, _(\u0027Trying to read object during \u0027"},{"line_number":2547,"context_line":"                                           \u0027GET (retrying)\u0027))"},{"line_number":2548,"context_line":"                            # Close-out the connection as best as possible."},{"line_number":2549,"context_line":"                            if getattr(self.source, \u0027swift_conn\u0027, None):"},{"line_number":2550,"context_line":"                                close_swift_conn(self.source)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_dc67cf4c","line":2547,"updated":"2020-08-21 01:40:27.000000000","message":"pep8: E128 continuation line under-indented for visual indent","commit_id":"bd7a6c81c35a19fe5b6d31da475ea65a9169bf86"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"6908c4e9a9ca54e94d069922a60b400d2253641a","unresolved":false,"context_lines":[{"line_number":2654,"context_line":"                    part_iter.close()"},{"line_number":2655,"context_line":""},{"line_number":2656,"context_line":"        except ChunkReadTimeout:"},{"line_number":2657,"context_line":"            self.app.exception_occurred(node[0], _(\u0027Object\u0027),"},{"line_number":2658,"context_line":"                                        _(\u0027Trying to read during GET\u0027))"},{"line_number":2659,"context_line":"            raise"},{"line_number":2660,"context_line":"        except ChunkWriteTimeout:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_3c59ab8d","line":2657,"updated":"2020-08-21 01:40:27.000000000","message":"pep8: F821 undefined name \u0027node\u0027","commit_id":"bd7a6c81c35a19fe5b6d31da475ea65a9169bf86"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"77c63479188bb37d7847bd49c4964be76cf2b086","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"                        new_source, new_node \u003d self._dig_for_source_and_node()"},{"line_number":2512,"context_line":"                        if new_source:"},{"line_number":2513,"context_line":"                            self.app.error_occurred("},{"line_number":2514,"context_line":"                                self.node, _(\u0027Trying to read object during \u0027"},{"line_number":2515,"context_line":"                                             \u0027GET (retrying)\u0027))"},{"line_number":2516,"context_line":"                            # Close-out the connection as best as possible."},{"line_number":2517,"context_line":"                            if getattr(self.source, \u0027swift_conn\u0027, None):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_43a0d3f4","line":2514,"updated":"2020-08-24 18:35:57.000000000","message":"missed opportunity to remove the i18n!","commit_id":"cbd235e5e6569e9179ec0a85b6b6473db187332e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"60436d7f0722de31d0aece7a9e6974bd32e4c62b","unresolved":false,"context_lines":[{"line_number":2511,"context_line":"                        new_source, new_node \u003d self._dig_for_source_and_node()"},{"line_number":2512,"context_line":"                        if new_source:"},{"line_number":2513,"context_line":"                            self.app.error_occurred("},{"line_number":2514,"context_line":"                                self.node, _(\u0027Trying to read object during \u0027"},{"line_number":2515,"context_line":"                                             \u0027GET (retrying)\u0027))"},{"line_number":2516,"context_line":"                            # Close-out the connection as best as possible."},{"line_number":2517,"context_line":"                            if getattr(self.source, \u0027swift_conn\u0027, None):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_dd7a52ee","line":2514,"in_reply_to":"9f560f44_43a0d3f4","updated":"2020-09-03 18:24:06.000000000","message":"Done (along with a bunch of others) in https://review.opendev.org/749810","commit_id":"cbd235e5e6569e9179ec0a85b6b6473db187332e"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"eaef68aadfff6362d37aafd72c69a1febeb3c1b7","unresolved":false,"context_lines":[{"line_number":2752,"context_line":"            return possible_source"},{"line_number":2753,"context_line":"        else:"},{"line_number":2754,"context_line":"            self.body \u003d possible_source.read()"},{"line_number":2755,"context_line":"            conn.close()"},{"line_number":2756,"context_line":""},{"line_number":2757,"context_line":"            if possible_source.status \u003d\u003d HTTP_INSUFFICIENT_STORAGE:"},{"line_number":2758,"context_line":"                self.app.error_limit(node, _(\u0027ERROR Insufficient Storage\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_6c04fe14","line":2755,"updated":"2020-09-08 19:52:23.000000000","message":"thanks for this!","commit_id":"b7b45eadcd3b948e3313ce88e34ed5a7152eaa7b"}],"test/unit/proxy/controllers/test_obj.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"77c63479188bb37d7847bd49c4964be76cf2b086","unresolved":false,"context_lines":[{"line_number":3996,"context_line":"        self.assertEqual({"},{"line_number":3997,"context_line":"            old_etag: {True},"},{"line_number":3998,"context_line":"            new_etag: {False},"},{"line_number":3999,"context_line":"            None: {False},  # 404\u0027s don\u0027t get closed"},{"line_number":4000,"context_line":"        }, closed_conn)"},{"line_number":4001,"context_line":""},{"line_number":4002,"context_line":"        self.assertEqual(resp.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_e36927be","line":3999,"updated":"2020-08-24 18:35:57.000000000","message":"so this one\u0027s still not great right?","commit_id":"cbd235e5e6569e9179ec0a85b6b6473db187332e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"60436d7f0722de31d0aece7a9e6974bd32e4c62b","unresolved":false,"context_lines":[{"line_number":3996,"context_line":"        self.assertEqual({"},{"line_number":3997,"context_line":"            old_etag: {True},"},{"line_number":3998,"context_line":"            new_etag: {False},"},{"line_number":3999,"context_line":"            None: {False},  # 404\u0027s don\u0027t get closed"},{"line_number":4000,"context_line":"        }, closed_conn)"},{"line_number":4001,"context_line":""},{"line_number":4002,"context_line":"        self.assertEqual(resp.status_int, 200)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_7d6b461e","line":3999,"in_reply_to":"9f560f44_e36927be","updated":"2020-09-03 18:24:06.000000000","message":"Fixed as part of the rebase.","commit_id":"cbd235e5e6569e9179ec0a85b6b6473db187332e"}]}
