)]}'
{"id":"openstack%2Fswift~750003","triplet_id":"openstack%2Fswift~master~I7a643ae41f41bb56dd20ca804fa478c295e4441d","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I7a643ae41f41bb56dd20ca804fa478c295e4441d","subject":"proxy: Add metrics for short requests and responses","status":"ABANDONED","created":"2020-09-04 17:44:28.000000000","updated":"2021-03-30 22:51:26.000000000","total_comment_count":6,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"40abdc32bcb95d1440aac1c7dd0b66b74583ef28","_number":750003,"virtual_id_number":750003,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-09-04 23:07:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":-1,"date":"2020-09-15 18:21:16.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-04 23:07:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-09-15 18:21:16.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"12b5b9aac79b31e1d107e4f70b6a2f48c3a7720e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-04 17:44:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"57d9ef104544df1d407d165a5dec12753bf7a0fd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 18:46:03.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c3d7a1d8f9e34c7ca06be83babc4bac2 : SUCCESS in 8m 46s\n- grenade https://zuul.opendev.org/t/openstack/build/a834473f1a69495c9123b18ec3d5ca33 : SUCCESS in 51m 48s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/bad974f754da471b808e5768d6e0f13f : SUCCESS in 46m 05s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/a91fecdc8d9f43538b3d0115a97b6ea7 : SUCCESS in 9m 10s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/553587597e254158ace5783f7b0bfcab : SUCCESS in 10m 03s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/d4881dfc08834c2fac4254e5be4699aa : FAILURE in 31m 06s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/472bb28b217f4f4a80535da1e0db7d5a : FAILURE in 14m 08s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/9c207672c73e4fd9986c161031d49ad7 : FAILURE in 14m 10s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/d6ecf7281b5e4a95b8fc45e3cfd8a334 : FAILURE in 12m 49s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/365fa3afcd5a492886e054d103b34cb4 : FAILURE in 20m 47s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/6bd485d5658e41049e665875545389e1 : FAILURE in 23m 04s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/60965a512b074e7ea726004594c992e7 : FAILURE in 21m 29s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/451d45cfb05a4b2b941c00865beccf9a : FAILURE in 27m 33s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/dad8c8f3f57e489a87cac537ce71b662 : FAILURE in 28m 21s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/06447a1e230948bab7d54dd00b801a11 : FAILURE in 27m 02s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/3f22f311468b4430be70dec5bbea9f8a : SUCCESS in 44m 30s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/4b2df05fa50843eeade816bb5ca8e943 : SUCCESS in 47m 14s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1a0797db40de4d7ba82ea8a86040ba0f : FAILURE in 32m 07s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/e92825f6e4c84074bccb2f2ad07b739d : FAILURE in 29m 12s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/42618939d9804cf3978cf0fdc79cfa44 : FAILURE in 12m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/80ee48f0d38e46d3a632baa7da2c95f7 : SUCCESS in 6m 35s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/76a86d22b17e46df8758cf8c80c036da : FAILURE in 8m 04s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/7bfacba2a42c41a08a237177b3dfd684 : SUCCESS in 55m 38s","accounts_in_message":[],"_revision_number":1},{"id":"247f5ecff5601caf083f93223bae1f6e338a88c9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2020-09-04 21:57:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"33659ff4144a7c1a77082bb155cb658e97391f8c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-04 23:07:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c19c67bfb774688a0acb7bec5173dfd : SUCCESS in 10m 06s\n- grenade https://zuul.opendev.org/t/openstack/build/3df9f26493dc4eca8a429251b4266a3d : SUCCESS in 58m 11s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/8ebf40a2fb024383a9f3500edd0ffcc4 : SUCCESS in 41m 32s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/24d3a9a5a2d84abf8f5074cc58fc8ba0 : SUCCESS in 10m 13s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/41683d3cd4524a5c97ccb59bd9c8fd9e : SUCCESS in 9m 33s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/626727ba4ee14ff1826fe6a56f7a6871 : SUCCESS in 19m 09s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/9631cbed38554a629aaf240346f4641f : SUCCESS in 18m 03s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/3cd1b786d5394f4bbeee554c2f2a891a : SUCCESS in 19m 16s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/afe5905cf3ed4743a7b38e4f87267806 : SUCCESS in 24m 15s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/8a6c36210c8240afa9a1df3f537cf8b6 : SUCCESS in 22m 29s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/1d76e1f49d8640bcaca1fd784b25760b : SUCCESS in 22m 13s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/dfffebf4ea8a42adb41d574d025f26c8 : SUCCESS in 23m 55s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/7572af7c2024440aba8f90cdfa5f8938 : SUCCESS in 30m 14s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/7308488008844c3a87db035c740a4ded : SUCCESS in 23m 27s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/d6c4c41374fd4ba588d814c10b6e5cbe : SUCCESS in 18m 13s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f30009d90bd945b5923c0f183b56791f : SUCCESS in 45m 30s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/79878cde1344409da9e267b4a16d7e18 : SUCCESS in 1h 05m 03s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/fa862d5f939b4adab49e53d846c2deb8 : SUCCESS in 39m 25s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/bf103cf46fd64f14a0bcf7ade3c6311d : SUCCESS in 42m 26s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/bfd1546a4d764134a6ae57638c33ba68 : SUCCESS in 26m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/992085a39a874f72987f65e02158175c : SUCCESS in 9m 18s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/97332ae2a8b24ce1be483641561f4805 : FAILURE in 7m 51s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9b8e5d68dea543c3a3fdbbc9c5118d50 : SUCCESS in 1h 08m 24s","accounts_in_message":[],"_revision_number":2},{"id":"b811729e39237cc698db41153480216de80d7559","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-09-15 18:21:16.000000000","message":"Patch Set 2: Code-Review-1\n\n(6 comments)\n\nit seems like this is *maybe* related to lp bug #1895691 (which returns not enough bytes, but logs 2XX)\n\nExcept this doesn\u0027t try to fix the status codes, it just (maybe?) emits a new metric?\n\nLooking at tests like unit.common.middleware.test_proxy_logging:TestProxyLogging.test_unread_body it\u0027s not clear to me AT ALL how we manage to get the metric for short reads to pop since it\u0027ll already be 499\n\nPlease add detail to the commit message to better demonstrate motivation for this change.\nPlease add unittests to demonstrate how these metrics are supposed to work.","accounts_in_message":[],"_revision_number":2},{"id":"1a16ac35790c76ce4b824271de7e0b8877441b2e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2020-09-18 23:07:29.000000000","message":"Patch Set 2:\n\nI found we\u0027re already (ineffectively?) counting bytes here:\n\nhttps://github.com/openstack/swift/blob/master/swift/common/middleware/catch_errors.py#L27\n\nand at least with *LO here:\n\nhttps://github.com/openstack/swift/blob/master/swift/common/request_helpers.py#L622","accounts_in_message":[],"_revision_number":2},{"id":"40abdc32bcb95d1440aac1c7dd0b66b74583ef28","tag":"autogenerated:gerrit:abandon","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-30 22:51:26.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"663bcc04f7df3e851d086a471854fab34ef294a9","revisions":{"be8f400a83993446264e6ecf3b86e1417e9070ed":{"kind":"REWORK","_number":1,"created":"2020-09-04 17:44:28.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/03/750003/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/03/750003/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/03/750003/1"}}},"commit":{"parents":[{"commit":"7015ac2fdc34bbb46b6be6084fe6a5bd41acc74c","subject":"Merge \"py3: Work with proper native string paths in crypto meta\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7015ac2fdc34bbb46b6be6084fe6a5bd41acc74c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-04 17:32:27.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-04 17:42:29.000000000","tz":-420},"subject":"proxy: Add metrics for short requests and responses","message":"proxy: Add metrics for short requests and responses\n\nChange-Id: I7a643ae41f41bb56dd20ca804fa478c295e4441d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/be8f400a83993446264e6ecf3b86e1417e9070ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/be8f400a83993446264e6ecf3b86e1417e9070ed"}]},"branch":"refs/heads/master"},"663bcc04f7df3e851d086a471854fab34ef294a9":{"kind":"REWORK","_number":2,"created":"2020-09-04 21:57:49.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/03/750003/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/03/750003/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/03/750003/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/03/750003/2"}}},"commit":{"parents":[{"commit":"7015ac2fdc34bbb46b6be6084fe6a5bd41acc74c","subject":"Merge \"py3: Work with proper native string paths in crypto meta\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7015ac2fdc34bbb46b6be6084fe6a5bd41acc74c"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-04 17:32:27.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2020-09-04 21:57:31.000000000","tz":-420},"subject":"proxy: Add metrics for short requests and responses","message":"proxy: Add metrics for short requests and responses\n\nChange-Id: I7a643ae41f41bb56dd20ca804fa478c295e4441d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/663bcc04f7df3e851d086a471854fab34ef294a9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/663bcc04f7df3e851d086a471854fab34ef294a9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}