)]}'
{"swift/obj/updater.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a3579ccb4ace1ee3cefafbfd45fd665829410171","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":194,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"},{"line_number":195,"context_line":"        headers_out \u003d update[\u0027headers\u0027].copy()"},{"line_number":196,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027obj-updater %s\u0027 % os.getpid()"},{"line_number":197,"context_line":"        events \u003d [spawn(self.object_update,"},{"line_number":198,"context_line":"                        node, part, update[\u0027op\u0027], obj, headers_out)"},{"line_number":199,"context_line":"                  for node in nodes if node[\u0027id\u0027] not in successes]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_a84adcc2","line":196,"updated":"2014-07-02 23:37:03.000000000","message":"There is a change in flight that is changing the user-agents of obj_* servers to their full name: \n\n   headers_out[\u0027user-agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()\n\nThe other has its +2\u0027s and is awaiting a +A, so you might want to change this in your change so a second patch doesn\u0027t have to be raised :)","commit_id":"a08e813a92626b3ac5fb14b1ec3882f3a3fc5fa5"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"4b144067187e43e5dd3c50b27331377f6d49a18d","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        obj \u003d \u0027/%s/%s/%s\u0027 % \\"},{"line_number":194,"context_line":"              (update[\u0027account\u0027], update[\u0027container\u0027], update[\u0027obj\u0027])"},{"line_number":195,"context_line":"        headers_out \u003d update[\u0027headers\u0027].copy()"},{"line_number":196,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027obj-updater %s\u0027 % os.getpid()"},{"line_number":197,"context_line":"        events \u003d [spawn(self.object_update,"},{"line_number":198,"context_line":"                        node, part, update[\u0027op\u0027], obj, headers_out)"},{"line_number":199,"context_line":"                  for node in nodes if node[\u0027id\u0027] not in successes]"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_0e37514f","line":196,"in_reply_to":"baada198_a84adcc2","updated":"2014-07-03 00:01:54.000000000","message":"Scape this comment, there has been more discussions on the change I mentioned above (102401). A change to logging may not take place.\n\nSo all good :)","commit_id":"a08e813a92626b3ac5fb14b1ec3882f3a3fc5fa5"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b74906d53fd696f13306bd6d488e92a331ec5e1f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        headers_out \u003d update[\u0027headers\u0027].copy()"},{"line_number":220,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()"},{"line_number":221,"context_line":"        headers_out.setdefault(\u0027X-Backend-Storage-Policy-Index\u0027,"},{"line_number":222,"context_line":"                           str(policy_idx))"},{"line_number":223,"context_line":"        events \u003d [spawn(self.object_update,"},{"line_number":224,"context_line":"                        node, part, update[\u0027op\u0027], obj, headers_out)"},{"line_number":225,"context_line":"                  for node in nodes if node[\u0027id\u0027] not in successes]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_52323410","line":222,"updated":"2014-07-29 07:28:35.000000000","message":"The str(policy_idx) line is under indented, line it up the the open bracket in the \u0027setdefault\u0027  in the line above to fix the pep8 issue. Eg:\n\n          headers_out.setdefault(\u0027X-Backend-Storage-Policy-Index\u0027,\n                                 str(policy_idx))","commit_id":"5723a5747ad1e01d4749761dcbd42415d105ba0b"},{"author":{"_account_id":7479,"name":"paul luse","email":"paul.e.luse@intel.com","username":"peluse"},"change_message_id":"8d407df1d16656b0b1e13c647509237c0c5c5d74","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        headers_out[\u0027user-agent\u0027] \u003d \u0027object-updater %s\u0027 % os.getpid()"},{"line_number":221,"context_line":"        headers_out.setdefault(\u0027X-Backend-Storage-Policy-Index\u0027,"},{"line_number":222,"context_line":"                               str(policy_idx))"},{"line_number":223,"context_line":"        events \u003d [spawn(self.object_update,"},{"line_number":224,"context_line":"                        node, part, update[\u0027op\u0027], obj, headers_out)"},{"line_number":225,"context_line":"                  for node in nodes if node[\u0027id\u0027] not in successes]"},{"line_number":226,"context_line":"        success \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_3aaeb598","line":223,"updated":"2014-08-22 01:37:43.000000000","message":"is there any way we can not get any events out of this (problem spawning) such that we log a success below (success is default set to True) even though nothing was sent?  Doesn\u0027t seem like a big deal but should success should be set to True only if events is not None?","commit_id":"196a73192f698f0151b85e4135bac19b47e52da2"}]}