)]}'
{"etc/memcache.conf-sample":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"89619c3583abbc6ee2331d5f610516e87ab332ff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# minimum number of servers to keep available when error limiting would otherwise"},{"line_number":30,"context_line":"# make servers unavailable; the configured value should be no less than zero"},{"line_number":31,"context_line":"# and no greater than the number of servers, and will be adjusted accordingly"},{"line_number":32,"context_line":"memcache_minimum_servers \u003d 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f65232a_cde30333","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":28},"updated":"2020-10-23 18:45:18.000000000","message":"Default is actually zero, though, yeah?","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"90f7a00ecaa8546edfe23039b03e4250cd26e403","unresolved":false,"context_lines":[{"line_number":29,"context_line":"# minimum number of servers to keep available when error limiting would otherwise"},{"line_number":30,"context_line":"# make servers unavailable; the configured value should be no less than zero"},{"line_number":31,"context_line":"# and no greater than the number of servers, and will be adjusted accordingly"},{"line_number":32,"context_line":"memcache_minimum_servers \u003d 1"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f65232a_80c54591","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":28},"in_reply_to":"3f65232a_cde30333","updated":"2020-10-26 12:30:43.000000000","message":"will fix. (I wrote the patch to suit the existing default of 1 then updated to default to zero, just missed this change)","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"}],"swift/common/memcached.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"89619c3583abbc6ee2331d5f610516e87ab332ff","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            self._return_conn(server, None, None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if len(self._errors) \u003d\u003d self._minimum_servers:"},{"line_number":219,"context_line":"            # if there\u0027s only one server defined, skip the error-limiting"},{"line_number":220,"context_line":"            # book-keeping entirely"},{"line_number":221,"context_line":"            return"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_8dd90b85","line":219,"range":{"start_line":219,"start_character":25,"end_line":219,"end_character":40},"updated":"2020-10-23 18:45:18.000000000","message":"nit: Comment could use some updating.","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"90f7a00ecaa8546edfe23039b03e4250cd26e403","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            self._return_conn(server, None, None)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        if len(self._errors) \u003d\u003d self._minimum_servers:"},{"line_number":219,"context_line":"            # if there\u0027s only one server defined, skip the error-limiting"},{"line_number":220,"context_line":"            # book-keeping entirely"},{"line_number":221,"context_line":"            return"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_a0bcc105","line":219,"range":{"start_line":219,"start_character":25,"end_line":219,"end_character":40},"in_reply_to":"3f65232a_8dd90b85","updated":"2020-10-26 12:30:43.000000000","message":"Done","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"}],"test/unit/common/test_memcached.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"957e8880980423407619edd311b74005480c98e2","unresolved":false,"context_lines":[{"line_number":561,"context_line":"                    [\u00271.2.3.4:11211\u0027], logger\u003dself.logger,"},{"line_number":562,"context_line":"                    minimum_servers\u003drequested_min_servers)"},{"line_number":563,"context_line":"            mock1 \u003d ExplodingMockMemcached()"},{"line_number":564,"context_line":"            memcache_client._client_cache[\u00271.2.3.4:11211\u0027] \u003d MockedMemcachePool("},{"line_number":565,"context_line":"                [(mock1, mock1)] * 3)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"            with mock.patch.object(memcached, \u0027ERROR_LIMIT_COUNT\u0027, 3):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_107b4e8c","line":564,"updated":"2020-10-23 19:52:04.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"957e8880980423407619edd311b74005480c98e2","unresolved":false,"context_lines":[{"line_number":585,"context_line":"                [\u00271.2.3.4:11211\u0027], logger\u003dself.logger,"},{"line_number":586,"context_line":"                minimum_servers\u003drequested_min_servers)"},{"line_number":587,"context_line":"            mock1 \u003d ExplodingMockMemcached()"},{"line_number":588,"context_line":"            memcache_client._client_cache[\u00271.2.3.4:11211\u0027] \u003d MockedMemcachePool("},{"line_number":589,"context_line":"                [(mock1, mock1)] * 5)"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"            with mock.patch.object(memcached, \u0027ERROR_LIMIT_COUNT\u0027, 3):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f65232a_7070c2a6","line":588,"updated":"2020-10-23 19:52:04.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"686fde31b9e779c8f8a0e2ad232725a0317060b4"}]}