)]}'
{"id":"openstack%2Fswift~763788","triplet_id":"openstack%2Fswift~master~I1ab8761083ab76657f3690e9a77367e58af430c9","project":"openstack/swift","branch":"master","topic":"p-ssync-remote-check-objects","hashtags":[],"change_id":"I1ab8761083ab76657f3690e9a77367e58af430c9","subject":"ssync: Fix traceback when no updates are sent","status":"NEW","created":"2020-11-23 14:37:00.000000000","updated":"2020-11-23 17:33:50.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a71615ca7fdd9a799d6a4653bd178751885ff40e","_number":763788,"virtual_id_number":763788,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-11-23 17:33:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-11-23 17:33:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"22e18506588091dbeca8e98feeb938b1c7d65544","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2020-11-23 14:37:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a71615ca7fdd9a799d6a4653bd178751885ff40e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-11-23 17:33:50.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c6c30cfe481f4982b5645fc9ee3d2e9e : SUCCESS in 8m 03s\n- grenade https://zuul.opendev.org/t/openstack/build/83a0b68a345c41edae407282fa193308 : SUCCESS in 53m 53s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/adf54205610d47609ddb1948fc0c5a8b : FAILURE in 42m 58s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b59f14953f3540f7bf6a1a778c10a7f3 : SUCCESS in 8m 28s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/7e8d536c62ac4faa887527118d996f91 : SUCCESS in 8m 40s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/fca1ec7dac7a4165b82f12dfa577b384 : SUCCESS in 13m 32s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/ac053d4fe32b4ec7815c533e552355d1 : SUCCESS in 13m 20s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/438cb9435d8647d79968c75b416152c0 : SUCCESS in 12m 44s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/2a6ea2d03bee42fe882ca5f5b2beaca2 : SUCCESS in 14m 08s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/edc2f07c5155418a9d47100493a2f02b : SUCCESS in 16m 05s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/85a98454e4bb41f685c3a1cc81a42b79 : SUCCESS in 15m 59s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/a094fca17b6e450daddce3a1e21fbde1 : SUCCESS in 18m 34s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/9b69647439384143afc3511910477370 : SUCCESS in 16m 36s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/cde2cbcb4efd4e6db612ec2e15482771 : SUCCESS in 20m 37s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/68e33964b09747a3b70b7ea4e8f09491 : SUCCESS in 20m 52s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/dd44634b74804f7aa8e1efbf979afb65 : FAILURE in 35m 31s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/239a06cb5d9e4f688e57924ab7731e45 : FAILURE in 35m 46s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/07c641cb4bd54f97ba518f8def6f0bf0 : SUCCESS in 47m 58s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/95f4567928e34b65808c62f740012b39 : SUCCESS in 32m 47s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2be9aac3691e48979ef51c078eeefe01 : SUCCESS in 13m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0b8fc172a05444e9bbb28b89130e1955 : FAILURE in 5m 15s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/17c611e6e43b471eb7c011a86ea536d7 : SUCCESS in 26m 10s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b50b971031ca4b69acbdd73c5a2bbb9d : SUCCESS in 1h 18m 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7f59705904bcf77a4d80ddbd20c00fa294bf372b","revisions":{"7f59705904bcf77a4d80ddbd20c00fa294bf372b":{"kind":"REWORK","_number":1,"created":"2020-11-23 14:37:00.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/88/763788/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/88/763788/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/763788/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/763788/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/88/763788/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/88/763788/1"}}},"commit":{"parents":[{"commit":"e22cad666a7bbb16a40a85a162a829da0f23c187","subject":"Merge \"xlo: 5xx while validating first segment is a server error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e22cad666a7bbb16a40a85a162a829da0f23c187"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2020-11-20 16:35:34.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2020-11-20 17:01:52.000000000","tz":0},"subject":"ssync: Fix traceback when no updates are sent","message":"ssync: Fix traceback when no updates are sent\n\nWhen an ssync sender detects that all hashes are in sync and there are\nno updates to perform, it sends the \u0027:UPDATES: START\u0027 and \u0027UPDATES:\nEND\u0027 handshake tokens to the receiver with no hash data between\nthem. However, when an ssync sender has remote_check_objs it performs\nthe missing check phase of the ssync protocol but does not perform the\nupdates phase, regardless of the sync status. Previously, in this\ncase, the sender would not even send the \u0027:UPDATES: START\u0027 and\n\u0027UPDATES: END\u0027 handshake tokens, and the receiver would receive an\nempty line after the \u0027:MISSING: END\u0027 token. This would cause the\nreceiver to log an exception because it was expecting \u0027UPDATES:\nSTART\u0027.\n\nThis patch changes the ssync sender to always send the updates\nhandshake tokens even when there are no updates due to\nremote_check_objs being set. The receiver should therefore always\nreceive the handshake token that it expects.\n\nChange-Id: I1ab8761083ab76657f3690e9a77367e58af430c9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7f59705904bcf77a4d80ddbd20c00fa294bf372b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/7f59705904bcf77a4d80ddbd20c00fa294bf372b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}