)]}'
{"swift/common/units.py":[{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"2c6a532d09aa40bc3b717fad5882cbbcfde3c24e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Yi \u003d 1024 ** 8"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#Decimal unit constants."},{"line_number":32,"context_line":"k \u003d 1000"},{"line_number":33,"context_line":"M \u003d 1000 ** 2"},{"line_number":34,"context_line":"G \u003d 1000 ** 3"},{"line_number":35,"context_line":"T \u003d 1000 ** 4"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F0hE%3D","line":32,"updated":"2014-02-28 02:50:13.000000000","message":"K \u003d 1000?","commit_id":"72c172291bc8649fcf5e3b983b13fd5a297474e6"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"43fdd26715fa5b3594d4102c7917254551f081c0","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Yi \u003d 1024 ** 8"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"#Decimal unit constants."},{"line_number":32,"context_line":"k \u003d 1000"},{"line_number":33,"context_line":"M \u003d 1000 ** 2"},{"line_number":34,"context_line":"G \u003d 1000 ** 3"},{"line_number":35,"context_line":"T \u003d 1000 ** 4"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F0SU%3D","line":32,"in_reply_to":"AAAAVX%2F%2F0hE%3D","updated":"2014-02-28 03:40:13.000000000","message":"Hi , I did this  on purpose. Please see http://en.wikipedia.org/wiki/Byte#Unit_symbol","commit_id":"72c172291bc8649fcf5e3b983b13fd5a297474e6"}],"swift/obj/diskfile.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"feb2322651948f178c329b6b8f97993197a7b29a","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                    if self._iter_etag:"},{"line_number":820,"context_line":"                        self._iter_etag.update(chunk)"},{"line_number":821,"context_line":"                    self._bytes_read +\u003d len(chunk)"},{"line_number":822,"context_line":"                    if self._bytes_read - dropped_cache \u003e units.Mi:"},{"line_number":823,"context_line":"                        self._drop_cache(self._fp.fileno(), dropped_cache,"},{"line_number":824,"context_line":"                                         self._bytes_read - dropped_cache)"},{"line_number":825,"context_line":"                        dropped_cache \u003d self._bytes_read"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_aa3b3d9a","line":822,"updated":"2014-06-20 10:45:27.000000000","message":"elsewhere you have used 1 * units.Mi. Consistency would be good.","commit_id":"b67c62e5e68fd9fe72b273156b3a63880192860c"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"236ff2fc568967cec31999b3ebc69f79c4b571fd","unresolved":false,"context_lines":[{"line_number":819,"context_line":"                    if self._iter_etag:"},{"line_number":820,"context_line":"                        self._iter_etag.update(chunk)"},{"line_number":821,"context_line":"                    self._bytes_read +\u003d len(chunk)"},{"line_number":822,"context_line":"                    if self._bytes_read - dropped_cache \u003e units.Mi:"},{"line_number":823,"context_line":"                        self._drop_cache(self._fp.fileno(), dropped_cache,"},{"line_number":824,"context_line":"                                         self._bytes_read - dropped_cache)"},{"line_number":825,"context_line":"                        dropped_cache \u003d self._bytes_read"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_35a2173f","line":822,"in_reply_to":"1ae5cdf2_aa3b3d9a","updated":"2014-06-21 04:25:53.000000000","message":"yes, will update the case in next patchset.","commit_id":"b67c62e5e68fd9fe72b273156b3a63880192860c"}],"test/unit/common/test_units.py":[{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"8dd8a412baa464d230e02764d29c90184945c9bf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.common import test"},{"line_number":18,"context_line":"from openstack.common import units"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fe5g%3D","line":17,"updated":"2014-02-26 11:20:07.000000000","message":"This adds a new dependency, Swift uses unittest so far and this could be used here as well","commit_id":"bb209b66808a98d3b7f4b4eb79b651c4ff8f8937"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"50bb73a82af12c9072612f4c6234a971a3395736","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.common import test"},{"line_number":18,"context_line":"from openstack.common import units"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fezs%3D","line":17,"in_reply_to":"AAAAU3%2F%2Fe5g%3D","updated":"2014-02-26 11:33:49.000000000","message":"Done","commit_id":"bb209b66808a98d3b7f4b4eb79b651c4ff8f8937"},{"author":{"_account_id":6968,"name":"Christian Schwede","email":"cschwede@nvidia.com","username":"cschwede"},"change_message_id":"8dd8a412baa464d230e02764d29c90184945c9bf","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.common import test"},{"line_number":18,"context_line":"from openstack.common import units"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class UnitTest(test.BaseTestCase):"},{"line_number":22,"context_line":"    def test_binary_unit(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fe5k%3D","line":19,"updated":"2014-02-26 11:20:07.000000000","message":"This should import from swift.common, otherwise that new file is untested.","commit_id":"bb209b66808a98d3b7f4b4eb79b651c4ff8f8937"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"50bb73a82af12c9072612f4c6234a971a3395736","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from openstack.common import test"},{"line_number":18,"context_line":"from openstack.common import units"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class UnitTest(test.BaseTestCase):"},{"line_number":22,"context_line":"    def test_binary_unit(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAU3%2F%2Fezo%3D","line":19,"in_reply_to":"AAAAU3%2F%2Fe5k%3D","updated":"2014-02-26 11:33:49.000000000","message":"Done","commit_id":"bb209b66808a98d3b7f4b4eb79b651c4ff8f8937"},{"author":{"_account_id":2649,"name":"Zhang Hua","email":"zhuadl@cn.ibm.com","username":"zhang-hare"},"change_message_id":"d593739f795c730d052053d414adcbb4c297ea82","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.assertEqual(units.Yi, 1024 ** 8)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_decimal_unit(self):"},{"line_number":34,"context_line":"        self.assertEqual(units.k, 1000)"},{"line_number":35,"context_line":"        self.assertEqual(units.M, 1000 ** 2)"},{"line_number":36,"context_line":"        self.assertEqual(units.G, 1000 ** 3)"},{"line_number":37,"context_line":"        self.assertEqual(units.T, 1000 ** 4)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAVX%2F%2F0gg%3D","line":34,"updated":"2014-02-28 02:50:52.000000000","message":"self.assertEqual(units.K, 1000)","commit_id":"72c172291bc8649fcf5e3b983b13fd5a297474e6"}]}
