)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"5654b534af33da0ec22bc94bdb58911d5005e400","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This is probably overkill, but does guard against unforeseen"},{"line_number":12,"context_line":"side-effects if the daemon run_* methods were ever called more than"},{"line_number":13,"context_line":"once with different kwargs."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Iad6a3bcc99a26550048346dffec9aee432828f3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"73e42530_bf45b862","line":13,"updated":"2021-07-22 18:16:24.000000000","message":"so like... mainly for tests then?","commit_id":"9f9360833cd3d84cb9f483ce1a2ddc42c33a0b7f"}],"swift/container/sharder.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"3c96b11d14a8b8384a423f18b042e305a6be2d0d","unresolved":true,"context_lines":[{"line_number":1718,"context_line":"        conf_auto_shard \u003d self.auto_shard"},{"line_number":1719,"context_line":"        auto_shard \u003d kwargs.get(\u0027auto_shard\u0027, None)"},{"line_number":1720,"context_line":"        if auto_shard is not None:"},{"line_number":1721,"context_line":"            self.auto_shard \u003d config_true_value(auto_shard)"},{"line_number":1722,"context_line":"        try:"},{"line_number":1723,"context_line":"            yield"},{"line_number":1724,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":1,"id":"53390eb8_30cbb515","line":1721,"updated":"2020-12-18 16:53:03.000000000","message":"the only thing bugging me is this never being true in any practical scenario - and I could vuagly imagine intead of `swift-manage-shard-ranges` being called on an individual db an operator might someday want to run `sharder once --auto-shard\u003dtrue` in the foreground on just one node as a form a leader election","commit_id":"9f9360833cd3d84cb9f483ce1a2ddc42c33a0b7f"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"20979af5d083fcbac7c4ea48383ff3eaecb24af4","unresolved":true,"context_lines":[{"line_number":1719,"context_line":"        auto_shard \u003d kwargs.get(\u0027auto_shard\u0027, None)"},{"line_number":1720,"context_line":"        if auto_shard is not None:"},{"line_number":1721,"context_line":"            self.auto_shard \u003d config_true_value(auto_shard)"},{"line_number":1722,"context_line":"        try:"},{"line_number":1723,"context_line":"            yield"},{"line_number":1724,"context_line":"        finally:"},{"line_number":1725,"context_line":"            self.auto_shard \u003d conf_auto_shard"}],"source_content_type":"text/x-python","patch_set":1,"id":"f563add6_491f6003","line":1722,"updated":"2021-07-16 21:40:23.000000000","message":"I\u0027ve got this tic that makes me want the update to self.auto_shard to be inside this try, but I\u0027m probably being overly cautious -- we\u0027re not actually worried about some exception getting raised between that update and getting into the try.","commit_id":"9f9360833cd3d84cb9f483ce1a2ddc42c33a0b7f"}]}