)]}'
{"test/unit/proxy/controllers/test_container.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"50f88617419cdbb64e011ccb696814421545d69d","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"             dict(marker\u003d\u0027b\u0027, end_marker\u003d\u0027\u0027, states\u003d\u0027listing\u0027,"},{"line_number":1086,"context_line":"                  limit\u003dstr("},{"line_number":1087,"context_line":"                      limit - len(sr_objs[0]) - len(sr_objs[1])))),  # 200"},{"line_number":1088,"context_line":"            (\u0027.shards_a/c_b\u0027, {\u0027X-Backend-Record-Type\u0027: \u0027object\u0027},"},{"line_number":1089,"context_line":"             dict(marker\u003d\u0027b\u0027, end_marker\u003d\u0027b\\x00\u0027, states\u003d\u0027listing\u0027,"},{"line_number":1090,"context_line":"                  limit\u003dstr("},{"line_number":1091,"context_line":"                      limit - len(sr_objs[0]) - len(sr_objs[1])))),  # 200"}],"source_content_type":"text/x-python","patch_set":1,"id":"e72fa84e_635c5a73","line":1088,"updated":"2021-01-05 21:38:03.000000000","message":"here we\u0027re making a request back to c_b (which makes sense sense c_ told us to; N.B. i\u0027m not sure it \"makes sense\" that c_ *would* do that; but this test is assuming it does and testing how we\u0027d deal with that)\n\n... in general with this new code I expect anytime we\u0027re talking to a container we\u0027re already talked to we\u0027d set record-type to object\n\nI\u0027m obviously missing something","commit_id":"71b653ddb821b5ca5c78b764a9c8a1d2c8fc21e2"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"6940b3b98571e94aecdd13c6df83f5889fac63ef","unresolved":true,"context_lines":[{"line_number":1085,"context_line":"             dict(marker\u003d\u0027b\u0027, end_marker\u003d\u0027\u0027, states\u003d\u0027listing\u0027,"},{"line_number":1086,"context_line":"                  limit\u003dstr("},{"line_number":1087,"context_line":"                      limit - len(sr_objs[0]) - len(sr_objs[1])))),  # 200"},{"line_number":1088,"context_line":"            (\u0027.shards_a/c_b\u0027, {\u0027X-Backend-Record-Type\u0027: \u0027object\u0027},"},{"line_number":1089,"context_line":"             dict(marker\u003d\u0027b\u0027, end_marker\u003d\u0027b\\x00\u0027, states\u003d\u0027listing\u0027,"},{"line_number":1090,"context_line":"                  limit\u003dstr("},{"line_number":1091,"context_line":"                      limit - len(sr_objs[0]) - len(sr_objs[1])))),  # 200"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed1f445e_3eb2a9b8","line":1088,"in_reply_to":"e72fa84e_635c5a73","updated":"2021-01-06 14:14:39.000000000","message":"With the new code, anytime we go to a container *that has previously returned shards* we set record type to object. In this test c_b returned objects, so wasn\u0027t added to the req.environ listing history, but that\u0027s OK because it will either return objects again (but no dups because of the marker/end_marker) or it may return shards if its state changed, in which case it\u0027ll then go into the history.\n\nI\u0027ll play with this patch to test the latter.","commit_id":"71b653ddb821b5ca5c78b764a9c8a1d2c8fc21e2"}]}