)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"3400e9510842326929e0a0f5fa6d8580d633f4bc","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use the logger we instantiated in more places."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Pass the logger to audit_location_generator so we actually see messages about failed mount checks."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Idda6512c0a2bc324bdba9ec341ec81d78b7b2f67"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"73058f61_7dda1a8a","line":11,"updated":"2021-01-07 01:48:38.000000000","message":"I should probably have at least included a\n\n Related-Bug: #1910470\n\nThis doesn\u0027t fully address it though, I think. Logging\u0027s better, but we don\u0027t exit 2 :-/","commit_id":"ff86476b6bb62ca17fd867c6070d9eca4cae43e2"}],"swift/cli/relinker.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"dc672a5c7ad88263f7c54545d29d919744d2354c","unresolved":true,"context_lines":[{"line_number":186,"context_line":"            partitions_filter\u003drelink_partition_filter,"},{"line_number":187,"context_line":"            hook_post_partition\u003drelink_hook_post_partition,"},{"line_number":188,"context_line":"            hashes_filter\u003drelink_hashes_filter,"},{"line_number":189,"context_line":"            logger\u003dlogger)"},{"line_number":190,"context_line":"        for fname, _, _ in locations:"},{"line_number":191,"context_line":"            newfname \u003d replace_partition_in_path(fname, next_part_power)"},{"line_number":192,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"21a11f7a_090f4e7a","line":189,"updated":"2021-01-27 21:45:35.000000000","message":"THIS\nAlthough I\u0027d place it after mount_check, just make it easier to find when reading, but no matter.","commit_id":"28df9a096bf67daa65459569ed1c9398d4789fd4"}],"swift/common/utils.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"09d35d1ac3dce501fdc85393d9bb4c0526f01b9b","unresolved":true,"context_lines":[{"line_number":3259,"context_line":"                    _(\u0027Skipping %s as it is not mounted\u0027), device)"},{"line_number":3260,"context_line":"            continue"},{"line_number":3261,"context_line":"        if hook_pre_device:"},{"line_number":3262,"context_line":"            hook_pre_device(os.path.join(devices, device))"},{"line_number":3263,"context_line":"        datadir_path \u003d os.path.join(devices, device, datadir)"},{"line_number":3264,"context_line":"        try:"},{"line_number":3265,"context_line":"            partitions \u003d listdir(datadir_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5e551286_63bf0458","line":3262,"updated":"2021-01-13 22:14:55.000000000","message":"I\u0027m torn about this move -- as long as permissions are correct, the EPERM error from https://bugs.launchpad.net/swift/+bug/1910470 seems like it may be preferable ...","commit_id":"28df9a096bf67daa65459569ed1c9398d4789fd4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"dc672a5c7ad88263f7c54545d29d919744d2354c","unresolved":true,"context_lines":[{"line_number":3259,"context_line":"                    _(\u0027Skipping %s as it is not mounted\u0027), device)"},{"line_number":3260,"context_line":"            continue"},{"line_number":3261,"context_line":"        if hook_pre_device:"},{"line_number":3262,"context_line":"            hook_pre_device(os.path.join(devices, device))"},{"line_number":3263,"context_line":"        datadir_path \u003d os.path.join(devices, device, datadir)"},{"line_number":3264,"context_line":"        try:"},{"line_number":3265,"context_line":"            partitions \u003d listdir(datadir_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a7c1ce23_24a51179","line":3262,"in_reply_to":"5e551286_63bf0458","updated":"2021-01-27 21:45:35.000000000","message":"I think this is okay, because nothing but relinker uses that hook, so you\u0027re not pulling the rag from under anyone.","commit_id":"28df9a096bf67daa65459569ed1c9398d4789fd4"}]}
