)]}'
{"id":"openstack%2Fswift~769993","triplet_id":"openstack%2Fswift~master~I473664042215ce4ab92617cd71056451a00b64a3","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I473664042215ce4ab92617cd71056451a00b64a3","subject":"obj: Include devices in per-worker logger prefixes","status":"NEW","created":"2021-01-08 21:23:09.000000000","updated":"2021-01-11 18:16:16.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":1,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"bf7f844a0cd29539114ba6e8c67d057f62a46bd7","_number":769993,"virtual_id_number":769993,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-01-09 04:15:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"all":[{"value":-1,"date":"2021-01-09 22:01:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-01-11 18:16:16.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-09 00:26:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-09 22:01:14.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"}],"messages":[{"id":"d2a85706d1b3b1abeb2923b8769e29d44c24227e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-01-08 21:23:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0803e108810163d6fe572c95570025c5c486c1f0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-09 00:26:27.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c3fafc09e7854c0683e0b6cd5c02b528 : SUCCESS in 7m 27s\n- grenade https://zuul.opendev.org/t/openstack/build/d14d053cbac64edaba9679071f59e3a2 : SUCCESS in 1h 10m 00s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/33e0e887e24b4ae3abd61c515efa122e : SUCCESS in 49m 18s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b0cb1c6fe45543be9e1f9f454b49a2e6 : SUCCESS in 8m 42s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/31a5eb44f5954b25854552ae7dbd5e09 : SUCCESS in 9m 05s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/dd0a3750968040c99a0d676eace4de39 : SUCCESS in 13m 27s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/5b4f901ce74b44beb94c03da51b6178c : SUCCESS in 13m 33s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/b4d37921838a451b80216128bea4b7a1 : SUCCESS in 13m 35s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/f86fd8350d114eefb1030a2d8f05dcfe : SUCCESS in 15m 05s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/a30b6a5106db4e6593921a9f8c604ff5 : SUCCESS in 17m 38s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/b3bf6e30506c48fab758ba37f916a9b1 : SUCCESS in 17m 13s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/15e0fe0f998941c2959b266d15d98c51 : FAILURE in 19m 08s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/22540e2453b249ff97845319ae2901c2 : SUCCESS in 17m 31s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/544ac48b336146bc8c57678a019df789 : SUCCESS in 18m 02s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/91dbd40160844f96b9b367ce6d7e3a7a : SUCCESS in 17m 15s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/888032038c0841b5b24e8dca3f420941 : SUCCESS in 25m 55s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a38f719be9a34052b953947f7b9968f9 : SUCCESS in 52m 08s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/61ed135a91694245a6612e1cdc9a3f2f : SUCCESS in 46m 20s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0e6d69fa0fce4db78826333236482a5e : SUCCESS in 35m 41s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/ed7e50d3df274b55ad2d4e521c49d70b : SUCCESS in 39m 18s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e401a06e7d9b433daccc27bd5cfb085b : SUCCESS in 12m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f7fd3568478e4ce88f4e6e4455b6d0fa : SUCCESS in 5m 28s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/aa6cdfd43e6745d480437ad1310bf23d : FAILURE in 8m 17s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/cdadf61bcfa240dea482ce2a81d80e4b : SUCCESS in 56m 34s","accounts_in_message":[],"_revision_number":1},{"id":"f1bc47639312dd48ccc95c29e137cf7fd944ab84","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-01-09 03:10:33.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"82d3e5cc34a043d93466e1ed8b5d620e148a444f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-09 04:15:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bbd64a0d996f4d2c9da4c7bc57b2a135 : SUCCESS in 8m 46s\n- grenade https://zuul.opendev.org/t/openstack/build/d8ff0a1fc60e4b3381ee6f7a22e2cde7 : SUCCESS in 1h 00m 10s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/eeef57fe11c243b2b9f98028a3c83e9a : SUCCESS in 43m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/835eb75c58174046842db91b58adb1ba : SUCCESS in 7m 46s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/0556b69350b44e64b122e717d17b047b : SUCCESS in 9m 57s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/05e453c5d33d45d09fbcd2c2aab506a5 : SUCCESS in 12m 12s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/9adb7af16dc24b37b990537fc5fbff4d : SUCCESS in 12m 53s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/e093436920214f888f3a47a83a478af1 : SUCCESS in 13m 50s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/7da53ba752a1444fa47b87535371df63 : SUCCESS in 13m 41s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/c8bfa3769c0c4304834e88b9a18f3aae : SUCCESS in 14m 26s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/77b70d88d63c452289ec97dbe7a492cf : SUCCESS in 17m 34s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c55c5cfa6aba46eb85b5eba681a35b49 : SUCCESS in 16m 38s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/aeed1de5ee654c4d9e6938c31310e698 : SUCCESS in 16m 13s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/1ce7bc62d536474ebb00491028d23d1b : SUCCESS in 17m 45s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/5739ddcea3914ac69b1947012084b887 : SUCCESS in 17m 16s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/e265a35a9f3e4a17b4f8bb4f99d486f9 : SUCCESS in 23m 25s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/84cd685a50394fd0aaea6810671940a7 : SUCCESS in 45m 20s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/a50436c4d6d34ad5bcfbc881a2c42f24 : SUCCESS in 54m 24s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f0751083bd794169853da593fa4aa16e : SUCCESS in 38m 12s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6ebd1c22902740e98e84d4ec8923592f : SUCCESS in 34m 32s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0d47744bd1914b2b92cc0556049466f6 : SUCCESS in 13m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c67aeb24dfa242aa9a9e750036e66da2 : SUCCESS in 4m 47s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/b2477e3bf3164b0287b448b44259bab6 : FAILURE in 7m 24s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/e1c977afd40f4cb68ef5d68d0366c83b : SUCCESS in 51m 32s","accounts_in_message":[],"_revision_number":1},{"id":"cdee367220a1aa0d990a81a4117e6e1826644853","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-01-09 22:01:14.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nLove the idea, but a little worried about the potential size of the list. Maybe it never gets too long to worry about.\n\nif this is about help in debugging issues and wanting to know what devices a worker was in charge of, what about an info or debug log kine at start of cycle?\n\nJust a thought. Ill have a play on monday, i guess the list can only be ss long as the number of disks in your node.","accounts_in_message":[],"_revision_number":1},{"id":"bf7f844a0cd29539114ba6e8c67d057f62a46bd7","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-01-11 18:16:16.000000000","message":"Patch Set 1: Workflow-1\n\nGood point -- this was something I hit in my dinky 5-disk, 5-worker home lab, where I\u0027d have one worker that was way slower and I just wanted to know which disk it was a little more easily. If you\u0027ve got some setup like 24-bay chassis and only 2 workers, it\u0027s gonna suck. Maybe I\u0027ll make it a config option or something.\n\nFWIW, we *do* have debug lines for the worker args (https://github.com/openstack/swift/blob/2.26.0/swift/common/daemon.py#L191) but needing to go back and cross-reference logs like that seems kinda dumb when we could just drop more useful identifying information anyway.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"511c7247879642d7672d12f895582fda91a1b582","revisions":{"511c7247879642d7672d12f895582fda91a1b582":{"kind":"REWORK","_number":1,"created":"2021-01-08 21:23:09.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/93/769993/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/93/769993/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/93/769993/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/93/769993/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/93/769993/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/93/769993/1"}}},"commit":{"parents":[{"commit":"0681dabacb60acb71d3e89a9616292307653ae2e","subject":"Merge \"Avoid loops when gathering container listings from shards\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/0681dabacb60acb71d3e89a9616292307653ae2e"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-01-08 21:21:38.000000000","tz":-480},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-01-08 21:21:38.000000000","tz":-480},"subject":"obj: Include devices in per-worker logger prefixes","message":"obj: Include devices in per-worker logger prefixes\n\nChange-Id: I473664042215ce4ab92617cd71056451a00b64a3\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/511c7247879642d7672d12f895582fda91a1b582"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/511c7247879642d7672d12f895582fda91a1b582"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Workflow\u003dMIN"],"failing_atoms":["label:Workflow\u003dMAX"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}