)]}'
{"swift/common/internal_client.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d8f88d595445adbe1f65da3dce014064f081c0f","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self, conf_path, user_agent, request_tries):"},{"line_number":138,"context_line":"        self.app \u003d loadapp(\u0027config:\u0027 + conf_path,"},{"line_number":139,"context_line":"                           allow_modify_pipeline\u003dFalse)"},{"line_number":140,"context_line":"        self.user_agent \u003d user_agent"},{"line_number":141,"context_line":"        self.request_tries \u003d request_tries"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fzy4%3D","line":139,"updated":"2014-02-28 06:00:24.000000000","message":"how about lifting this up to a kwarg on __init__ here?","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"e8f9df3a34a10383f148ac4774a988305fb9a263","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def __init__(self, conf_path, user_agent, request_tries):"},{"line_number":138,"context_line":"        self.app \u003d loadapp(\u0027config:\u0027 + conf_path,"},{"line_number":139,"context_line":"                           allow_modify_pipeline\u003dFalse)"},{"line_number":140,"context_line":"        self.user_agent \u003d user_agent"},{"line_number":141,"context_line":"        self.request_tries \u003d request_tries"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fvv4%3D","line":139,"in_reply_to":"AAAAVX%2F%2Fzy4%3D","updated":"2014-02-28 21:09:53.000000000","message":"in case we want an InternalClient with all the stuff? Sure, that seems reasonable enough to me.","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"}],"swift/common/wsgi.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d8f88d595445adbe1f65da3dce014064f081c0f","unresolved":false,"context_lines":[{"line_number":314,"context_line":"    if ctx.object_type.name \u003d\u003d \u0027pipeline\u0027:"},{"line_number":315,"context_line":"        # give app the opportunity to modify the pipeline context"},{"line_number":316,"context_line":"        app \u003d ctx.app_context.create()"},{"line_number":317,"context_line":"        func \u003d getattr(app, \u0027modify_wsgi_pipeline\u0027, None)"},{"line_number":318,"context_line":"        if func:"},{"line_number":319,"context_line":"            func(PipelineWrapper(ctx))"},{"line_number":320,"context_line":"    return ctx.create()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fzu8%3D","side":"PARENT","line":317,"updated":"2014-02-28 06:00:24.000000000","message":"awww man that\u0027s the proxy server right there!  you just graph it off the app!","commit_id":"076634e23c9c9acbc48f71d1f28d32982f6d95a9"}],"test/unit/common/test_wsgi.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f541bde947da33201d9469c7595572709399fa91","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"            # make sure you can turn off the pipeline modification if you want"},{"line_number":823,"context_line":"            def blow_up(*_, **__):"},{"line_number":824,"context_line":"                raise Exception(\"needs more struts\")"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"            with mock.patch("},{"line_number":827,"context_line":"                    \u0027swift.proxy.server.Application.modify_wsgi_pipeline\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fxd4%3D","line":824,"updated":"2014-02-28 11:54:36.000000000","message":"Nit-picking, but if for some reason the allow_modify_pipeline\u003dFalse isn\u0027t working then I get a test error rather a failure. Can this be self.fail() instead of raise Exception?","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"e8f9df3a34a10383f148ac4774a988305fb9a263","unresolved":false,"context_lines":[{"line_number":821,"context_line":""},{"line_number":822,"context_line":"            # make sure you can turn off the pipeline modification if you want"},{"line_number":823,"context_line":"            def blow_up(*_, **__):"},{"line_number":824,"context_line":"                raise Exception(\"needs more struts\")"},{"line_number":825,"context_line":""},{"line_number":826,"context_line":"            with mock.patch("},{"line_number":827,"context_line":"                    \u0027swift.proxy.server.Application.modify_wsgi_pipeline\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fvu8%3D","line":824,"in_reply_to":"AAAAVX%2F%2Fxd4%3D","updated":"2014-02-28 21:09:53.000000000","message":"Sure, seems reasonable.","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"f541bde947da33201d9469c7595572709399fa91","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                self.assertRaises(  # sanity check"},{"line_number":830,"context_line":"                    Exception, wsgi.loadapp, conf_file, global_conf\u003d{})"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"                # passes by not crashing"},{"line_number":833,"context_line":"                wsgi.loadapp(conf_file, global_conf\u003d{},"},{"line_number":834,"context_line":"                             allow_modify_pipeline\u003dFalse)"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FxeE%3D","line":832,"updated":"2014-02-28 11:54:36.000000000","message":"agree with Clay that perhaps could assert pipeline is just [healthcheck, proxy-server] in this case","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4d8f88d595445adbe1f65da3dce014064f081c0f","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                self.assertRaises(  # sanity check"},{"line_number":830,"context_line":"                    Exception, wsgi.loadapp, conf_file, global_conf\u003d{})"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"                # passes by not crashing"},{"line_number":833,"context_line":"                wsgi.loadapp(conf_file, global_conf\u003d{},"},{"line_number":834,"context_line":"                             allow_modify_pipeline\u003dFalse)"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2Fzzo%3D","line":832,"updated":"2014-02-28 06:00:24.000000000","message":"weak.","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"},{"author":{"_account_id":2622,"name":"Samuel Merritt","email":"spam+launchpad@andcheese.org","username":"torgomatic"},"change_message_id":"e8f9df3a34a10383f148ac4774a988305fb9a263","unresolved":false,"context_lines":[{"line_number":829,"context_line":"                self.assertRaises(  # sanity check"},{"line_number":830,"context_line":"                    Exception, wsgi.loadapp, conf_file, global_conf\u003d{})"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"                # passes by not crashing"},{"line_number":833,"context_line":"                wsgi.loadapp(conf_file, global_conf\u003d{},"},{"line_number":834,"context_line":"                             allow_modify_pipeline\u003dFalse)"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVX%2F%2FuRo%3D","line":832,"in_reply_to":"AAAAVX%2F%2FxeE%3D","updated":"2014-02-28 21:09:53.000000000","message":"Sure, seems reasonable.","commit_id":"8223e871c4472b382b41a8a674e7e799da17e8a7"}]}