)]}'
{"swift/common/middleware/s3api/s3api.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7fded89a6ef33579097f5393a23358aca3ce42fd","unresolved":true,"context_lines":[{"line_number":280,"context_line":"            conf, log_route\u003dconf.get(\u0027log_name\u0027, \u0027s3api\u0027))"},{"line_number":281,"context_line":"        self.slo_enabled \u003d self.conf.allow_multipart_uploads"},{"line_number":282,"context_line":"        self.check_pipeline(self.conf)"},{"line_number":283,"context_line":"        self.conf.slo_enabled \u003d self.slo_enabled"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def __call__(self, env, start_response):"},{"line_number":286,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"66c17ceb_861a7fba","side":"PARENT","line":283,"updated":"2021-01-14 16:51:36.000000000","message":"this looks simpler","commit_id":"83233e7b36a451330c18eeefa19cf170eaa49abd"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7fded89a6ef33579097f5393a23358aca3ce42fd","unresolved":true,"context_lines":[{"line_number":347,"context_line":""},{"line_number":348,"context_line":"        # Check SLO middleware"},{"line_number":349,"context_line":"        if self.conf.allow_multipart_uploads and \u0027slo\u0027 not in auth_pipeline:"},{"line_number":350,"context_line":"            self.conf.allow_multipart_uploads \u003d False"},{"line_number":351,"context_line":"            self.logger.warning(\u0027s3api middleware requires SLO middleware \u0027"},{"line_number":352,"context_line":"                                \u0027to support multi-part upload, please add it \u0027"},{"line_number":353,"context_line":"                                \u0027in pipeline\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5687363e_13e6bdb6","line":350,"updated":"2021-01-14 16:51:36.000000000","message":"but this seems like it could be considered a hijacking of configuration and state; but I think the warning will be sufficiently clear to an operator","commit_id":"c1b9982161d5c090817e7d6ec43c126ada847693"}],"test/unit/common/middleware/s3api/test_s3request.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"5274cf6eda53c8e14e291100bb5583a0c97b1c85","unresolved":true,"context_lines":[{"line_number":1145,"context_line":"                         s3req.controller)"},{"line_number":1146,"context_line":""},{"line_number":1147,"context_line":"        # multi part requests require allow_multipart_uploads"},{"line_number":1148,"context_line":"        def do_check_slo_not_enabled(params):"},{"line_number":1149,"context_line":"            s3req \u003d make_s3req(Config({"},{"line_number":1150,"context_line":"                \u0027allow_multipart_uploads\u0027: False}), \u0027/bkt\u0027, params)"},{"line_number":1151,"context_line":"            self.assertRaises(s3response.S3NotImplemented,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0e97fcd3_c6614939","line":1148,"updated":"2021-01-19 09:53:23.000000000","message":"nit: func name could probably change","commit_id":"d9c433a4135e06c0deb4c804077c3d111aa84688"}],"test/unit/common/middleware/s3api/test_utils.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"7fded89a6ef33579097f5393a23358aca3ce42fd","unresolved":true,"context_lines":[{"line_number":133,"context_line":"class TestConfig(unittest.TestCase):"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def _assert_defaults(self, conf):"},{"line_number":136,"context_line":"        self.assertTrue(conf.slo_enabled)"},{"line_number":137,"context_line":"        self.assertEqual(\u0027\u0027, conf.storage_domain)"},{"line_number":138,"context_line":"        self.assertEqual(\u0027us-east-1\u0027, conf.location)"},{"line_number":139,"context_line":"        self.assertFalse(conf.force_swift_request_proxy_log)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c2d6efb8_18a274d4","side":"PARENT","line":136,"updated":"2021-01-14 16:51:36.000000000","message":"I don\u0027t understand is not conf.allow_multipart_uploads default still True?\n\n    self.assertEqual(True, conf.allow_multipart_uploads)\n\nseems to pass tests for me","commit_id":"83233e7b36a451330c18eeefa19cf170eaa49abd"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"cfd9272fb66e7b4e57cd0146095fa674d88dcca9","unresolved":true,"context_lines":[{"line_number":138,"context_line":"        self.assertEqual(\u0027us-east-1\u0027, conf.location)"},{"line_number":139,"context_line":"        self.assertFalse(conf.force_swift_request_proxy_log)"},{"line_number":140,"context_line":"        self.assertTrue(conf.dns_compliant_bucket_names)"},{"line_number":141,"context_line":"        self.assertTrue(conf.allow_multipart_uploads)"},{"line_number":142,"context_line":"        self.assertFalse(conf.allow_no_owner)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_defaults(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"65b2e51c_b22513d5","side":"PARENT","line":141,"updated":"2021-01-14 21:12:24.000000000","message":"Yup, we\u0027ve got that assertion still.","commit_id":"83233e7b36a451330c18eeefa19cf170eaa49abd"}]}