)]}'
{"id":"openstack%2Fswift~771467","triplet_id":"openstack%2Fswift~master~I357537492733b97e5afab4a7b8e6a5c527c650e4","project":"openstack/swift","branch":"master","topic":"p-s3api-pipeline-check","hashtags":[],"change_id":"I357537492733b97e5afab4a7b8e6a5c527c650e4","subject":"s3api: actually execute check_pipeline in real world","status":"MERGED","created":"2021-01-19 14:44:19.000000000","updated":"2021-01-21 22:49:50.000000000","submitted":"2021-01-21 22:46:45.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":3,"has_review_started":true,"submission_id":"771467-p-s3api-pipeline-check","meta_rev_id":"2955568ce141ab6be9f6b70e2763c07af932c525","_number":771467,"virtual_id_number":771467,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-21 22:46:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"all":[{"value":2,"date":"2021-01-21 01:53:17.000000000","_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2021-01-21 19:24:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2021-01-21 19:24:37.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-19 15:24:30.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"CC"},{"updated":"2021-01-20 05:01:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-21 01:53:17.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"},{"updated":"2021-01-21 19:24:37.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"eed42ab516266f90ec85ea385ff2f8c6b3ff66f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-01-19 14:44:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3a0490b76cd9bc93f7614f20195eb9f04aad0669","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-01-19 14:46:25.000000000","message":"Patch Set 1:\n\nQuestion is: do we break anyone if we fix this and start checking pipelines?","accounts_in_message":[],"_revision_number":1},{"id":"5e303a7622f3ff9542eb3306a508ef057fc0008e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-01-19 15:24:30.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nwe shouldn\u0027t have a check we\u0027re not using.  Making the check work seems better than letting people continue to run bad pipelines; but removing the check might also be reasonable (we\u0027ve gotten this far without it?)","accounts_in_message":[],"_revision_number":1},{"id":"486daaae075062493833547391b7a692679579ee","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-01-19 16:18:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1d67007898eefd3c39b582fb132e0584d5b2e6ee","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-01-19 17:08:49.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nUpgradeImpact: fixed s3api config checking\n\nat least with the slo case, if anyone is still running with a busted pipeline let\u0027s fix it!","accounts_in_message":[],"_revision_number":1},{"id":"63f2a3d3e5ff11402f02d10cf6b2ac9941a246c9","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-01-19 17:12:47.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9b8c0688f44540b87e1cbf4f5796df9c5c32b7ba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-01-19 20:23:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4dbc5036e89255707e5cd7f899f7b2e3d03269ec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-20 05:01:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/77aa0c384f8949e4975a569826e46c9c : SUCCESS in 9m 17s\n- grenade https://zuul.opendev.org/t/openstack/build/d27fbd84f2534f9c8c469d1d8fe4cbb0 : SUCCESS in 1h 09m 39s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/df34e04ea0664b2eafddf6ba425eba24 : SUCCESS in 52m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/d8b2fe57a5b54c5c98056fa77356ea71 : SUCCESS in 9m 15s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/25fec8c496d949ef9d025a3c05c1bf3f : SUCCESS in 8m 19s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e70db8315a114846ab86d44ab450c30f : SUCCESS in 14m 35s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/7abcb9214d5240338c758c19a6b2aba0 : SUCCESS in 26m 34s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/1aa9033ee14e49d883a758193539564e : SUCCESS in 18m 50s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/adea16377d744108955f4c94275edc74 : SUCCESS in 39m 43s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/5a06e7a3caa94b448cdcee18dd1c4b87 : SUCCESS in 16m 39s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/28364e1148d94500ae627867ebe85de9 : SUCCESS in 16m 43s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/adba4784fcc5460aab7ba5516f40c0a4 : SUCCESS in 17m 41s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/7ad41982ca6a41faa4631e3caaf6f852 : SUCCESS in 20m 26s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/b02473b6f3954fedb7315712a533d2bf : SUCCESS in 18m 31s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/46e484618c454aeea705abb6290f05b1 : SUCCESS in 17m 33s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0b1c9e9717444fc382ec415a403f59e4 : FAILURE in 20m 56s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/7998aab4fabc43f989fb2016640fcfe6 : SUCCESS in 44m 01s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/39464db989a3440c8734ec2e92a41848 : SUCCESS in 42m 33s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/45580f9004744b909ff2aded575910e4 : SUCCESS in 32m 59s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/82527ffff9e34e31b5599c46f092e4c4 : SUCCESS in 36m 46s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/096b14c73bc44c6399de99a8b25bce80 : SUCCESS in 15m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c3e676f4c6e0493f929042ce53eed4fe : SUCCESS in 5m 56s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/3b1c8f21bd26452ab08161bc93db50b7 : FAILURE in 8m 57s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/bfe475d08f02419db76008bc892d2aa4 : SUCCESS in 1h 05m 54s","accounts_in_message":[],"_revision_number":2},{"id":"f273dffa9fd4d1f2090149fa8caa334a90f8f65c","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-01-21 01:53:17.000000000","message":"Patch Set 2: Code-Review+2\n\nI see no downside. If someone had the flag set and it didn\u0027t work, but now it breaks, then maybe change that flag. Our configs ship with it missing, so they do the default.","accounts_in_message":[],"_revision_number":2},{"id":"4182ad7262fcc449b4805e40c92edf500ec6038c","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-01-21 19:24:37.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"fb1eef996e80d984dabf5463e2d11dc5e40d0785","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 19:25:21.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"61055a7a04bb32d018fd0f4b64337253f86c7a9b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 22:46:45.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f8719423a9694e3585222fe08c2391f7 : SUCCESS in 7m 59s\n- grenade https://zuul.opendev.org/t/openstack/build/252b602105c24abc821ea351333f48fe : SUCCESS in 50m 14s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/9e2d55fc7c534e2eb9865c507d160b16 : SUCCESS in 51m 07s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/63b8ae36c4fa41678d7a701cf3efaf57 : SUCCESS in 9m 40s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/5584acdce8e24969b150ffe9e8725252 : SUCCESS in 9m 57s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/5c23898dfe08485e8a9706ebcf1930fb : SUCCESS in 13m 08s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/282a53ed3234425d85496ad7af7e7e5d : SUCCESS in 29m 30s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/83fc1e140e2a4180b86df78b8166b3ac : SUCCESS in 29m 48s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/c79050d9e3204a8cbedae5801532cae4 : SUCCESS in 16m 47s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/2322241a9639474a89a16bfda79b587b : SUCCESS in 33m 08s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/702b4f97c3b54e9099ddbbe2e616c217 : SUCCESS in 33m 16s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/04726af0301b4edd8659def86030f25e : SUCCESS in 22m 54s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/df0506950b32495fa1a2ad3ed3f2cee7 : SUCCESS in 23m 06s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/1d6e32a9780a47bbb99d6043302bc7cd : SUCCESS in 18m 20s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/dab5babb73cb49f0ab8d4839604d431a : SUCCESS in 22m 15s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/9c5bcdf01a174d09b5364805fb2a29b1 : SUCCESS in 47m 50s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/73832dc90388417283f2faf7ea0b408f : SUCCESS in 47m 06s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/447fbaa3ff4348b097159ec0549bac9b : SUCCESS in 41m 56s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/bb6aa5dab08b403d96431c2f39b9faef : SUCCESS in 42m 55s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/511a2fda3f1c437b84221b691bce8fb8 : SUCCESS in 17m 30s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/27ed898baa4a4eba8556160ed3763abc : SUCCESS in 7m 39s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/0d590502c0274668a8d3e446e6912b09 : SUCCESS in 51m 51s","accounts_in_message":[],"_revision_number":2},{"id":"1beddfa80548adc3e8e9e5f1c4841cd4d284b21c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 22:46:45.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"2955568ce141ab6be9f6b70e2763c07af932c525","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-21 22:49:50.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7086c05098f44af9add06b33dfb779ae : SUCCESS in 1m 18s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/7f2fe24c871045deab98ae76f4e5ded0 : SUCCESS in 45s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/6909bcd65b5c48b2ad4223692b89b03e : SUCCESS in 56s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6896f1f54b511f90414f414a07371b1101e59931","revisions":{"d502ca592cafecde881824cd3047f7b68bfe07f4":{"kind":"REWORK","_number":1,"created":"2021-01-19 14:44:19.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/67/771467/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/67/771467/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/67/771467/1"}}},"commit":{"parents":[{"commit":"4ee05c5ddcb214182a1fa3e9e897e1d38c93c21d","subject":"Merge \"s3api: Get rid of slo_enabled flag\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ee05c5ddcb214182a1fa3e9e897e1d38c93c21d"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-01-19 14:25:09.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-01-19 14:43:04.000000000","tz":0},"subject":"s3api: actually execute check_pipeline in real world","message":"s3api: actually execute check_pipeline in real world\n\nS3ApiMiddleware.check_pipeline would exit early if self.conf.__file__\ndid not exit, which was always true. This patch will now cause\npipeline checks to be made for appropriate auth middleware placement,\nwith an Exception raised if the check fails. These checks were never\nrun before.\n\nChange-Id: I357537492733b97e5afab4a7b8e6a5c527c650e4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d502ca592cafecde881824cd3047f7b68bfe07f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d502ca592cafecde881824cd3047f7b68bfe07f4"}]},"branch":"refs/heads/master"},"6896f1f54b511f90414f414a07371b1101e59931":{"kind":"REWORK","_number":2,"created":"2021-01-19 20:23:39.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/67/771467/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/67/771467/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/67/771467/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/67/771467/2"}}},"commit":{"parents":[{"commit":"4ee05c5ddcb214182a1fa3e9e897e1d38c93c21d","subject":"Merge \"s3api: Get rid of slo_enabled flag\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ee05c5ddcb214182a1fa3e9e897e1d38c93c21d"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-01-19 14:25:09.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-01-19 20:22:43.000000000","tz":0},"subject":"s3api: actually execute check_pipeline in real world","message":"s3api: actually execute check_pipeline in real world\n\nPreviously, S3ApiMiddleware.check_pipeline would always exit early\nbecause the __file__ attribute of the Config instance passed to\ncheck_pipeline was never set. The __file__ key is typically passed to\nthe S3ApiMiddleware constructor in the wsgi config dict, so this dict\nis now passed to check_pipeline() for it to test for the existence of\n__file__.\n\nAlso, the use of a Config object is replaced with a dict where it\nmimics the wsgi conf object in the unit tests setup.\n\nUpgradeImpact\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nThe bug prevented the pipeline order checks described in\nproxy-server.conf-sample being made on the proxy-server pipeline when\ns3api middleware was included. With this change, these checks will now\nbe made and an invalid pipeline configuration will result in a\nValueError being raised during proxy-server startup.\n\nA valid pipeline has another middleware (presumed to be an auth\nmiddleware) between s3api and the proxy-server app. If keystoneauth is\nfound, then a further check is made that s3token is configured after\ns3api and before keystoneauth.\n\nThe pipeline order checks can be disabled by setting the s3api\nauth_pipeline_check option to False in proxy-server.conf. This\nmitigation is recommended if previously operating with what will now\nbe considered an invalid pipeline.\n\nThe bug also prevented a check for slo middleware being in the\npipeline between s3api and the proxy-server app. If the slo middleware\nis not found then multipart uploads will now not be supported,\nregardless of the value of the allow_multipart_uploads option\ndescribed in proxy-server.conf-sample. In this case a warning will be\nlogged during startup but no exception is raised.\n\nCloses-Bug: #1912391\nChange-Id: I357537492733b97e5afab4a7b8e6a5c527c650e4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6896f1f54b511f90414f414a07371b1101e59931"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/6896f1f54b511f90414f414a07371b1101e59931"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}