)]}'
{"id":"openstack%2Fswift~772621","triplet_id":"openstack%2Fswift~master~I8c385d1ac6ef35849f9afb8eea508bda5bd7b540","project":"openstack/swift","branch":"master","topic":"exaggerated_overlaps","hashtags":[],"change_id":"I8c385d1ac6ef35849f9afb8eea508bda5bd7b540","subject":"stop find_overlap_ranges report the same overlaps more then once","status":"NEW","created":"2021-01-27 03:16:04.000000000","updated":"2021-01-28 02:32:59.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":9,"unresolved_comment_count":5,"has_review_started":true,"meta_rev_id":"914a8f3f1c8a91699463e7c46e1ebf3b3fcb30bc","_number":772621,"virtual_id_number":772621,"owner":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-01-27 04:23:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":-1,"date":"2021-01-27 12:07:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-27 04:23:45.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-01-27 12:07:47.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"}],"messages":[{"id":"9beea75b423621f44bd5d81b8e73b4f3f7c136ea","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-01-27 03:16:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"96291f755048904e9929d14fd01b9ca6f1ec8010","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-27 04:23:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eadb0ef62639463b99c96580caf62216 : SUCCESS in 7m 56s\n- grenade https://zuul.opendev.org/t/openstack/build/4c0d915ef7e04449ab6302a13103331d : SUCCESS in 1h 03m 01s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/5331ac306cb542f4a77c81935c79e13a : SUCCESS in 43m 45s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/7e44bec2ff1e4a43b1c3a9032cf0af9a : SUCCESS in 9m 13s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/ae023841d5e74149b51a58b2bd32a5dd : SUCCESS in 8m 19s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/525d309c08c942648424b3eac8385489 : SUCCESS in 14m 40s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/8b08a0cf263547d2be9cf86e510667b4 : SUCCESS in 15m 09s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/1f2bd64ed7234cc7a7fcd81b50b8d646 : SUCCESS in 13m 47s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/447ed7bd2ce344a9987623a7cfaf5851 : SUCCESS in 12m 54s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7a343c82c2e849838e095fa2649c66db : SUCCESS in 22m 16s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/a84ae690f8b841658c7028ecdafab202 : SUCCESS in 16m 55s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/72627e60ed8d47c9a70a35de7c7e8a05 : SUCCESS in 17m 22s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/07b05b02728044ffb29d328828617161 : SUCCESS in 18m 55s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/9fb55ad5d488459eb7cb4bd445136b31 : SUCCESS in 16m 37s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/944ddd1e74ea47caaf441d9e7406cbc4 : SUCCESS in 16m 49s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/1e4b4e9e77194b1a9b205c3f3f3ee087 : FAILURE in 26m 02s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/14339ff0ef6b4ce6b6f8c03df4254339 : SUCCESS in 45m 09s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/27d956456d154092b1f094697ba58d0d : SUCCESS in 42m 41s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ad98323edd144408a31e9b8535848509 : SUCCESS in 44m 07s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8ac1ad8839e54c388a7be3f58fb5bd9d : SUCCESS in 33m 06s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d5bfc5e0d9ec42d48cb3f1c4ccd87dc9 : SUCCESS in 12m 27s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/058ce5603cef41199f27f3b4ed4939ba : SUCCESS in 5m 00s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/04b0a5f5599b467c899b26c76ffb9a18 : FAILURE in 9m 21s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a6cfc1d330464ad8bf535ed692b5b687 : SUCCESS in 1h 02m 07s","accounts_in_message":[],"_revision_number":1},{"id":"4de52e11e515d193d0d31ce604010f226f2b55be","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-01-27 12:07:47.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)\n\nThis is a bit of a can of worms...I\u0027m not sure what we actually want this method to return - overlapping tuples, or sequences with overlaps \n\ne.g. (a,c), (a,b), (b,c)\n\nshould that result in one tuple or two pairs? (a,b) does NOT overlap with (b,c) but for brevity in logs it may be better to say there\u0027s an overlap involving the tuple of all three.\n\nAlso, is it useful to include the shards in the logs, or just an indication that there are overlaps?","accounts_in_message":[],"_revision_number":1},{"id":"b80701bcc73b26416fe849936924d02b659e90d5","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-01-28 01:09:10.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"914a8f3f1c8a91699463e7c46e1ebf3b3fcb30bc","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-01-28 02:32:59.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dd997fe526cfae1ce6da1cf79997367a1fdabdd9","revisions":{"dd997fe526cfae1ce6da1cf79997367a1fdabdd9":{"kind":"REWORK","_number":1,"created":"2021-01-27 03:16:04.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/21/772621/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/21/772621/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/772621/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/772621/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/21/772621/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/21/772621/1"}}},"commit":{"parents":[{"commit":"d07de5c7f7c6bc8921a5c640085f854ec6e05ae9","subject":"Merge \"memcache: Log errors encountered when setting keys\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/d07de5c7f7c6bc8921a5c640085f854ec6e05ae9"}]}],"author":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2021-01-27 02:42:18.000000000","tz":660},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2021-01-27 03:14:01.000000000","tz":660},"subject":"stop find_overlap_ranges report the same overlaps more then once","message":"stop find_overlap_ranges report the same overlaps more then once\n\nWhen we find overlapping ranges we use sets to make sure we don\u0027t report\na set of overlapping ranges more then once. The loop that checks\nactually results in each SR finding overlapping ranges in a set multiple\ntimes, we sort the list before adding it to the set. However, the\nShardRange.__lt__ code doesn\u0027t take overlaps into account.\n\nThe __lt__ code specifically mentions that when comparing 1 shardrange\nto another, one is \u003c only if it\u0027s _entire_ range is \u003c the lower of the\nother.\n\nSo we use key with attrgetter to sort the list by lower and secondly\nby upper.\n\nCloses-Bug: #1913332\nChange-Id: I8c385d1ac6ef35849f9afb8eea508bda5bd7b540\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dd997fe526cfae1ce6da1cf79997367a1fdabdd9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/dd997fe526cfae1ce6da1cf79997367a1fdabdd9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}