)]}'
{"swift/cli/relinker.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"79ad35cefaf86b6cc0ddef8e48f6cf6617f54aef","unresolved":true,"context_lines":[{"line_number":24,"context_line":"from swift.common.exceptions import DiskFileDeleted, DiskFileNotExist, \\"},{"line_number":25,"context_line":"    DiskFileQuarantined"},{"line_number":26,"context_line":"from swift.common.utils import replace_partition_in_path, \\"},{"line_number":27,"context_line":"    audit_location_generator, get_logger"},{"line_number":28,"context_line":"from swift.obj import diskfile"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fd2aaae_7f191f8c","side":"PARENT","line":27,"updated":"2021-02-03 06:09:39.000000000","message":"Ok logger comes back on the next patchset. I guess just something out of order.","commit_id":"9e14a778cdbdb67d178e201ec008223b2bbcc99b"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7b8fa8d66afaa72e631f0a93e5c46b4b95419a4d","unresolved":true,"context_lines":[{"line_number":225,"context_line":"            device\u003dNone):"},{"line_number":226,"context_line":"    mount_check \u003d not skip_mount_check"},{"line_number":227,"context_line":"    conf \u003d {\u0027devices\u0027: devices, \u0027mount_check\u0027: mount_check}"},{"line_number":228,"context_line":"    diskfile_router \u003d diskfile.DiskFileRouter(conf, get_logger(conf))"},{"line_number":229,"context_line":"    errors \u003d cleaned_up \u003d 0"},{"line_number":230,"context_line":"    run \u003d False"},{"line_number":231,"context_line":"    for policy in POLICIES:"}],"source_content_type":"text/x-python","patch_set":2,"id":"261adfb2_413d4742","side":"PARENT","line":228,"range":{"start_line":228,"start_character":52,"end_line":228,"end_character":68},"updated":"2021-02-03 18:46:19.000000000","message":"Yeah, I did it \u0027cause this just seemed dumb -- there\u0027s nothing about logging in the conf we just defined above, so it seemed to make way more sense to use the logger we already have in hand. Maybe I should\u0027ve pushed it out to the next patch.","commit_id":"9e14a778cdbdb67d178e201ec008223b2bbcc99b"}],"test/unit/cli/test_relinker.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"7b8fa8d66afaa72e631f0a93e5c46b4b95419a4d","unresolved":true,"context_lines":[{"line_number":493,"context_line":"        self._common_test_cleanup()"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # Switch the policy type so that actually all fragments are non-durable"},{"line_number":496,"context_line":"        # and raise a DiskFileNotExist in EC in this test. However, if the"},{"line_number":497,"context_line":"        # counterpart exists in the new location, this is ok - it will be fixed"},{"line_number":498,"context_line":"        # by the reconstructor later on"},{"line_number":499,"context_line":"        with mock.patch.object(relinker.logging, \u0027getLogger\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5d05bb57_dbb8c048","line":496,"updated":"2021-02-03 18:46:19.000000000","message":"So, this comment seems to be a lie. IDK why we\u0027ve got this test the way it is.","commit_id":"c7d40508a1682c0a5fd363d682089d7f10a6cd18"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c7182ecad516de448b5ac46a5e57b199894dffb5","unresolved":true,"context_lines":[{"line_number":493,"context_line":"        self._common_test_cleanup()"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"        # Switch the policy type so that actually all fragments are non-durable"},{"line_number":496,"context_line":"        # and raise a DiskFileNotExist in EC in this test. However, if the"},{"line_number":497,"context_line":"        # counterpart exists in the new location, this is ok - it will be fixed"},{"line_number":498,"context_line":"        # by the reconstructor later on"},{"line_number":499,"context_line":"        with mock.patch.object(relinker.logging, \u0027getLogger\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"b58c2c73_358604f8","line":496,"in_reply_to":"5d05bb57_dbb8c048","updated":"2021-02-08 14:44:04.000000000","message":"worth fixing the comment? AFAICT using an EC policy causes a DiskFileError and as this test now asserts that is due to bad frag index (although its also true, albeit irrelevant, that the frag is not durable)","commit_id":"c7d40508a1682c0a5fd363d682089d7f10a6cd18"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"c7182ecad516de448b5ac46a5e57b199894dffb5","unresolved":true,"context_lines":[{"line_number":529,"context_line":"                         \u0027Expected 2 log lines, got %r\u0027 % log_lines)"},{"line_number":530,"context_line":"        self.assertIn(\u0027metadata content-length 12 does not match \u0027"},{"line_number":531,"context_line":"                      \u0027actual object size 5\u0027, log_lines[0])"},{"line_number":532,"context_line":"        self.assertIn(\u0027failed audit and was quarantined\u0027, log_lines[1])"},{"line_number":533,"context_line":""},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a1b903a8_56956b4c","line":532,"updated":"2021-02-08 14:44:04.000000000","message":"presumably we\u0027re getting 2 lines now because there\u0027s just one logger involved? that\u0027s good!","commit_id":"c7d40508a1682c0a5fd363d682089d7f10a6cd18"}]}