)]}'
{"test/unit/container/test_sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"da7d5dd87cf963adb3f61968d177a95afe6f6879","unresolved":true,"context_lines":[{"line_number":6127,"context_line":"            state\u003dShardRange.ACTIVE, object_count\u003d6)"},{"line_number":6128,"context_line":"        broker.merge_shard_ranges(shard_ranges)"},{"line_number":6129,"context_line":"        sequences \u003d find_compactable_shard_sequences(broker, 10, 33, -1, -1)"},{"line_number":6130,"context_line":"        self.assertEqual([shard_ranges[:5], shard_ranges[5:]], sequences)"},{"line_number":6131,"context_line":"        shard_ranges[4].update_meta(20, 2000)"},{"line_number":6132,"context_line":"        shard_ranges[6].update_meta(28, 2700)"},{"line_number":6133,"context_line":"        broker.merge_shard_ranges(shard_ranges)"}],"source_content_type":"text/x-python","patch_set":2,"id":"752a7fbf_5a1e37b2","line":6130,"updated":"2021-02-10 12:25:19.000000000","message":"this fails if the change is reverted: range f-g gets skipped because it was considered for the first sequence but rejected because it would take the proposed merged object count over 33, but then it was not being considered at the start of the next sequence.","commit_id":"1d2d54a5019d13cbff58545b135277a8562125d5"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"33c0fb103831c1ccde79d218922b1e74a5cb311e","unresolved":true,"context_lines":[{"line_number":6172,"context_line":"        shard_ranges[6].update_meta(28, 2700)"},{"line_number":6173,"context_line":"        broker.merge_shard_ranges(shard_ranges)"},{"line_number":6174,"context_line":"        sequences \u003d find_compactible_shard_sequences(broker, 10, 33, -1, -1)"},{"line_number":6175,"context_line":"        self.assertEqual([shard_ranges[:4], shard_ranges[7:]], sequences)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c032c39f_af2a42a2","line":6175,"updated":"2021-02-17 04:25:33.000000000","message":"Nice, A comment about why those sequences would be nice, but not a stopper\n\n# 0-4 can merge, 5 is to big, 6 is small enough but can\u0027t merge into 7 because it\u0027s too big, 8 - 10 can merge.","commit_id":"21a01e1c0538046915c0482baab14f6bd9a36154"}]}