)]}'
{"test/unit/cli/test_relinker.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"32a3a0d0da0cb3c33ed566c9b8f66c9ee2a9b238","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                          ignore_errors\u003d1)"},{"line_number":262,"context_line":"            obj \u003d \u0027o%s\u0027 % i"},{"line_number":263,"context_line":"            self._setup_object(\u0027a\u0027, \u0027c\u0027, obj)"},{"line_number":264,"context_line":"        self.assertLess(self.part, 2 ** (PART_POWER - 1))"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        self.rb.prepare_increase_partition_power()"},{"line_number":267,"context_line":"        self._save_ring()"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad574a64_f602d083","line":264,"updated":"2021-02-17 02:35:09.000000000","message":"So there is ia chance that test will itermitantly fail sometimes if we cant get a small enough partt in 10 tries?","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"83d58ff85e747a8cd37def270720ad1ef83f3433","unresolved":true,"context_lines":[{"line_number":261,"context_line":"                          ignore_errors\u003d1)"},{"line_number":262,"context_line":"            obj \u003d \u0027o%s\u0027 % i"},{"line_number":263,"context_line":"            self._setup_object(\u0027a\u0027, \u0027c\u0027, obj)"},{"line_number":264,"context_line":"        self.assertLess(self.part, 2 ** (PART_POWER - 1))"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"        self.rb.prepare_increase_partition_power()"},{"line_number":267,"context_line":"        self._save_ring()"}],"source_content_type":"text/x-python","patch_set":1,"id":"4904f482_719f37df","line":264,"in_reply_to":"ad574a64_f602d083","updated":"2021-02-18 17:34:16.000000000","message":"This is same in setup() and I have seen it fail to find necessary part in 10 iterations","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"83d58ff85e747a8cd37def270720ad1ef83f3433","unresolved":true,"context_lines":[{"line_number":309,"context_line":"    def test_relink_second_quartile_does_rehash(self):"},{"line_number":310,"context_line":"        for i in range(10):"},{"line_number":311,"context_line":"            # we need a part in upper half of current part power"},{"line_number":312,"context_line":"            if self.part \u003e 2 ** (PART_POWER - 1):"},{"line_number":313,"context_line":"                break"},{"line_number":314,"context_line":"            shutil.rmtree(os.path.join(self.objects, str(self.part)),"},{"line_number":315,"context_line":"                          ignore_errors\u003d1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6f04a6a2_0749e7ad","line":312,"updated":"2021-02-18 17:34:16.000000000","message":"should be \u003e\u003d vs \u003c in the relink tests","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"32a3a0d0da0cb3c33ed566c9b8f66c9ee2a9b238","unresolved":true,"context_lines":[{"line_number":450,"context_line":"        self.assertFalse(os.path.isfile("},{"line_number":451,"context_line":"            os.path.join(self.objdir, self.object_fname)))"},{"line_number":452,"context_line":"        self.assertFalse(os.path.exists("},{"line_number":453,"context_line":"            os.path.join(self.objects, str(self.part))))"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"    def test_cleanup_second_quartile_no_rehash(self):"},{"line_number":456,"context_line":"        # remove the setup object"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc887776_ee2fc0ac","line":453,"updated":"2021-02-17 02:35:09.000000000","message":"We never actually check for it to be rehashed. if not mocking surely we can just check for a hashes.pkl or something.","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"83d58ff85e747a8cd37def270720ad1ef83f3433","unresolved":true,"context_lines":[{"line_number":460,"context_line":"        self._setup_object(\u0027a\u0027, \u0027c\u0027, \u0027o0\u0027)"},{"line_number":461,"context_line":"        self.assertGreater(self.part, 2 ** (PART_POWER - 1))"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        # I don\u0027t think this adds prev_part_power to state"},{"line_number":464,"context_line":"        self._common_test_cleanup()"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        # cleanup"}],"source_content_type":"text/x-python","patch_set":1,"id":"9330a985_9f79c90c","line":463,"updated":"2021-02-18 17:34:16.000000000","message":"prev_part_power comes from the states file which AFAICT isn\u0027t even going to exist when the test jumps straight to cleanup","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"83d58ff85e747a8cd37def270720ad1ef83f3433","unresolved":true,"context_lines":[{"line_number":479,"context_line":"            ]))"},{"line_number":480,"context_line":"        self.assertEqual({"},{"line_number":481,"context_line":"            os.path.dirname(self.objdir),"},{"line_number":482,"context_line":"            # why isn\u0027t the \"upper\" half filtered during cleanup?"},{"line_number":483,"context_line":"            os.path.dirname(self.expected_dir),"},{"line_number":484,"context_line":"        }, set(called))"},{"line_number":485,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6cc21806_bad62bd6","line":482,"updated":"2021-02-18 17:34:16.000000000","message":"prev_part_power missing?","commit_id":"a9e1d1009cc7682df62c125c371ee368e8d048be"}]}