)]}'
{"swift/cli/manage_shard_ranges.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1f06b24b7b1ed280b964fb42cd3ab566198dfa7c","unresolved":true,"context_lines":[{"line_number":180,"context_line":""},{"line_number":181,"context_line":"def _print_shard_range(sr, level\u003d0, verbose\u003dFalse):"},{"line_number":182,"context_line":"    indent \u003d \u0027  \u0027 * level"},{"line_number":183,"context_line":"    if verbose:"},{"line_number":184,"context_line":"        print(indent + \u0027   name: %r\u0027 % sr.name)"},{"line_number":185,"context_line":"    print(indent + \u0027objects: %-9d lower: %r\u0027 % (sr.object_count, sr.lower_str))"},{"line_number":186,"context_line":"    print(indent + \u0027  state: %-9s upper: %r\u0027 % (sr.state_text, sr.upper_str))"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"def _load_and_validate_shard_data(args):"},{"line_number":190,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"39b61df9_2e69ef4e","line":187,"range":{"start_line":183,"start_character":0,"end_line":187,"end_character":0},"updated":"2021-02-26 09:48:41.000000000","message":"I was taking advantage of \u0027objects\u0027 being longer to give a visual cue for the start of each shard range (imagine if you have more than one donor being listed):\n\n  objects:\n    state:\n  objects:\n    state:\n\nwhich gets lost when the name is added:\n\n     name:\n  objects:\n    state:\n     name:\n  objects:\n    state:\n\nHow would you feel about adding name after objects, state? i.e.\n\n  objects:\n    state:\n     name:\n  objects:\n    state:\n     name:\n\nOr, maybe better... print name *always* and make *it* the visual delimiter by putting it up front without a \u0027name:\u0027\n\n  \u0027.shards_AUTH_admin/shardme-7820d6e9550a1661e01e0538aea8cc1b-1614319760.63229-5\u0027\n      objects:\n      state:\n  \u0027.shards_AUTH_admin/shardme-7820d6e9550a1661e01e0538aea8cc1b-1614319760.63229-6\u0027\n      objects:\n      state:\n\nThat\u0027ll also need a couple of spaces added before the objects and state keys.","commit_id":"4818b5731def22f52feb869c6249c2d7427859d5"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f91b8fc761885ada32b1af11a2961b2ed4fa1174","unresolved":true,"context_lines":[{"line_number":184,"context_line":"    print(indent + \u0027%r\u0027 % sr.name)"},{"line_number":185,"context_line":"    print(indent + \u0027  objects: %-9d lower: %r\u0027 % (sr.object_count,"},{"line_number":186,"context_line":"                                                  sr.lower_str))"},{"line_number":187,"context_line":"    print(indent + \u0027  state: %-9s   upper: %r\u0027 % (sr.state_text, sr.upper_str))"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def _load_and_validate_shard_data(args):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2731b930_b3484277","line":187,"range":{"start_line":187,"start_character":34,"end_line":187,"end_character":36},"updated":"2021-03-12 19:06:29.000000000","message":"So we\u0027re lining up on the start instead of the colon now? I might try it the other way again, but eh.","commit_id":"fd5bd9bfbd08a57d8f87ed331526fa0907e98616"}],"test/unit/cli/test_manage_shard_ranges.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"f91b8fc761885ada32b1af11a2961b2ed4fa1174","unresolved":true,"context_lines":[{"line_number":703,"context_line":"            self.assertIn(\u0027can be compacted into\u0027, out_lines[7])"},{"line_number":704,"context_line":"            self.assertIn(\u0027.shards_a\u0027, out_lines[8])"},{"line_number":705,"context_line":"            self.assertIn(\u0027objects: 10\u0027, out_lines[9])"},{"line_number":706,"context_line":"            self.assertIn(\u0027state: active\u0027, out_lines[10])"},{"line_number":707,"context_line":"            return broker.get_shard_ranges()"},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"        broker_ranges \u003d do_compact(\u0027n\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"55c949df_7e12fcab","line":706,"updated":"2021-03-12 19:06:29.000000000","message":":-/ These don\u0027t make any assertions about the indent levels.","commit_id":"fd5bd9bfbd08a57d8f87ed331526fa0907e98616"}]}