)]}'
{"swift/proxy/controllers/obj.py":[{"author":{"_account_id":2828,"name":"Michael Barton","email":"mike@weirdlooking.com","username":"redbo"},"change_message_id":"35d70df52229165228418531bc0477f7ec5801d1","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                    if bytes_transferred \u003e MAX_FILE_SIZE:"},{"line_number":504,"context_line":"                        raise HTTPRequestEntityTooLarge(request\u003dreq)"},{"line_number":505,"context_line":"                    for conn in list(conns):"},{"line_number":506,"context_line":"                        print \u0027chunk: %s\u0027 % chunk"},{"line_number":507,"context_line":"                        if not conn.failed:"},{"line_number":508,"context_line":"                            conn.queue.put("},{"line_number":509,"context_line":"                                \u0027%x\\r\\n%s\\r\\n\u0027 % (len(chunk), chunk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FkNA%3D","line":506,"updated":"2014-03-05 11:27:41.000000000","message":"oops?","commit_id":"696948baa6b4e5ca42619aad9a35011d23d2c25a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f131fbc8491272d0a8276f5e0de77d129201e298","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                    if bytes_transferred \u003e MAX_FILE_SIZE:"},{"line_number":504,"context_line":"                        raise HTTPRequestEntityTooLarge(request\u003dreq)"},{"line_number":505,"context_line":"                    for conn in list(conns):"},{"line_number":506,"context_line":"                        print \u0027chunk: %s\u0027 % chunk"},{"line_number":507,"context_line":"                        if not conn.failed:"},{"line_number":508,"context_line":"                            conn.queue.put("},{"line_number":509,"context_line":"                                \u0027%x\\r\\n%s\\r\\n\u0027 % (len(chunk), chunk)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FgZg%3D","line":506,"in_reply_to":"AAAAVn%2F%2FkNA%3D","updated":"2014-03-05 17:53:04.000000000","message":"I don\u0027t even remember adding that?  I wonder what else I snuck in here :\\","commit_id":"696948baa6b4e5ca42619aad9a35011d23d2c25a"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f131fbc8491272d0a8276f5e0de77d129201e298","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        except HTTPException as resp:"},{"line_number":830,"context_line":"            return resp"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        resp \u003d self._store_object(req, data_source, **extra_info)"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        return update_response(resp)"},{"line_number":835,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FgXY%3D","line":832,"updated":"2014-03-05 17:53:04.000000000","message":"I think i sorta used to like this call signature (more or less), basically passing in 9 *required and named* arguments defined instead of positional.  Could you give me some more ideas?","commit_id":"696948baa6b4e5ca42619aad9a35011d23d2c25a"},{"author":{"_account_id":917,"name":"Chuck Thier","email":"cthier@gmail.com","username":"cthier"},"change_message_id":"3ec0a01324f3f599aef0eaad27abdaddffd49135","unresolved":false,"context_lines":[{"line_number":830,"context_line":"            return resp"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        resp \u003d self._store_object(req, data_source, **extra_info)"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        return update_response(resp)"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":"    @public"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAVn%2F%2FfN0%3D","line":833,"updated":"2014-03-05 19:49:24.000000000","message":"What about something like:\n\nhttp://paste.openstack.org/show/72696/","commit_id":"696948baa6b4e5ca42619aad9a35011d23d2c25a"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"6358b600280b6e847c2b20b79f1095b10366567b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                    body\u003d\u0027X-Timestamp should be a UNIX timestamp float value; \u0027"},{"line_number":350,"context_line":"                         \u0027was %r\u0027 % req.headers[\u0027x-timestamp\u0027])"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            req.headers[\u0027X-Timestamp\u0027] \u003d normalize_timestamp(time.time())"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _update_content_type(self, req):"},{"line_number":355,"context_line":"        # Sometimes the \u0027content-type\u0027 header exists, but is set to None."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F94Jk%3D","line":352,"updated":"2014-04-01 14:00:11.000000000","message":"Best to have an explicit \"return None\" here to indicate it wasn\u0027t just missed; or change the method to raise values rather than return them (probably the better idea, I dunno). Also, might name the function _validate_x_timestamp to better indicate it returns something.","commit_id":"a1cfeb70f95853c538ba833a28028f17a069cfb3"},{"author":{"_account_id":1216,"name":"gholt","email":"z-launchpad@brim.net","username":"gholt"},"change_message_id":"6358b600280b6e847c2b20b79f1095b10366567b","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    if bytes_transferred \u003e MAX_FILE_SIZE:"},{"line_number":483,"context_line":"                        raise HTTPRequestEntityTooLarge(request\u003dreq)"},{"line_number":484,"context_line":"                    for conn in list(conns):"},{"line_number":485,"context_line":"                        print \u0027chunk: %s\u0027 % chunk"},{"line_number":486,"context_line":"                        if not conn.failed:"},{"line_number":487,"context_line":"                            conn.queue.put("},{"line_number":488,"context_line":"                                \u0027%x\\r\\n%s\\r\\n\u0027 % (len(chunk), chunk)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F94IE%3D","line":485,"updated":"2014-04-01 14:00:11.000000000","message":"Oops print.","commit_id":"a1cfeb70f95853c538ba833a28028f17a069cfb3"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ea3156d123c2c0ae96396311c71ffab130dbd9de","unresolved":false,"context_lines":[{"line_number":724,"context_line":"            self.account_name, self.container_name, req)"},{"line_number":725,"context_line":"        # rather than do this check can we just have container_info raise?"},{"line_number":726,"context_line":"        if not container_info[\u0027nodes\u0027]:"},{"line_number":727,"context_line":"            return HTTPNotFound()"},{"line_number":728,"context_line":"        req.acl \u003d container_info[\u0027write_acl\u0027]"},{"line_number":729,"context_line":"        req.environ[\u0027swift_sync_key\u0027] \u003d container_info[\u0027sync_key\u0027]"},{"line_number":730,"context_line":"        object_versions \u003d container_info[\u0027versions\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F98IE%3D","line":727,"updated":"2014-04-01 04:44:56.000000000","message":"I see it should be safe to omit request\u003dreq here, because Response.request is only needed if anything interesting is in the environ and if it\u0027s HEAD (but this is PUT). Still... Reassure me that you thought about it.","commit_id":"a1cfeb70f95853c538ba833a28028f17a069cfb3"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"ea3156d123c2c0ae96396311c71ffab130dbd9de","unresolved":false,"context_lines":[{"line_number":764,"context_line":""},{"line_number":765,"context_line":"        self._update_content_type(req)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"        self._update_x_timestamp(req, hresp)"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        error_response \u003d check_object_creation(req, self.object_name) or \\"},{"line_number":770,"context_line":"            check_content_type(req)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWH%2F98Ho%3D","line":767,"updated":"2014-04-01 04:44:56.000000000","message":"Did you just ignore the HTTPBadRequest that _update_x_timestamp can return or I\u0027m imagining things?","commit_id":"a1cfeb70f95853c538ba833a28028f17a069cfb3"}]}