)]}'
{"id":"openstack%2Fswift~778540","triplet_id":"openstack%2Fswift~master~I5fbf8671f2ee63467d46f651e2c24529a2697626","project":"openstack/swift","branch":"master","topic":"p-diskfile-relink-paths-race","hashtags":[],"change_id":"I5fbf8671f2ee63467d46f651e2c24529a2697626","subject":"Add unit test for diskfile.relink_paths","status":"MERGED","created":"2021-03-03 18:35:43.000000000","updated":"2021-03-19 09:44:50.000000000","submitted":"2021-03-09 01:14:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":5,"has_review_started":true,"submission_id":"778540-p-diskfile-relink-paths-race","meta_rev_id":"80af91b10644466ba092a674026a9d4f8dea74d9","_number":778540,"virtual_id_number":778540,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-09 01:14:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":2,"date":"2021-03-08 23:30:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"value":1,"date":"2021-03-08 23:30:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":1,"date":"2021-03-08 17:00:17.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-03 19:11:06.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2021-03-03 22:55:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-05 05:07:09.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"REVIEWER"},{"updated":"2021-03-08 17:00:17.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"1439296b167b5f879ecc821aef7e70504c063228","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-03 18:35:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d304a7606e8ae0d03d91dce81ed48baf375a8e31","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-03 19:11:06.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)\n\nYeah, seems like a good/reasonable test.","accounts_in_message":[],"_revision_number":1},{"id":"a8d666c6a053a093e527485e6c21049b6a6e6fb1","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-03 22:55:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1c9118c1f17b4466aad133f3605629c2 : SUCCESS in 14m 00s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/f8852a72b28b46f4b68d7383ebc10928 : SUCCESS in 10m 54s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/de7fc645ff14436ca53a4230a24fa469 : SUCCESS in 12m 18s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b634d8c1e4b2419fb39f387549bdde7d : SUCCESS in 19m 03s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/86f0603fc5974f67aeb41a29a693772a : SUCCESS in 19m 31s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/47ceeb994b3c46f89a4561c10755fdeb : SUCCESS in 20m 55s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/ee3625861f5c4f1c90e55145d52e28e9 : SUCCESS in 19m 03s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/fcbe206be7f74057b5e00a7b69d8073b : SUCCESS in 24m 03s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/ec986c00492444e080e61c4d9060daee : SUCCESS in 25m 54s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/0c44cb66575d4eb9bdd4eeb31fdaf84f : SUCCESS in 29m 55s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/5f30c529afc64a758811cc4b59f2b5b8 : FAILURE in 30m 35s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/46c9cf6d432249c4816d1bdfbc2acd7a : FAILURE in 29m 37s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/7d9fef1a4e6f456f8ce42d8cd367ac83 : SUCCESS in 19m 14s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/e4aada2c72874718ae7e62d599088d88 : SUCCESS in 24m 25s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/0473c148e8874b2ca61f60c3ef5afd21 : SUCCESS in 43m 16s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/1fa0fe4f4537426380acb8fac26fe87d : SUCCESS in 52m 32s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/77605ec39b74403099baa4962e441d20 : SUCCESS in 21m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9635148acb004908b091f6c141766852 : SUCCESS in 10m 21s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/bcaf2f4db2824378935e3045ab16c761 : FAILURE in 13m 33s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"dc54d31ba575797f4b3d98e74e87985ad62a7158","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-04 16:48:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"088010a1355533537eab135771707294b6348c32","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-04 19:54:44.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/184ad187add34d4683fd3a7a1d5d9913 : SUCCESS in 12m 11s\n- grenade https://zuul.opendev.org/t/openstack/build/deab42025d4c40449fcb8d92b2d0b095 : SUCCESS in 1h 03m 10s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/c2a921631fc94f88a3c075fd067894c6 : SUCCESS in 48m 09s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/25dfbe61aa8f4902b4907d1d7991eb09 : SUCCESS in 11m 03s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/f45e7b0a273745f08de4e7b3de47e8b2 : SUCCESS in 8m 21s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/886d94d90b3e4dc894eff930dcd7ab6f : SUCCESS in 29m 15s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/c0cec654933640efbf29221bf2668d23 : SUCCESS in 17m 20s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/5f2df9a067aa44a49dc67a60e00fc9d0 : FAILURE in 26m 15s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/2256d894f1744de383c18ed107072f58 : FAILURE in 30m 58s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/b577683547754ed8b3eab17854fb4d3d : FAILURE in 20m 39s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/2f40e213c22249de9bf7a775f3d916fc : SUCCESS in 32m 59s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/a1e420140fd6404282defd5a3a44c2d6 : SUCCESS in 25m 57s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/af64daf0bb6d49d4a5cfa4991bc742a7 : SUCCESS in 28m 09s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/39f3153d9df3419fae89193b69d23865 : SUCCESS in 24m 15s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/dd59735f73154661940303f4a666c31b : SUCCESS in 21m 41s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/fc440105f2c94aa69a4f466a1e5bdf28 : SUCCESS in 21m 48s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/4344e232ea3f4774b5901f2da36c571e : SUCCESS in 7m 00s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/bda8700cedd74d1b8af52773bfe50693 : FAILURE in 25m 19s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/d58f9fef082d41ca867d2b5a2d063a0b : SUCCESS in 47m 52s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/d963801afd1c431ab53ef83ad7b99c9b : SUCCESS in 51m 09s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/b0913b6d78584cbcbf65a2c2b38cc310 : SUCCESS in 47m 36s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/c15722e3b3774cdf9864ef3becf063cf : SUCCESS in 44m 10s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0ee57281e7fa43bb9a731282ef6a6b59 : SUCCESS in 23m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0bf8198f282a47bca3aefee398484e85 : SUCCESS in 8m 32s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/ae26fa92d7ab48b7a2b77ca7833124de : FAILURE in 14m 44s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/90552a0786fb404181cc2bc3692b13fc : SUCCESS in 58m 44s","accounts_in_message":[],"_revision_number":2},{"id":"73d6b31129e64ea624cf1ecefd9f02db37f02b12","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-03-05 05:07:09.000000000","message":"Patch Set 2: Code-Review-1\n\nlooks like a legit failure on added test:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFAIL: test_PUT_next_part_power_races_around_makedirs_eexist (test.unit.obj.test_server.TestObjectController)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/swift/test/unit/obj/test_server.py\", line 2915, in test_PUT_next_part_power_races_around_makedirs_eexist\n    make_request(ts_1)\n  File \"/home/zuul/src/opendev.org/openstack/swift/test/unit/obj/test_server.py\", line 2885, in make_request\n    self.assertEqual(resp.status_int, 201)\nAssertionError: 500 !\u003d 201","accounts_in_message":[],"_revision_number":2},{"id":"448bb1982897971c11830d5e0dd30b6d361117ab","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-03-05 05:13:54.000000000","message":"Patch Set 2:\n\nhmm but I can\u0027t recreate it on my SAIO. It always passes here.","accounts_in_message":[],"_revision_number":2},{"id":"b7e8463e4df2daf7db6dcab9980c599bc2ea40c8","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-03-05 05:29:02.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nopss, my mistake, you need to run the test suite that is failing :P In this case it\u0027s failing on py3. But it\u0027s an easy fix.","accounts_in_message":[],"_revision_number":2},{"id":"262b4b64dbde35b1f536ecaf4b818b1626ccfdbd","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-03-05 06:01:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a731dfea21a45623db9860c7479416479608bff7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-05 07:36:26.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9c83936d87fb43a4932313360d3c2a2c : SUCCESS in 9m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/3e78eed570d24f86ac762f877eac2f25 : SUCCESS in 56m 20s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/84283978b180465c9827c1190a1ff84e : SUCCESS in 42m 48s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/79fd3547a8a644b69bf5d83d6092a6bf : SUCCESS in 9m 25s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/29345efa3f834620a93693a5e8f2b8b3 : SUCCESS in 8m 15s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/6c554ea395ba4b94bab3d32389ab3328 : SUCCESS in 16m 03s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/91d0c4a9880e4239827e44e47333abf4 : SUCCESS in 16m 54s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/00c2611fcfe943dc80024cb48b4706d6 : SUCCESS in 17m 03s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/44efd6c467944548975d467f481cf874 : SUCCESS in 23m 15s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/277c5639fcdb46939c1fbdc485730436 : SUCCESS in 17m 41s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/85f049ab1cd144a5b8cdf5b9e4a1af9d : SUCCESS in 37m 26s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/85cfb90057ed46b9b4063569824b68a0 : SUCCESS in 37m 53s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/8f1fa3f15ae647f1b33148457fa89bd4 : SUCCESS in 38m 10s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/0685103846b04a37b23e8024bb4dea44 : SUCCESS in 37m 04s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/ce5e198184df4f6aa36b65de6a54b2a4 : SUCCESS in 19m 46s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/e1df0707f7ef4d7eabfbbf9539860f49 : SUCCESS in 19m 04s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/d86a2ceeedfb4b9facf80328f53d52fc : SUCCESS in 7m 23s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/e54b9643513f4a398a3c224c52f94028 : SUCCESS in 24m 01s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/cd358236b1ef43fb9f1832e6e0b68da2 : SUCCESS in 45m 55s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/27054e008f8f48b88d4f4c1a31162976 : SUCCESS in 52m 04s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1f33a6976a2f4d4bb72ab38110887103 : SUCCESS in 38m 12s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/f4548d06365745ac96768d39cd29b848 : SUCCESS in 39m 53s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/af22b9fb19c0487b8fc0ca0e337894f5 : SUCCESS in 15m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5136c5824332451ea98776f6a679a655 : SUCCESS in 6m 52s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/3675c9f671844cfeac2b9529e7cb2313 : FAILURE in 12m 27s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/58a332f2105a41b499b856cba14ff4a2 : SUCCESS in 58m 35s","accounts_in_message":[],"_revision_number":3},{"id":"27fb77cc893a311574e91e426210463a1d35c89c","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-05 11:10:26.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"72955c11e92ca6f82e4869141dcaa37ae20336ef","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-03-08 17:00:17.000000000","message":"Patch Set 3: Workflow+1\n\neverything seems in order here - nice work Matt \u0026 Al!","accounts_in_message":[],"_revision_number":3},{"id":"baa1df5b2b00cfabff0724f439e1fbd326eebbca","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-08 23:30:27.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nAdding a +2 based on Clay\u0027s +A to get this to move to the gate","accounts_in_message":[],"_revision_number":3},{"id":"cc121d363bdd1a58c3a26b69e8385f7979347379","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-08 23:30:43.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"4b193f5c1f25405f51f6eb00e4d4d974ec6954a5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-09 01:14:12.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b7b7e1ec2b474066bba23a4a3cb9973a : SUCCESS in 8m 38s\n- grenade https://zuul.opendev.org/t/openstack/build/0dbf5a6f16c54be3ae585b01e4a2dccc : SUCCESS in 55m 18s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/257c90411cc9448489651fa35be70895 : SUCCESS in 40m 59s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/61307d7bff1b49c7975506d64fad93c3 : SUCCESS in 8m 46s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/43abb6beb3be4e83a2e800e0940696b9 : SUCCESS in 7m 30s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/03ea2c12827343ddada0530461f3a737 : SUCCESS in 15m 20s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/2751d6a9502043ff860cf69fda9e87be : SUCCESS in 18m 34s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/2560ec31a5a247179813e5468b51c382 : SUCCESS in 18m 03s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/7ea714f271d34431b278052a8d52c8d6 : SUCCESS in 18m 46s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/d6f6429de8fd459bb981a8daab2907de : SUCCESS in 19m 33s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/fd9aa8eecd5149d9b205907b235419b8 : SUCCESS in 20m 55s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/4b6c7b2294f14a94bcb64a576b9ca9ca : SUCCESS in 20m 42s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/02a6fca55a6d47eca9b43030d3ed69ec : SUCCESS in 21m 18s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/6fce893186dc49b8bd898a25d6f2bff0 : SUCCESS in 21m 09s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/6f18674de29a4bdf8243b1f576ee6c5b : SUCCESS in 21m 02s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/21a571283c504cc79aebd16de4a8ed7c : SUCCESS in 22m 18s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/905e543842674a42a736f5e95d9bfc4d : SUCCESS in 7m 40s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/9ee8ace8989d419f8d7164a5b0c1fa4f : SUCCESS in 50m 00s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/350035dd71e048f9af84756eccc7caac : SUCCESS in 49m 03s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/6c08946ddcad40fea6e1c4e9757b2d03 : SUCCESS in 48m 43s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8b95ae0637ee49079c7df09304c8189c : SUCCESS in 41m 27s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f8a141b66fc14327ac6f28a94291afe8 : SUCCESS in 16m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cbad74c3e157466a8858f608f9d14944 : SUCCESS in 5m 57s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6c6a287779764c2ebc18887f7e11f781 : SUCCESS in 1h 11m 39s","accounts_in_message":[],"_revision_number":3},{"id":"0781bfd20c9db89c1986a76405309779e868d781","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-09 01:14:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"bdd06fa5b11db59614a8f6e75599c96db4e5ead8","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-09 01:16:03.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cdb1f4371300401e9d8a70c2b69de761 : SUCCESS in 1m 09s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/75369e191fb444498a524ec05bbff7cf : SUCCESS in 44s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/105f1a6b70a844ba81067fc91ef23b76 : SUCCESS in 42s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4cd04b54fa5daa5344237b59dd090c660f236c4c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-19 05:53:51.000000000","message":"Patch Set 3:\n\n(3 comments)\n\nOh hey, I had some draft comments here...\n\nPushed up https://review.opendev.org/c/openstack/swift/+/781598 if we wanted to rewrite get_partition_for_hash a bit.","accounts_in_message":[],"_revision_number":3},{"id":"80af91b10644466ba092a674026a9d4f8dea74d9","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-19 09:44:50.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"419a8ae8acb25b95afddd9571b3715edc9b4cc6b","revisions":{"9d539b6f0f6c3c8407c0808a909cda6b4afdc3b8":{"kind":"REWORK","_number":1,"created":"2021-03-03 18:35:43.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/40/778540/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/40/778540/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/40/778540/1"}}},"commit":{"parents":[{"commit":"cdfa5b73ad64692e77a54839cff99a3c566d5717","subject":"Fix os.stat/os.link race in diskfile.relink_paths","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/cdfa5b73ad64692e77a54839cff99a3c566d5717"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-03 18:27:12.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-03 18:35:25.000000000","tz":0},"subject":"Add unit test for diskfile.relink_paths","message":"Add unit test for diskfile.relink_paths\n\nAdd a test for diskfile.relink_paths to cover the new\nobject dir existing but not being a dir.\n\nChange-Id: I5fbf8671f2ee63467d46f651e2c24529a2697626\nRelated-Change: Ia041f7b7dbd4e264072325b4b52718fef9966708\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9d539b6f0f6c3c8407c0808a909cda6b4afdc3b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9d539b6f0f6c3c8407c0808a909cda6b4afdc3b8"}]},"branch":"refs/heads/master"},"c134f967ba595116fbc6c0c2742d437abf775e1f":{"kind":"REWORK","_number":2,"created":"2021-03-04 16:48:08.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/40/778540/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/40/778540/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/40/778540/2"}}},"commit":{"parents":[{"commit":"08ee65d6e14818df853049b15a46451bb8d7c72e","subject":"Merge \"Fix race in diskfile.relink_paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/08ee65d6e14818df853049b15a46451bb8d7c72e"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-03 18:27:12.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-04 16:46:33.000000000","tz":0},"subject":"Add unit test for diskfile.relink_paths","message":"Add unit test for diskfile.relink_paths\n\nAdd unit tests for diskfile.relink_paths to cover the new\nobject dir existing but not being a dir.\n\nChange-Id: I5fbf8671f2ee63467d46f651e2c24529a2697626\nRelated-Change: Ia041f7b7dbd4e264072325b4b52718fef9966708\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c134f967ba595116fbc6c0c2742d437abf775e1f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c134f967ba595116fbc6c0c2742d437abf775e1f"}]},"branch":"refs/heads/master"},"419a8ae8acb25b95afddd9571b3715edc9b4cc6b":{"kind":"REWORK","_number":3,"created":"2021-03-05 06:01:46.000000000","uploader":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"ref":"refs/changes/40/778540/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/40/778540/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/40/778540/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/40/778540/3"}}},"commit":{"parents":[{"commit":"08ee65d6e14818df853049b15a46451bb8d7c72e","subject":"Merge \"Fix race in diskfile.relink_paths\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/08ee65d6e14818df853049b15a46451bb8d7c72e"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-03 18:27:12.000000000","tz":0},"committer":{"name":"Matthew Oliver","email":"matt@oliver.net.au","date":"2021-03-05 05:47:18.000000000","tz":660},"subject":"Add unit test for diskfile.relink_paths","message":"Add unit test for diskfile.relink_paths\n\nAdd unit tests for diskfile.relink_paths to cover the new\nobject dir existing but not being a dir.\n\nChange-Id: I5fbf8671f2ee63467d46f651e2c24529a2697626\nRelated-Change: Ia041f7b7dbd4e264072325b4b52718fef9966708\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/419a8ae8acb25b95afddd9571b3715edc9b4cc6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/419a8ae8acb25b95afddd9571b3715edc9b4cc6b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}