)]}'
{"swift/common/ring/ring.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"a67369dfeb9b313b788988b1bd49e72cb2720ca3","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        :param bool metadata_only: If True, only load `devs` and `part_shift`."},{"line_number":176,"context_line":"        :returns: A RingData instance containing the loaded data."},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        with contextlib.closing(RingReader(filename)) as gz_file:"},{"line_number":179,"context_line":"            # See if the file is in the new format"},{"line_number":180,"context_line":"            magic \u003d gz_file.read(4)"},{"line_number":181,"context_line":"            if magic \u003d\u003d b\u0027R1NG\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"008c90cb_8b34b730","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":31},"updated":"2021-03-10 19:24:57.000000000","message":"Should we just add __enter__/__exit__ methods to RingReader?","commit_id":"8492dc75a1a0f18b76c4c7644685bcadd5cae134"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"4f7f3817e09158af0ea9017c1460c9ea66061be2","unresolved":true,"context_lines":[{"line_number":175,"context_line":"        :param bool metadata_only: If True, only load `devs` and `part_shift`."},{"line_number":176,"context_line":"        :returns: A RingData instance containing the loaded data."},{"line_number":177,"context_line":"        \"\"\""},{"line_number":178,"context_line":"        with contextlib.closing(RingReader(filename)) as gz_file:"},{"line_number":179,"context_line":"            # See if the file is in the new format"},{"line_number":180,"context_line":"            magic \u003d gz_file.read(4)"},{"line_number":181,"context_line":"            if magic \u003d\u003d b\u0027R1NG\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f04a87f_68687b5f","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":31},"in_reply_to":"008c90cb_8b34b730","updated":"2021-03-10 22:38:13.000000000","message":"What\u0027s the upside over closing() alone?\n\nThe documentation for contextlib says that contextmanager() \"is a decorator that can be used to define a factory function for with statement context managers, without needing to create a class or separate __enter__() and __exit__() methods.\" Conversely, if you implement close(), shouldn\u0027t closing() be sufficient?","commit_id":"8492dc75a1a0f18b76c4c7644685bcadd5cae134"}]}