)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"751b9863e412d1f761b722233b09a9375f646d46","unresolved":true,"context_lines":[{"line_number":7,"context_line":"relinker: Add policy to relinker progress output"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The partition progress logging line currently includes device, step and"},{"line_number":10,"context_line":"the progress of partitions. But if your running a part-power increase on"},{"line_number":11,"context_line":"more then one policy at a time, then we\u0027re missing a crucial piece of"},{"line_number":12,"context_line":"information, the policy."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"19aad0b2_e573cd5f","line":10,"range":{"start_line":10,"start_character":34,"end_line":10,"end_character":39},"updated":"2021-03-19 15:00:18.000000000","message":"nit: s/your/you\u0027re/","commit_id":"e8c2771b1b55d0ad3b1bd1d381005cc19e5ea119"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"751b9863e412d1f761b722233b09a9375f646d46","unresolved":true,"context_lines":[{"line_number":11,"context_line":"more then one policy at a time, then we\u0027re missing a crucial piece of"},{"line_number":12,"context_line":"information, the policy."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch add the policy to the log line too:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Step: cleanup Device: sda1 Policy: \u003cpolicy name\u003e Partitions: 1/2"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"26a19932_bc08c5e8","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":14},"updated":"2021-03-19 15:00:18.000000000","message":"s/add/adds/","commit_id":"e8c2771b1b55d0ad3b1bd1d381005cc19e5ea119"}],"swift/cli/relinker.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"569fb0c143b2d2a793531231e0f424d740c1499c","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    recon_cache_dev \u003d {get_policy_string(\"progress\", policy): {"},{"line_number":216,"context_line":"        device: device_progress}}"},{"line_number":217,"context_line":"    dump_recon_cache(recon_cache_dev, conf[\u0027recon_cache\u0027], logger)"},{"line_number":218,"context_line":"    logger.info(\"Policy: %s Device: %s Step: %s Partitions: %d/%d\" % ("},{"line_number":219,"context_line":"        policy.name, device, step, num_parts_done, num_total_parts))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"decfc504_2f15138d","line":218,"updated":"2021-03-15 05:06:42.000000000","message":"Given how we currently organize work, I might\u0027ve gone for\n\n Step: v Device: w Policy: x Partitions: y/z\n\nbut w/e","commit_id":"8a73de7b9187c36d476b1cc5c91161259e44567e"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"dcc8a2c679b065a61bbe4d4514e037fbec2f7804","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    recon_cache_dev \u003d {get_policy_string(\"progress\", policy): {"},{"line_number":216,"context_line":"        device: device_progress}}"},{"line_number":217,"context_line":"    dump_recon_cache(recon_cache_dev, conf[\u0027recon_cache\u0027], logger)"},{"line_number":218,"context_line":"    logger.info(\"Policy: %s Device: %s Step: %s Partitions: %d/%d\" % ("},{"line_number":219,"context_line":"        policy.name, device, step, num_parts_done, num_total_parts))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c573b023_bd44c15e","line":218,"in_reply_to":"decfc504_2f15138d","updated":"2021-03-15 05:17:16.000000000","message":"yeah, which ever order we want is fine by me. My thought was you\u0027d want to first look for the policy, then which device, then what step it\u0027s up too.\n\nBut now when I actually put more thought in to how we run it, I see that Step might be useful first case because we do run 1 step at a time. And I guess a device does cover multiple policies.. so yup happy either way 😊\n\nI just want the data!\n\nFeel free to swap the order while I sleep if you want need to get it in the release :)","commit_id":"8a73de7b9187c36d476b1cc5c91161259e44567e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"751b9863e412d1f761b722233b09a9375f646d46","unresolved":true,"context_lines":[{"line_number":216,"context_line":"        device: device_progress}}"},{"line_number":217,"context_line":"    dump_recon_cache(recon_cache_dev, conf[\u0027recon_cache\u0027], logger)"},{"line_number":218,"context_line":"    logger.info(\"Step: %s Device: %s Policy: %s Partitions: %d/%d\" % ("},{"line_number":219,"context_line":"        step, device, policy.name, num_parts_done, num_total_parts))"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"def hashes_filter(devices, next_part_power, suff_path, hashes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"2027acbb_e58788b6","line":219,"range":{"start_line":219,"start_character":22,"end_line":219,"end_character":33},"updated":"2021-03-19 15:00:18.000000000","message":"might be worth including name and index e.g.\n\nPolicy: 0 (gold)\n\nover here I add a --policy option that will only accept index so would be more consistent to also report index","commit_id":"e8c2771b1b55d0ad3b1bd1d381005cc19e5ea119"}]}