)]}'
{"id":"openstack%2Fswift~780939","triplet_id":"openstack%2Fswift~master~Ic099fdc3925bf99f8528c7aa763b651c19df1322","project":"openstack/swift","branch":"master","topic":"p-syslog-handler","hashtags":[],"change_id":"Ic099fdc3925bf99f8528c7aa763b651c19df1322","subject":"py36: Fix syslog fallback to UDP","status":"MERGED","created":"2021-03-16 17:57:47.000000000","updated":"2021-03-17 00:19:58.000000000","submitted":"2021-03-17 00:18:25.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"780939-p-syslog-handler","meta_rev_id":"cc06dcb19581c7faa85ce0defbccf10111421e6c","_number":780939,"virtual_id_number":780939,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-17 00:18:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-03-16 22:26:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-03-16 22:26:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-16 19:26:30.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-16 22:26:44.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"8064eee49f55eb4a33e5c44ee57e009b48e4ea47","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-16 17:57:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4b04580d3b7a1d9fd685387988e84472763b04eb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 19:26:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7822eee656c14d65ac7a532bd2f147a3 : SUCCESS in 8m 43s\n- grenade https://zuul.opendev.org/t/openstack/build/d604b9682ca8420f9537609d524905b7 : SUCCESS in 1h 17m 45s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/600c43102150434cb42906c90a0c9a73 : SUCCESS in 52m 17s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/2844e2feb2d74974a2654d79edb02b04 : SUCCESS in 10m 33s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/1e9a064f39734f34904c1dc3ab944e68 : SUCCESS in 7m 23s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/1b30d8db814e4381bd93d5affd321969 : SUCCESS in 20m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/ab0ddc3f78fa4123b78626e884e0d5f5 : SUCCESS in 19m 38s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/01e7a43ff6f14622a7ce4b4ffb72c97b : SUCCESS in 17m 19s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/d02aa2c9d2f044d6832c15d8dcc8927d : SUCCESS in 15m 53s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/636943c8ef8f4683a33d496bf8af9e56 : SUCCESS in 20m 41s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/97c3fb7a157e4a8fbe96ad88b3d1e590 : SUCCESS in 16m 36s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/0819ce9a36bf40ccace9298b8a19945f : SUCCESS in 21m 24s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/2c2aded7963849e5983461ee38f7fd5d : SUCCESS in 22m 17s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/a4d1a7b683f945e7a581614a281fad94 : SUCCESS in 17m 59s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/2db9a4ca02bd4fd99797445c042d0917 : SUCCESS in 25m 19s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/8551ec1f08d14bdd9b94cac457fbac84 : SUCCESS in 24m 31s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/6e21b99e7aca4d5dbfda0190011fcfbe : SUCCESS in 9m 26s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/bfad865b746146aba36a3f4ee8a3caea : SUCCESS in 25m 03s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/1834b14112bf48739660b5e208114260 : SUCCESS in 53m 20s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/cc45b55911e14893ab9c120c6fbe398b : SUCCESS in 52m 08s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/1f2c5529cab64aaf9344ba86a32e3981 : SUCCESS in 50m 22s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5b14a6979b56439080f67343eeee2fb3 : SUCCESS in 43m 13s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/56631e97928e497bb39a761d78551f46 : SUCCESS in 17m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/92621b55af2f42c28bc564184496a4b4 : SUCCESS in 5m 31s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/dce79d1621fe498abb6465b7b4830c3e : FAILURE in 12m 27s (non-voting)\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/065a8cc7c1894ed5ac07a07aec044154 : SUCCESS in 1h 01m 48s","accounts_in_message":[],"_revision_number":1},{"id":"79f9cd2d4275908aaeaa3a79c25ae8cb25dd8bd5","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-16 22:26:44.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"f206813c3a44e6f1b67212fe62fe948e13695ec9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-16 22:27:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f3466d35e60af68f9dfcd32c7f8706b9d7d6c08b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 00:18:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4e3b90b6c5694806a16a36db18d77b5c : SUCCESS in 10m 28s\n- grenade https://zuul.opendev.org/t/openstack/build/82ed5e08e5274cd3bb223bf3165b50e4 : SUCCESS in 57m 31s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/fecf591283894dc88ff1b1af475dbdd7 : SUCCESS in 41m 36s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/aff17ced01ff4e2ba051505e2a1216b7 : SUCCESS in 9m 30s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/a71b689a5920494681ee827785c861f5 : SUCCESS in 7m 59s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/a92eac4a59e048afb6b8e5917d55da92 : SUCCESS in 14m 15s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/d19f37134a854e2f9c69dc96094324dd : SUCCESS in 22m 24s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/8e71bdc5c5b54b00899ff88cdf0afa16 : SUCCESS in 20m 32s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/ebcf021420cd4cc7bb002ca009876069 : SUCCESS in 13m 33s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/1043f2d862744b8391fde82222744e0c : SUCCESS in 24m 54s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/51234def38094a59b36e357ae3805795 : SUCCESS in 34m 28s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/2e92c218e62546dc8b6f6ee2b01d95cf : SUCCESS in 22m 22s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/15ae92d3d715438f8dcdbfb1a87eb6ce : SUCCESS in 23m 20s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c2b161ba2f884aff8344fce315ca685c : SUCCESS in 28m 53s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/45f365fdeb0242f8a45fa590d3641369 : SUCCESS in 17m 51s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/3272b4a3577b4f4591d50365d0a2c7ff : SUCCESS in 23m 46s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/b4b8b4cb68234a7a8961f3d931f975ad : SUCCESS in 6m 18s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/5d9efd35f38d475dabd59949f71720f2 : SUCCESS in 48m 33s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/291d3d3e63a74d538bcae9832ac2e8a2 : SUCCESS in 48m 20s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ad9ac35e98d34b47870facafc2eb8a01 : SUCCESS in 35m 29s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/74ee1bc45dc94a5d8189426904a9326d : SUCCESS in 40m 53s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ea3765c343c0438ab61dcada08ff7980 : SUCCESS in 15m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ffd33ff3edcf4bf780fbff0fe0c94e84 : SUCCESS in 6m 07s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f3ba046125f44f918f212659a8d15b73 : SUCCESS in 58m 44s","accounts_in_message":[],"_revision_number":1},{"id":"308c5c231df0e106f00afa8839632b38baacfc7c","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 00:18:25.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"cc06dcb19581c7faa85ce0defbccf10111421e6c","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 00:19:58.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/03be49d25be846aba14baf30927682c1 : SUCCESS in 1m 02s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/b911273e7d044429bd2179cb43b1bdce : SUCCESS in 42s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/442b1f36ee27425d80decd2e6fc5e81e : SUCCESS in 39s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c7d56fa9c57a18473da166254c01f4abc44c7ee3","revisions":{"c7d56fa9c57a18473da166254c01f4abc44c7ee3":{"kind":"REWORK","_number":1,"created":"2021-03-16 17:57:47.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/39/780939/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/39/780939/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/39/780939/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/39/780939/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/39/780939/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/39/780939/1"}}},"commit":{"parents":[{"commit":"310298a9484c1fb304e77c5d8e3214002a637c3d","subject":"Merge \"s3api: Allow CORS preflight requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/310298a9484c1fb304e77c5d8e3214002a637c3d"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-16 16:07:12.000000000","tz":0},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-16 17:57:37.000000000","tz":0},"subject":"py36: Fix syslog fallback to UDP","message":"py36: Fix syslog fallback to UDP\n\nWith py2 the SysLogHandler would raise an error if it could not\nconnect to the configured log_address socket. This prompted the\nutils.get_logger() method to fallback to using UDP. With py3 an error\nis not raised [1], so the fallback never happens. In that scenario,\nexceptions are raised when swift services are started and attempt to\nlog.\n\nThis patch modifies get_logger() to test if the log_address is a socket\nbefore instantiating a SysLogHandler and fallback to UDP if not a socket.\n\n[1] https://github.com/python/cpython/blob/master/Lib/logging/handlers.py#L833-L842\n\nChange-Id: Ic099fdc3925bf99f8528c7aa763b651c19df1322\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c7d56fa9c57a18473da166254c01f4abc44c7ee3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c7d56fa9c57a18473da166254c01f4abc44c7ee3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}