)]}'
{"swift/cli/manage_shard_ranges.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ffcd2b52a6fc89ed9fd982253a0822c1838eb810","unresolved":true,"context_lines":[{"line_number":723,"context_line":"    parser.add_argument("},{"line_number":724,"context_line":"        \u0027--yes\u0027, \u0027-y\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":725,"context_line":"        help\u003d\u0027Apply shard range changes to broker without prompting.\u0027"},{"line_number":726,"context_line":"             \u0027Cannot be used with --dry-run option\u0027)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"def _add_dry_run_arg(parser):"}],"source_content_type":"text/x-python","patch_set":3,"id":"0396f278_2eed5449","line":726,"updated":"2021-04-06 21:37:00.000000000","message":"Needs a space after the period.","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"22daabb861f3bb99f07f1b39364a5216833fade6","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    parser.add_argument("},{"line_number":724,"context_line":"        \u0027--yes\u0027, \u0027-y\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":725,"context_line":"        help\u003d\u0027Apply shard range changes to broker without prompting.\u0027"},{"line_number":726,"context_line":"             \u0027Cannot be used with --dry-run option\u0027)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":""},{"line_number":729,"context_line":"def _add_dry_run_arg(parser):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3dee8a3c_25ca5148","line":726,"in_reply_to":"0396f278_2eed5449","updated":"2021-04-07 09:06:01.000000000","message":"Done","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ffcd2b52a6fc89ed9fd982253a0822c1838eb810","unresolved":true,"context_lines":[{"line_number":730,"context_line":"    parser.add_argument("},{"line_number":731,"context_line":"        \u0027--dry-run\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":732,"context_line":"        help\u003d\u0027Do not apply any shard range changes to broker.\u0027"},{"line_number":733,"context_line":"             \u0027Cannot be used with --yes option.\u0027)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"def _make_parser():"}],"source_content_type":"text/x-python","patch_set":3,"id":"12552794_bfd72a1f","line":733,"updated":"2021-04-06 21:37:00.000000000","message":"ditto","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"22daabb861f3bb99f07f1b39364a5216833fade6","unresolved":false,"context_lines":[{"line_number":730,"context_line":"    parser.add_argument("},{"line_number":731,"context_line":"        \u0027--dry-run\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":732,"context_line":"        help\u003d\u0027Do not apply any shard range changes to broker.\u0027"},{"line_number":733,"context_line":"             \u0027Cannot be used with --yes option.\u0027)"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":""},{"line_number":736,"context_line":"def _make_parser():"}],"source_content_type":"text/x-python","patch_set":3,"id":"b323f9ff_cf07cadc","line":733,"in_reply_to":"12552794_bfd72a1f","updated":"2021-04-07 09:06:01.000000000","message":"Done","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"ffcd2b52a6fc89ed9fd982253a0822c1838eb810","unresolved":true,"context_lines":[{"line_number":861,"context_line":"        help\u003d\u0027Repair overlapping shard ranges. No action will be taken \u0027"},{"line_number":862,"context_line":"             \u0027without user confirmation unless the -y option is used.\u0027)"},{"line_number":863,"context_line":"    _add_yes_arg(repair_parser)"},{"line_number":864,"context_line":"    _add_dry_run_arg(repair_parser)"},{"line_number":865,"context_line":"    repair_parser.set_defaults(func\u003drepair_shard_ranges)"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    # analyze"}],"source_content_type":"text/x-python","patch_set":3,"id":"a9e61a95_e7e25e58","line":864,"updated":"2021-04-06 21:37:00.000000000","message":"Seems like we always do _add_dry_run_arg() when we do _add_yes_arg() -- should we combine them into some _add_prompt_args()?","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"22daabb861f3bb99f07f1b39364a5216833fade6","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        help\u003d\u0027Repair overlapping shard ranges. No action will be taken \u0027"},{"line_number":862,"context_line":"             \u0027without user confirmation unless the -y option is used.\u0027)"},{"line_number":863,"context_line":"    _add_yes_arg(repair_parser)"},{"line_number":864,"context_line":"    _add_dry_run_arg(repair_parser)"},{"line_number":865,"context_line":"    repair_parser.set_defaults(func\u003drepair_shard_ranges)"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":"    # analyze"}],"source_content_type":"text/x-python","patch_set":3,"id":"2ed9ceb4_642e93cc","line":864,"in_reply_to":"a9e61a95_e7e25e58","updated":"2021-04-07 09:06:01.000000000","message":"Done","commit_id":"147180688290915d0698a5f35cc830c471487c22"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"dc130e163ac93bcf33f074d0fddea91595db96d9","unresolved":true,"context_lines":[{"line_number":723,"context_line":"    parser.add_argument("},{"line_number":724,"context_line":"        \u0027--yes\u0027, \u0027-y\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":725,"context_line":"        help\u003d\u0027Apply shard range changes to broker without prompting. \u0027"},{"line_number":726,"context_line":"             \u0027Cannot be used with --dry-run option\u0027)"},{"line_number":727,"context_line":"    parser.add_argument("},{"line_number":728,"context_line":"        \u0027--dry-run\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":729,"context_line":"        help\u003d\u0027Do not apply any shard range changes to broker. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"723d9fe5_8425acd1","line":726,"updated":"2021-04-07 19:30:34.000000000","message":"nit: Should this get a period at the end, like --dry-run?","commit_id":"90ad2329868d1bf14189004711e9288ed81ce193"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4b88a50157edfe38d2cd6b9d0d1bf2fa6477800f","unresolved":false,"context_lines":[{"line_number":723,"context_line":"    parser.add_argument("},{"line_number":724,"context_line":"        \u0027--yes\u0027, \u0027-y\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":725,"context_line":"        help\u003d\u0027Apply shard range changes to broker without prompting. \u0027"},{"line_number":726,"context_line":"             \u0027Cannot be used with --dry-run option\u0027)"},{"line_number":727,"context_line":"    parser.add_argument("},{"line_number":728,"context_line":"        \u0027--dry-run\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":729,"context_line":"        help\u003d\u0027Do not apply any shard range changes to broker. \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"50b33e3b_30e7199a","line":726,"in_reply_to":"723d9fe5_8425acd1","updated":"2021-04-09 11:45:01.000000000","message":"Done","commit_id":"90ad2329868d1bf14189004711e9288ed81ce193"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"dc130e163ac93bcf33f074d0fddea91595db96d9","unresolved":true,"context_lines":[{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    if getattr(args, \u0027yes\u0027, False) and getattr(args, \u0027dry_run\u0027, False):"},{"line_number":886,"context_line":"        print(\u0027--yes and --dry-run cannot both be set.\u0027, file\u003dsys.stderr)"},{"line_number":887,"context_line":"        return 2"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    conf \u003d {}"},{"line_number":890,"context_line":"    rows_per_shard \u003d DEFAULT_ROWS_PER_SHARD"}],"source_content_type":"text/x-python","patch_set":4,"id":"d1e769a8_4abdf618","line":887,"updated":"2021-04-07 19:30:34.000000000","message":"Why 2 vs 1?\n\nShould we define some EXIT_SUCCESS, EXIT_ERROR, etc. constants at the top?","commit_id":"90ad2329868d1bf14189004711e9288ed81ce193"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"4b88a50157edfe38d2cd6b9d0d1bf2fa6477800f","unresolved":true,"context_lines":[{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    if getattr(args, \u0027yes\u0027, False) and getattr(args, \u0027dry_run\u0027, False):"},{"line_number":886,"context_line":"        print(\u0027--yes and --dry-run cannot both be set.\u0027, file\u003dsys.stderr)"},{"line_number":887,"context_line":"        return 2"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"    conf \u003d {}"},{"line_number":890,"context_line":"    rows_per_shard \u003d DEFAULT_ROWS_PER_SHARD"}],"source_content_type":"text/x-python","patch_set":4,"id":"abeb1296_2add84a9","line":887,"in_reply_to":"d1e769a8_4abdf618","updated":"2021-04-09 11:45:01.000000000","message":"2 is consistent with the exit code from argparse if it finds invalid args so it seemed useful to make these the same","commit_id":"90ad2329868d1bf14189004711e9288ed81ce193"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b31ae2ef935b2ca4d9d485fe6840669156a97aa","unresolved":true,"context_lines":[{"line_number":733,"context_line":"    parser.add_argument("},{"line_number":734,"context_line":"        \u0027--dry-run\u0027, \u0027-n\u0027, action\u003d\u0027store_true\u0027, default\u003dFalse,"},{"line_number":735,"context_line":"        help\u003d\u0027Do not apply any shard range changes to broker. \u0027"},{"line_number":736,"context_line":"             \u0027Cannot be used with --yes option.\u0027)"},{"line_number":737,"context_line":""},{"line_number":738,"context_line":""},{"line_number":739,"context_line":"def _make_parser():"}],"source_content_type":"text/x-python","patch_set":7,"id":"666d90b6_1d6f8d40","line":736,"updated":"2021-05-13 18:47:48.000000000","message":"are we using argparse?\n\nhttps://docs.python.org/3/library/argparse.html#mutual-exclusion","commit_id":"568036f1b74e1057462401492ed323958d9d8ff5"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b31ae2ef935b2ca4d9d485fe6840669156a97aa","unresolved":true,"context_lines":[{"line_number":890,"context_line":""},{"line_number":891,"context_line":"    if getattr(args, \u0027yes\u0027, False) and getattr(args, \u0027dry_run\u0027, False):"},{"line_number":892,"context_line":"        print(\u0027--yes and --dry-run cannot both be set.\u0027, file\u003dsys.stderr)"},{"line_number":893,"context_line":"        return EXIT_INVALID_ARGS"},{"line_number":894,"context_line":""},{"line_number":895,"context_line":"    conf \u003d {}"},{"line_number":896,"context_line":"    rows_per_shard \u003d DEFAULT_ROWS_PER_SHARD"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ecc4522_1e49134d","line":893,"updated":"2021-05-13 18:47:48.000000000","message":"oic","commit_id":"568036f1b74e1057462401492ed323958d9d8ff5"}],"test/unit/cli/test_manage_shard_ranges.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"4b31ae2ef935b2ca4d9d485fe6840669156a97aa","unresolved":true,"context_lines":[{"line_number":1779,"context_line":"            ret \u003d main([\u0027db file\u0027, \u0027repair\u0027, \u0027--dry-run\u0027, \u0027--yes\u0027])"},{"line_number":1780,"context_line":"        self.assertEqual(2, ret)"},{"line_number":1781,"context_line":"        err_lines \u003d err.getvalue().split(\u0027\\n\u0027)"},{"line_number":1782,"context_line":"        self.assertIn(\u0027--yes and --dry-run cannot both be set.\u0027, err_lines)"}],"source_content_type":"text/x-python","patch_set":7,"id":"b21ddec7_f177e9c8","line":1782,"updated":"2021-05-13 18:47:48.000000000","message":"oh, where is this coming from?","commit_id":"568036f1b74e1057462401492ed323958d9d8ff5"}]}