)]}'
{"test/unit/cli/test_relinker.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"8dd77948aefdf1eaf34aefeeec55a5ca1eb4d55e","unresolved":true,"context_lines":[{"line_number":1134,"context_line":"                           ((\u0027ts\u0027, 2),))"},{"line_number":1135,"context_line":"        info_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"},{"line_number":1136,"context_line":"        self.assertIn(\u00271 hash dirs processed (cleanup\u003dTrue) \u0027"},{"line_number":1137,"context_line":"                      \u0027(1 files, 1 linked, 1 removed, 0 errors)\u0027,"},{"line_number":1138,"context_line":"                      info_lines)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"    def test_cleanup_missing_data_missing_ts_missing_meta_files(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5bf9e178_8f63553d","line":1137,"range":{"start_line":1137,"start_character":43,"end_line":1137,"end_character":52},"updated":"2021-03-22 20:20:02.000000000","message":"This logging feels a little weird -- test makes it clear that we unlinked 3. Can see it in some of the others, too...","commit_id":"76feb65cbcf8fed42caecb8560c62d39f18f12f6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e090aa6a0b5ca1884f962abaf8c8bbe722a0f3a5","unresolved":true,"context_lines":[{"line_number":1134,"context_line":"                           ((\u0027ts\u0027, 2),))"},{"line_number":1135,"context_line":"        info_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"},{"line_number":1136,"context_line":"        self.assertIn(\u00271 hash dirs processed (cleanup\u003dTrue) \u0027"},{"line_number":1137,"context_line":"                      \u0027(1 files, 1 linked, 1 removed, 0 errors)\u0027,"},{"line_number":1138,"context_line":"                      info_lines)"},{"line_number":1139,"context_line":""},{"line_number":1140,"context_line":"    def test_cleanup_missing_data_missing_ts_missing_meta_files(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c751bf9_c6882c07","line":1137,"range":{"start_line":1137,"start_character":43,"end_line":1137,"end_character":52},"in_reply_to":"5bf9e178_8f63553d","updated":"2021-03-23 10:39:18.000000000","message":"I agree, although the logging is more informative it might also be improved further.\n\nThese anomalies are because the cleanup_ondisk_files used to retrieve file set for old and new will clean up obsolete files, so in this case the data and meta files are removed before the relinker code even gets its hands on file sets.\n\n\u0027files\u0027 needs to be read as \u0027required files\u0027","commit_id":"76feb65cbcf8fed42caecb8560c62d39f18f12f6"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"e090aa6a0b5ca1884f962abaf8c8bbe722a0f3a5","unresolved":true,"context_lines":[{"line_number":1190,"context_line":"        info_lines \u003d self.logger.get_lines_for_level(\u0027info\u0027)"},{"line_number":1191,"context_line":"        self.assertIn(\u00271 hash dirs processed (cleanup\u003dTrue) \u0027"},{"line_number":1192,"context_line":"                      \u0027(1 files, 1 linked, 2 removed, 0 errors)\u0027,"},{"line_number":1193,"context_line":"                      info_lines)"},{"line_number":1194,"context_line":""},{"line_number":1195,"context_line":"    def test_cleanup_missing_data_missing_meta_existing_older_meta_files(self):"},{"line_number":1196,"context_line":"        self._cleanup_test(((\u0027data\u0027, 0), (\u0027meta\u0027, 2)),"}],"source_content_type":"text/x-python","patch_set":3,"id":"924db38d_63583c57","line":1193,"updated":"2021-03-23 10:39:18.000000000","message":"this one looks odd too... 1 required file, but 2 removed, because only 1 of the old files is required but old has 2 self-consistent files.","commit_id":"76feb65cbcf8fed42caecb8560c62d39f18f12f6"}]}