)]}'
{"id":"openstack%2Fswift~781908","triplet_id":"openstack%2Fswift~master~I9aace80088cd00d02c418fe4d782b662fb5c8bcf","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I9aace80088cd00d02c418fe4d782b662fb5c8bcf","subject":"diskfile: Prevent get_hashes from creating missing partition dirs","status":"MERGED","created":"2021-03-19 20:35:00.000000000","updated":"2021-03-30 11:13:40.000000000","submitted":"2021-03-30 11:11:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":38,"unresolved_comment_count":19,"has_review_started":true,"submission_id":"781908","meta_rev_id":"873879d0059c0b03a9ce7b096f430c96c0fbc0d3","_number":781908,"virtual_id_number":781908,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-30 11:10:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":0,"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":2,"date":"2021-03-29 18:38:18.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"value":1,"date":"2021-03-30 10:05:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"}],"REVIEWER":[{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-19 21:46:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-03-24 16:38:47.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"CC"},{"updated":"2021-03-25 04:34:12.000000000","updated_by":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"reviewer":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"state":"CC"},{"updated":"2021-03-25 04:48:49.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"CC"},{"updated":"2021-03-25 12:44:42.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"},{"updated":"2021-03-25 21:28:28.000000000","updated_by":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"reviewer":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"state":"REVIEWER"}],"messages":[{"id":"7a395a322b32c0dd0da42670853f18fd846f2053","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-19 20:35:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5c63452f41f0324e2838a509eda92be02a046360","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-19 20:42:49.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nIt was bugging me that running the relinker could go create a bunch of nearly-empty partitions in the new, upper half just because we called get_hashes.\n\nNote that it\u0027d only really affect low-density storage policies where a new partition might not actually have any objects in it (so, dev/test).","accounts_in_message":[],"_revision_number":1},{"id":"b68cff961c68c8ff0ce5f96a4cc4c2d30d14a877","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-19 21:46:29.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3f38e2b1d9f94d76be25251bc19e6bf3 : SUCCESS in 9m 36s\n- grenade https://zuul.opendev.org/t/openstack/build/fe8bab6d29234141bb4f462ce495d77d : SUCCESS in 57m 18s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/57cf916d0b8e4391a275877cfe48cb32 : SUCCESS in 37m 30s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/353e0be3fa494a84a9603bc36597273d : SUCCESS in 7m 57s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/2f0b86b90c3f4c4eba439e2de5632cde : SUCCESS in 6m 13s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/5b588455c72941e8b4dca1ea0ea36122 : SUCCESS in 22m 43s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/b1f18cb34cd94c928868f40db57f74e6 : SUCCESS in 15m 12s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/9a57853399a34feb918a59994d458209 : SUCCESS in 16m 54s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/f8ef0634fcb44053b0c2908b2e0aa3aa : SUCCESS in 15m 18s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/e3ea842dd25047e18656219c7a56916b : SUCCESS in 15m 06s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7f8e748fefe741b39b21066911efc23a : SUCCESS in 27m 27s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/fdc621043bcb44ab9e072b43a00d4344 : SUCCESS in 24m 30s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/eb314d4e5291472ca7135a0de86dce3a : SUCCESS in 22m 24s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/aff5afe489104c1e8011f75a04246f59 : SUCCESS in 22m 39s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/f2c768c12847464da70f84839812a044 : SUCCESS in 19m 26s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/2d01612cf99e4d1199465d1808cac544 : SUCCESS in 18m 56s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/c91162e837bd48f3a294e3f376832f28 : SUCCESS in 9m 08s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/0a02fcc6dd484b6f95e4757bc2859a03 : SUCCESS in 25m 07s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/77b42c2e9e3944bbaa25e5b7374b9528 : SUCCESS in 48m 19s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/cc29ca450e9c41f79307b9efbafe92f0 : SUCCESS in 46m 45s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/6c9126315e5b4dd2a50ae902bf39e50b : SUCCESS in 37m 33s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/af46a39b397248449e1287d9ffc97cad : SUCCESS in 39m 35s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/31f131660ce6406c969a82bf1e4d59a6 : SUCCESS in 15m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d4edc067a8a24efbaac923558d9af544 : SUCCESS in 6m 48s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/752101a1888345a68ff65c0771111c4e : SUCCESS in 24m 34s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/29ddf4754af74fa88a37d5bbc42b0531 : SUCCESS in 1h 05m 42s","accounts_in_message":[],"_revision_number":1},{"id":"68892e7def0dada6696e9dcef6cd2bab0d024b06","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-20 05:09:42.000000000","message":"Patch Set 1:\n\nOh! Actually, it affects prod clusters, too, if you\u0027re running the relinker multiple times:\n\n* First relinking, a partition in the first quartile gets relinked into the second. No rehashing is done, since it should be covered by cleanup.\n* Second relinking, the new part in the second quartile gets checked. None of the hashes need to be relinked, but we still rehash in the upper half of the new partition space just in case!","accounts_in_message":[],"_revision_number":1},{"id":"139fb15f41f315ddb32142a8ab3e802a3255d686","author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"date":"2021-03-25 04:34:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"59a8a577b8ec0ee2fa5b7e1bd488b32846b7cb32","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-03-25 04:48:49.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"72beade690e82c1fa5792c395a8534f647364534","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 05:16:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7f41053982a2dbe40b51b03946876a592bf93ee1","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-25 12:44:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nI\u0027m wary of some of the test changes. Also curious about where the change is made.","accounts_in_message":[],"_revision_number":1},{"id":"66a183cf838725a33be447161dcabab767970949","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 20:02:10.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"bda6d4a672bbbc0da78e23029e995fbb20f2104e","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 20:08:20.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"55539ca9ebb516c81609a3f6e11b70e24f063b64","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 20:35:41.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"dcbe7c5a19022b026e6fb2b9852ba90466aea64f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 20:54:34.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f4bbe1f2493ca2cc035b6fe76cc8e17391187038","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-03-25 21:28:28.000000000","message":"Patch Set 4: Code-Review+2\n\nAs expected of Alistair.","accounts_in_message":[],"_revision_number":4},{"id":"181e5dfb67a625beeb5679302506777442fdd1bf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-25 22:01:24.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b4a575e7adb1488db5fa40edeeca48bd : SUCCESS in 12m 36s\n- grenade https://zuul.opendev.org/t/openstack/build/076a224872f24980a86554522c1e3885 : SUCCESS in 1h 04m 20s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/b404675ede4f4c62b52669bba15c2ef4 : SUCCESS in 38m 47s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/bfaeb90604884f31ad4585d356223b6d : SUCCESS in 8m 30s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/1fe9b67d962b4b03aa18d79777c0fc92 : SUCCESS in 7m 58s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/e977e9d59eed4b129a8a21524d21b511 : SUCCESS in 29m 36s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/4add088f50e948d8a5717b8acd27985b : SUCCESS in 29m 54s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/2cc85f6594014c88b77a51f81d7a3bb6 : SUCCESS in 25m 04s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/1d722ad9d4064135a69c4c7a9e47af27 : SUCCESS in 15m 04s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/ed72cc057b7846ca84bb8c00d97e601c : SUCCESS in 21m 39s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/0e1fa55a72334bc489c70f91725cbf48 : SUCCESS in 21m 08s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/a2cb6e84441743d89f21323db94abad6 : SUCCESS in 24m 38s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/5ec36b59647d43e0b4d9f9c043862a8b : SUCCESS in 19m 13s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/22baf7e3368943e599dc17aed134cc76 : SUCCESS in 34m 19s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/22e3dde4390c4798addb5aabd2f93382 : SUCCESS in 19m 00s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/bd9a6ceeb066491ebba89fb56edac7ff : SUCCESS in 35m 48s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/8705e730a91a4241a1823b4c5eb0f6ea : SUCCESS in 7m 41s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/e43bebdeb05346b89b513a9a152fd418 : FAILURE in 39m 43s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/aa642874bbbf486ab8627ccb6dd96c98 : SUCCESS in 47m 08s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/97deb9b637d7484aae89ad07d45bde59 : SUCCESS in 1h 00m 03s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/780be4fe42954b8d9ed6b5f643f69c63 : SUCCESS in 40m 59s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/d9ae133d124244b5ac735c1952cb7866 : SUCCESS in 27m 20s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b0732112c799416788fd2e97db81eaa8 : SUCCESS in 14m 53s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9f2775bdc5bc40929f7248cbbdb69218 : SUCCESS in 6m 16s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/30f6f16980c948879fbccd441504b100 : FAILURE in 28m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/a3c30ee39989475bb660f78f7b5b0275 : SUCCESS in 50m 45s","accounts_in_message":[],"_revision_number":4},{"id":"8bede6f73e6a0f44ad16ef19678826f2303688bb","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-25 22:23:52.000000000","message":"Patch Set 4:\n\nrecheck","accounts_in_message":[],"_revision_number":4},{"id":"21954233c248920bd366853f84fd98143ac0ad9f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 00:07:59.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5b8f6674b0fb48f698f99e6d3635d765 : SUCCESS in 9m 33s\n- grenade https://zuul.opendev.org/t/openstack/build/00cf737d777f40e3a48dea61e3e4cb73 : SUCCESS in 1h 41m 15s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/263752fa98be4b4181a3bdd338fcd9ad : SUCCESS in 37m 54s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/52d0c41756234812bfa3600825e122a1 : SUCCESS in 12m 15s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/ca4686411e4342749004aae40074f363 : SUCCESS in 5m 56s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/09bda26d5de6413881accebc5aa3c546 : SUCCESS in 27m 16s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/7e78234076934f09be16a613a702123e : SUCCESS in 18m 39s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/ed607fde869e48bd9b28a3da11de8273 : SUCCESS in 28m 33s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/a72c7503efb7434a959b7992ba643dce : SUCCESS in 14m 05s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/676cfb06e81a41aaa02ee434ac214251 : SUCCESS in 30m 11s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/504257e26649496eb9906f734e2d6c49 : SUCCESS in 16m 48s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/4960e58bffc743789c13fd5f02d08bca : SUCCESS in 17m 59s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/213348c65d2d41c6a5b765d67bc16d13 : SUCCESS in 21m 53s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/b48e542ba45740fe804672a87bbb4d2d : SUCCESS in 39m 35s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/a1533c4d7d2b40c6afac09951da5b481 : SUCCESS in 21m 57s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/d210ba46cb0541b3b1c4b31ebcef8582 : SUCCESS in 16m 19s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/1be76adbfbb34eeb9f7ee7adb2f5ecb3 : SUCCESS in 6m 24s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/7490d9674b034f539d138432fbd70d11 : FAILURE in 22m 55s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/b39562ac690b469c9169b254a5c02c49 : SUCCESS in 55m 33s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/4e9e2ea5d7874893a91eb8de2ce606dd : SUCCESS in 50m 40s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f61374e31b914b648a48ab14d476dca4 : SUCCESS in 31m 34s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5617129710004f1cb4799ce36be1dce6 : SUCCESS in 41m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/51a3050c2d5748cdb43df63a7a02f541 : SUCCESS in 17m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/df42c35d106d46df8d0b97663dbfc8ee : SUCCESS in 6m 19s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/730f57103a7741219c63fc16c8863ba6 : SUCCESS in 20m 15s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/136705d26c504336899de64331cb0a70 : SUCCESS in 1h 08m 50s","accounts_in_message":[],"_revision_number":4},{"id":"455dea083679bafa66a09645d0e23f750d523575","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-26 12:24:48.000000000","message":"Patch Set 4: Code-Review-1\n\n(7 comments)\n\nI think the solution is better, but there\u0027s still some unit tests that assumed get_hashes would create a partition dir and empty hashes.pkl so -1 I\u0027m afraid.\n\nI found a few and fixed here https://review.opendev.org/c/openstack/swift/+/783292\n\nIn that follow-up I added a create_partition arg: partly because it felt less tedious, and less prone to regression, than calling mkdirs in ever place we want get_hashes to create the .pkl, and partly because it feels that the dir creation has been an assumed side-effect of get_hashes and it might be a helpful reminder to future-us to see that create_partition\u003dFalse arg. IDK, open to debate 😊\n\nI also had a go at rewriting the conditions in get_hashes in https://review.opendev.org/c/openstack/swift/+/783292, but that\u0027s just tinkering - I found all the not\u0027s and Nones a little confusing.","accounts_in_message":[],"_revision_number":4},{"id":"9777f5973efceefd3c835937455687fc690eb1a4","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-26 21:35:38.000000000","message":"Patch Set 4:\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"6bb040042eafe385c0644a830100cbd3f580696b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-26 21:35:48.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"a2bdbe4ec9ac48df07dee07f17edf712dc127d30","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-26 21:38:13.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"8c631fd78ace2b7f2ce0196735ea524899bb3894","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-26 22:44:35.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80fc200efafe46c98a83083605c6f1a0 : SUCCESS in 9m 16s\n- grenade https://zuul.opendev.org/t/openstack/build/597d4ac76ae94d388822f5c53c09bbbb : SUCCESS in 58m 27s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/91e1e514318b4ac9bcaa4ea7bea92ef3 : SUCCESS in 45m 38s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/e65db707c8a548aea011df6705fdc184 : SUCCESS in 9m 12s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/0652c6b1eadd4041a601f33547ee9544 : SUCCESS in 7m 37s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/df2854b029ca46e09bc194a6a4387608 : SUCCESS in 15m 01s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/757673d09acc4e39ba64a0e95e6b57b0 : SUCCESS in 16m 52s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f711a3154075426f820808e6e9feb93d : SUCCESS in 15m 59s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/da5eb07c20944208b7b86034530d4628 : SUCCESS in 19m 04s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/d8ec8eb3bb254179a507170a21f4fc9a : SUCCESS in 18m 32s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/a57c60ac0ee14603a55358c13ea16780 : SUCCESS in 20m 28s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/3adef02c77cd46518e1483432c345e52 : SUCCESS in 20m 10s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/12b66d06333144da8c644977600d6bd2 : SUCCESS in 21m 20s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/3ff1d09b19f34db5a3f21674f035637d : SUCCESS in 21m 08s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/62e3e7ef7b4742958ba3e18726210815 : SUCCESS in 20m 47s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/16cfc003c6f744838740071ce94f1f27 : SUCCESS in 20m 02s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/cc07170f8b264035b9ddcb1037850c1d : SUCCESS in 6m 02s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/c52e41268293431691e34c04e7859b8b : SUCCESS in 25m 12s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/a9d28452dcad401c83d4a995a4ea56c7 : SUCCESS in 1h 02m 30s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/4dba245a02c145ae85741d5b214bddc1 : SUCCESS in 47m 11s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/8f4674d4f56a4e5da88b20f1dd1a7784 : SUCCESS in 40m 14s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5269e21cf4e04218bc54d118e2ad33d1 : SUCCESS in 39m 39s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/dbb1e4e6f41048dfabb599958c57da20 : SUCCESS in 16m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d91ddac5e9e34a2185692ad08e57265d : SUCCESS in 6m 09s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/a9e2c4dd20c3488a8b347c7fbba3c230 : SUCCESS in 21m 55s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/f6d8191c7f554c098b6bc5b673be00f2 : SUCCESS in 54m 50s","accounts_in_message":[],"_revision_number":5},{"id":"c1dca06cc4bb29ba88397e993e463d4ad9990723","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-29 09:43:09.000000000","message":"Patch Set 5: Code-Review-1\n\n(8 comments)\n\nThe core change looks fine, unfortunately I\u0027m -1 on the new valid_suffix() function: I agree that the existing check was weak, but feel that if we\u0027re adding a helper function then it should be watertight.","accounts_in_message":[],"_revision_number":5},{"id":"ee0a9171ebb5481919cd47fb3fb9129bc690f8cb","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-29 17:26:04.000000000","message":"Patch Set 5:\n\n(5 comments)","accounts_in_message":[],"_revision_number":5},{"id":"6bbacb6a9fa7356b7f27e5b988e6ade1ec973dbf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-29 17:26:16.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"af104660393bc8afd464c2da713bed26c493359f","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-03-29 17:43:43.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"9fc054ae0f892ce18fab0701cfe5c5612529c912","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-29 18:28:29.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"8f7e86bb16e3591f18da1b1f2c530eab8983cb40","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-29 18:38:18.000000000","message":"Patch Set 6: Code-Review+2\n\n(3 comments)","accounts_in_message":[],"_revision_number":6},{"id":"e83f8e05dd3ef9ac2a1b8a1bfc15a5faf939adf5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-29 18:45:08.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e26add4a0fa44c4a8601689a7eda700e : SUCCESS in 9m 05s\n- grenade https://zuul.opendev.org/t/openstack/build/76c673aa14404a2cbc77a9ba02b455b4 : SUCCESS in 1h 01m 23s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/5acb1dd3e8604df5b2e8db2e9ff06aaa : SUCCESS in 50m 39s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/59e964fa438244f69fb0e4cbd662e60e : SUCCESS in 9m 34s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/e9fa890b4b9f43daa17554f272e8e513 : SUCCESS in 7m 17s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/7ce96d81cce1472385c143ec8b485391 : SUCCESS in 14m 17s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/8af8e5d645e84592be85aae8987464a3 : SUCCESS in 20m 28s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/fb7178ecb84140c9ae45aa11b9fd145a : SUCCESS in 15m 47s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/49a49acb2356437f90e3c87242be8036 : SUCCESS in 16m 09s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/5e822304d6364c3389bd5a98db96bdf6 : SUCCESS in 16m 01s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/41274a798e1546ccb50be551ae7550e1 : SUCCESS in 17m 08s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/5be21a612055419c90a99a154387a9be : SUCCESS in 18m 59s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/28740508cf624b8f878f3eff0338ff05 : SUCCESS in 24m 10s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/59570c0981c24163a23b0b7ce45d2a11 : SUCCESS in 23m 04s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/d01f8f4c2a964ea0820ef98c8a11f16e : SUCCESS in 21m 47s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/a706769d93914a3c909261a60ae6913b : SUCCESS in 19m 09s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/14c4716f8f4147608b58e2b1ba5ded91 : SUCCESS in 10m 30s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/3cef3dbc508143f18c5f24943fcfd4f5 : SUCCESS in 42m 29s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/9df941805e444dc88bb3954fc6bead33 : SUCCESS in 38m 39s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/b79a7b95b1b94512a205462b7a77ac33 : SUCCESS in 48m 34s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/3852f39ce70643c08e027d232c1ce213 : SUCCESS in 41m 26s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/9d9fbc0e87a4433e964e560b7ce0225c : SUCCESS in 42m 42s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b704f2de9ac84a0796876bbd6d299bad : SUCCESS in 15m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/85dfb04f251946bab413ef7905c3a55d : SUCCESS in 8m 30s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/d3e6b56ec5b54922b147136726096838 : SUCCESS in 27m 50s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/c2d7cb5a79e4467ab37d3c2a2f1942e4 : SUCCESS in 57m 37s","accounts_in_message":[],"_revision_number":6},{"id":"f0b1eadf01ffda3d0d60a5172d85f3cd79c142f0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-29 20:12:44.000000000","message":"Patch Set 6:\n\n(1 comment)","accounts_in_message":[],"_revision_number":6},{"id":"ecadfe593f6113322d99233e276263493497ad56","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-30 10:05:47.000000000","message":"Patch Set 6: Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"cc6bbd26f4ff48eef04752cc89fe0644ae6bc83b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 10:06:05.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"a1007f795795bf8715ba6e5b9affed1ddbce7daa","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 11:10:59.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cbf80a5e61cf4cbc8692ae6f3f61f1b6 : SUCCESS in 9m 37s\n- grenade https://zuul.opendev.org/t/openstack/build/6e343437434549e7bbb3e66160fda822 : SUCCESS in 1h 03m 44s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/df25ef468c2246a3a86e983496e948ea : SUCCESS in 38m 08s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/42683a869214417b952a8aaaecaf5c18 : SUCCESS in 9m 26s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/77783d31d3c44a6fac3e4dee08fdf794 : SUCCESS in 7m 46s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/05fdb3078b674102a475c42f1d1b8ab2 : SUCCESS in 19m 31s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/3c6b25f5289144ff9079e1c074efd6ec : SUCCESS in 19m 36s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/6a51fdadab10495fa7c6af02b3793aaa : SUCCESS in 21m 00s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/6aeb63253db24f1197ad24489f94c66d : SUCCESS in 20m 31s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/e3c4c38255514e9cba75bed6196cca82 : SUCCESS in 20m 24s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/b2a2df2a242947ce82ee1d1efe99fa90 : SUCCESS in 20m 36s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/86eb7eb2905e48f09af2e215f5b83e46 : SUCCESS in 19m 26s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/be16bc19d2bf425ba1a6c6347e37ea0a : SUCCESS in 22m 04s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/7c90c2b79d1f4ab4857c864a25f06163 : SUCCESS in 23m 12s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/f95f3c11aec544dfb2f2edc739c3b7f1 : SUCCESS in 20m 08s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/0d99c39d67204095a529c1c5b797b567 : SUCCESS in 21m 59s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/2638b2bd2b76475eaa9eb0e862d187bf : SUCCESS in 6m 24s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/cbdf861c016e49a1a3729752f06dc3cc : SUCCESS in 50m 54s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/fddc4dd213ba444bbd6a9c315e590915 : SUCCESS in 49m 02s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/f5502ac5d6c24125ba6b10b5c5dea4c6 : SUCCESS in 38m 47s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/11378b429f084e75b41028317da1ab9f : SUCCESS in 42m 42s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ff78abdc87ee4c8a914f0fec659b7306 : SUCCESS in 15m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cde4c94d9ce44bdd8ba9c62d6a6d794e : SUCCESS in 6m 19s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/0c1baca152ce481da0c3c987949bfdd3 : SUCCESS in 24m 52s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/439a70957f9d485480ed1e31df9faa2d : SUCCESS in 57m 46s","accounts_in_message":[],"_revision_number":6},{"id":"bb1256af3a19a93f8f233489ae33181bc6025bb6","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 11:11:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":6},{"id":"873879d0059c0b03a9ce7b096f430c96c0fbc0d3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-30 11:13:40.000000000","message":"Patch Set 6:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c4e738cdb2b040d7a058c8edb3c63f62 : SUCCESS in 1m 06s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/9205b799841842548454d8c0d8b9feec : SUCCESS in 42s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/bcb31a7a681a453ab9ba904812fe1723 : SUCCESS in 41s (non-voting)","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"ade3b28636dd3be79152af4dedfcc7a039dff025","revisions":{"73401b25dce2dab57d3d34ff7eba2570d3b0e5d0":{"kind":"REWORK","_number":1,"created":"2021-03-19 20:35:00.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/1"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/73401b25dce2dab57d3d34ff7eba2570d3b0e5d0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/73401b25dce2dab57d3d34ff7eba2570d3b0e5d0"}]},"branch":"refs/heads/master"},"48aa51dbb2cd6a1c849ff442321ab6cb1846d689":{"kind":"REWORK","_number":2,"created":"2021-03-25 20:02:10.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/2"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-25 18:17:03.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nThe relinker currently blindly calls get_hashes on partitions in the\nnew, upper half of the partition space, which can cause extra handoffs\nto be created if you\u0027re rerunning the relink step for safety.\n\nEven if the relinker were smarter, though, there\u0027s no reason that a\ncurious operator should end up creating empty handoffs just because\nthey\u0027re poking devices with REPLICATE requests\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/48aa51dbb2cd6a1c849ff442321ab6cb1846d689"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/48aa51dbb2cd6a1c849ff442321ab6cb1846d689"}]},"branch":"refs/heads/master"},"de6717bc0edcd08bdb8a91de6933e2f4b1771eb3":{"kind":"REWORK","_number":3,"created":"2021-03-25 20:35:41.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/3"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-25 20:35:34.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nThe relinker currently blindly calls get_hashes on partitions in the\nnew, upper half of the partition space, which can cause extra handoffs\nto be created if you\u0027re rerunning the relink step for safety.\n\nEven if the relinker were smarter, though, there\u0027s no reason that a\ncurious operator should end up creating empty handoffs just because\nthey\u0027re poking devices with REPLICATE requests\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/de6717bc0edcd08bdb8a91de6933e2f4b1771eb3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/de6717bc0edcd08bdb8a91de6933e2f4b1771eb3"}]},"branch":"refs/heads/master"},"94cd4684e5a7f4ffda7a228da0df01e5915a7dc3":{"kind":"REWORK","_number":4,"created":"2021-03-25 20:54:34.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/4"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-25 20:54:28.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nThe relinker currently blindly calls get_hashes on partitions in the\nnew, upper half of the partition space, which can cause extra handoffs\nto be created if you\u0027re rerunning the relink step for safety.\n\nEven if the relinker were smarter, though, there\u0027s no reason that a\ncurious operator should end up creating empty handoffs just because\nthey\u0027re poking devices with REPLICATE requests\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/94cd4684e5a7f4ffda7a228da0df01e5915a7dc3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/94cd4684e5a7f4ffda7a228da0df01e5915a7dc3"}]},"branch":"refs/heads/master"},"fc1e9a2da0b7091c99dca089a64aa0339ba2ae34":{"kind":"REWORK","_number":5,"created":"2021-03-26 21:35:48.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/5"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-26 21:17:09.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nThe relinker currently blindly calls get_hashes on partitions in the\nnew, upper half of the partition space, which can cause extra handoffs\nto be created if you\u0027re rerunning the relink step for safety.\n\nEven if the relinker were smarter, though, there\u0027s no reason that a\ncurious operator should end up creating empty handoffs just because\nthey\u0027re poking devices with REPLICATE requests\n\nDrive-by: be a little more strict about the \"suffixes\" we\u0027re willing to\nput in hashes.invalid and read out of hashes.pkl.\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fc1e9a2da0b7091c99dca089a64aa0339ba2ae34"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/fc1e9a2da0b7091c99dca089a64aa0339ba2ae34"}]},"branch":"refs/heads/master"},"ade3b28636dd3be79152af4dedfcc7a039dff025":{"kind":"REWORK","_number":6,"created":"2021-03-29 17:26:16.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/08/781908/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/781908/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/781908/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/781908/6"}}},"commit":{"parents":[{"commit":"38d5e1339b311517d16bc81dfbc56f460b82b1ca","subject":"Merge \"Only test with \u0026-delimited query strings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/38d5e1339b311517d16bc81dfbc56f460b82b1ca"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-19 20:32:49.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-03-29 17:26:05.000000000","tz":-420},"subject":"diskfile: Prevent get_hashes from creating missing partition dirs","message":"diskfile: Prevent get_hashes from creating missing partition dirs\n\nThe relinker currently blindly calls get_hashes on partitions in the\nnew, upper half of the partition space, which can cause extra handoffs\nto be created if you\u0027re rerunning the relink step for safety.\n\nEven if the relinker were smarter, though, there\u0027s no reason that a\ncurious operator should end up creating empty handoffs just because\nthey\u0027re poking devices with REPLICATE requests\n\nDrive-by: be a little more strict about the \"suffixes\" we\u0027re willing to\nput in hashes.invalid and read out of hashes.pkl.\n\nChange-Id: I9aace80088cd00d02c418fe4d782b662fb5c8bcf\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ade3b28636dd3be79152af4dedfcc7a039dff025"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/ade3b28636dd3be79152af4dedfcc7a039dff025"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}