)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bc55627074f8714fbe8ab4d75dcd2aea6ce19e25","unresolved":true,"context_lines":[{"line_number":1559,"context_line":"        partition_exists \u003d os.path.exists(partition_path)"},{"line_number":1560,"context_line":"        if (create_partition or suffixes) and not partition_exists:"},{"line_number":1561,"context_line":"            mkdirs(partition_path)"},{"line_number":1562,"context_line":"            partition_exists \u003d True"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"        if skip_rehash:"},{"line_number":1565,"context_line":"            for suffix in suffixes or []:"}],"source_content_type":"text/x-python","patch_set":1,"id":"6083bfa8_042be566","line":1562,"updated":"2021-03-26 21:15:10.000000000","message":"I\u0027m less and less convinced that this is necessary at all.\n\nIf the dir doesn\u0027t exist, hashes.pkl doesn\u0027t exist, so all the (non-existent!) suffixes are automatically invalid and there\u0027s no need for us to write anything down, much less create the directory.","commit_id":"a057f532de0d73ff70fe1e3415dd835342c30b2e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"969a8ca3e7ba889f72a43c4b5513ef660e1dad5e","unresolved":true,"context_lines":[{"line_number":1556,"context_line":"            raise DiskFileDeviceUnavailable()"},{"line_number":1557,"context_line":""},{"line_number":1558,"context_line":"        partition_path \u003d get_part_path(dev_path, policy, partition)"},{"line_number":1559,"context_line":"        partition_exists \u003d os.path.exists(partition_path)"},{"line_number":1560,"context_line":"        if (create_partition or suffixes) and not partition_exists:"},{"line_number":1561,"context_line":"            mkdirs(partition_path)"},{"line_number":1562,"context_line":"            partition_exists \u003d True"},{"line_number":1563,"context_line":""},{"line_number":1564,"context_line":"        if skip_rehash:"},{"line_number":1565,"context_line":"            for suffix in suffixes or []:"},{"line_number":1566,"context_line":"                invalidate_hash(os.path.join(partition_path, suffix))"},{"line_number":1567,"context_line":"            hashes \u003d None"},{"line_number":1568,"context_line":"        elif partition_exists:"},{"line_number":1569,"context_line":"            _junk, hashes \u003d tpool.execute("},{"line_number":1570,"context_line":"                self._get_hashes, device, partition, policy,"},{"line_number":1571,"context_line":"                recalculate\u003dsuffixes)"},{"line_number":1572,"context_line":"        else:"},{"line_number":1573,"context_line":"            hashes \u003d {}"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        return hashes"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    def _listdir(self, path):"},{"line_number":1578,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"4c54a517_5b0d27d6","line":1575,"range":{"start_line":1559,"start_character":0,"end_line":1575,"end_character":21},"updated":"2021-03-26 12:28:09.000000000","message":"this is tinkering, but felt a little easier to grok and reduced from three to one return point","commit_id":"a057f532de0d73ff70fe1e3415dd835342c30b2e"}],"test/unit/cli/test_relinker.py":[{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bc55627074f8714fbe8ab4d75dcd2aea6ce19e25","unresolved":true,"context_lines":[{"line_number":424,"context_line":"            os.path.join(self.part_dir, \u0027hashes.invalid\u0027)))"},{"line_number":425,"context_line":"        # Check that only the dirty partition in upper half of next part power"},{"line_number":426,"context_line":"        # has been created and rehashed"},{"line_number":427,"context_line":"        other_next_part \u003d (self.next_part +"},{"line_number":428,"context_line":"                           (1 if self.next_part \u003d\u003d 2 * self.part else -1))"},{"line_number":429,"context_line":"        other_next_part_dir \u003d os.path.join(self.objects, str(other_next_part))"},{"line_number":430,"context_line":"        self.assertFalse(os.path.exists(other_next_part_dir))"}],"source_content_type":"text/x-python","patch_set":1,"id":"66ca0d74_cb6f2526","line":427,"updated":"2021-03-26 21:15:10.000000000","message":"Maybe just\n\n self.next_part ^ 1\n\n?","commit_id":"a057f532de0d73ff70fe1e3415dd835342c30b2e"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"969a8ca3e7ba889f72a43c4b5513ef660e1dad5e","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        other_next_part \u003d (self.next_part +"},{"line_number":428,"context_line":"                           (1 if self.next_part \u003d\u003d 2 * self.part else -1))"},{"line_number":429,"context_line":"        other_next_part_dir \u003d os.path.join(self.objects, str(other_next_part))"},{"line_number":430,"context_line":"        self.assertFalse(os.path.exists(other_next_part_dir))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_relink_link_already_exists(self):"},{"line_number":433,"context_line":"        self.rb.prepare_increase_partition_power()"}],"source_content_type":"text/x-python","patch_set":1,"id":"40f2e251_bb002c6a","line":430,"updated":"2021-03-26 12:28:09.000000000","message":"this is the goal right?","commit_id":"a057f532de0d73ff70fe1e3415dd835342c30b2e"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"bc55627074f8714fbe8ab4d75dcd2aea6ce19e25","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        other_next_part \u003d (self.next_part +"},{"line_number":428,"context_line":"                           (1 if self.next_part \u003d\u003d 2 * self.part else -1))"},{"line_number":429,"context_line":"        other_next_part_dir \u003d os.path.join(self.objects, str(other_next_part))"},{"line_number":430,"context_line":"        self.assertFalse(os.path.exists(other_next_part_dir))"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_relink_link_already_exists(self):"},{"line_number":433,"context_line":"        self.rb.prepare_increase_partition_power()"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4611cb3_d48c7e42","line":430,"in_reply_to":"40f2e251_bb002c6a","updated":"2021-03-26 21:15:10.000000000","message":"Yup -- thanks!","commit_id":"a057f532de0d73ff70fe1e3415dd835342c30b2e"}]}