)]}'
{"swift/obj/diskfile.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"f69ac1a8108ec892193e1d4d51bdb4ad94abeff8","unresolved":true,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"def valid_suffix(value):"},{"line_number":345,"context_line":"    if not isinstance(value, six.string_types) or len(value) !\u003d 3:"},{"line_number":346,"context_line":"        return False"},{"line_number":347,"context_line":"    return all(c in \u00270123456789abcdef\u0027 for c in value)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3aef0b52_845f6fd7","line":345,"updated":"2021-03-31 15:04:38.000000000","message":"there might be a lesson here about EAPF and LBYL - or at least duck typing\n\nperhaps len(value) !\u003d 3 raising a TypeError because some jackhole passed us an int would be BETTER than *thinking* we know the type doesn\u0027t support len or iter because of some weak isinstance check","commit_id":"2a672b678838dfa9ff130b431245209cfe011992"},{"author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"change_message_id":"4d9643d3ebdd511367f82d45020ad14b3692f6e9","unresolved":true,"context_lines":[{"line_number":342,"context_line":""},{"line_number":343,"context_line":""},{"line_number":344,"context_line":"def valid_suffix(value):"},{"line_number":345,"context_line":"    if not isinstance(value, six.string_types) or len(value) !\u003d 3:"},{"line_number":346,"context_line":"        return False"},{"line_number":347,"context_line":"    return all(c in \u00270123456789abcdef\u0027 for c in value)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cd7e19a6_735fec86","line":345,"in_reply_to":"3aef0b52_845f6fd7","updated":"2021-03-31 16:38:06.000000000","message":"The real reason for the type check was that Alistair was a smart aleck on the parent patch and worrying about cases like\n\n valid_suffix((\u00271\u0027, \u00272\u0027, \u00273\u0027))","commit_id":"2a672b678838dfa9ff130b431245209cfe011992"}]}