)]}'
{"id":"openstack%2Fswift~784108","triplet_id":"openstack%2Fswift~master~I5291aea2b4f1b3dbb6906f943ccf63ad8e716ef7","project":"openstack/swift","branch":"master","topic":"p-fix-valid-suffix","hashtags":[],"change_id":"I5291aea2b4f1b3dbb6906f943ccf63ad8e716ef7","subject":"py2: diskfile.valid_suffix should allow unicode","status":"MERGED","created":"2021-03-31 14:33:52.000000000","updated":"2021-04-01 12:01:47.000000000","submitted":"2021-04-01 11:59:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"784108-p-fix-valid-suffix","meta_rev_id":"5665f178a5d25f9166fb6e2663dbd415bf88fde3","_number":784108,"virtual_id_number":784108,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-04-01 11:58:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-03-31 14:52:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":2,"date":"2021-03-31 15:04:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-03-31 14:52:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"value":1,"date":"2021-03-31 15:04:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-31 14:52:14.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"},{"updated":"2021-03-31 15:04:38.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2021-03-31 17:03:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"7858bbc5389e02e000bddbfff90d75e1776a7d9c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-31 14:33:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b362484b389d0c89993c723ff0bf0dd8a9d6d82f","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-31 14:38:05.000000000","message":"Patch Set 1:\n\nWithout this change I reliably see a probe test failure:\n\n  while true; do nosetests ./test/probe/test_replication_servers_working.py:TestReplicatorFunctions.test_main || break; done\ntest_main (test.probe.test_replication_servers_working.TestReplicatorFunctions) ... FAIL\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFAIL: test_main (test.probe.test_replication_servers_working.TestReplicatorFunctions)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/vagrant/swift/test/probe/test_replication_servers_working.py\", line 188, in test_main\n    directory, input_dir)))\nAssertionError: True is not false\n\n\nbut zuul probe tests passed the original patch, so maybe my SAIO is in a weird state ??? but the fix seems to make sense","accounts_in_message":[],"_revision_number":1},{"id":"ca8af2e6bd0d712f3d88e317ade3d36687e5d8fd","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-03-31 14:40:14.000000000","message":"Patch Set 1:\n\nshould have said. my probe test failure is on a py27 v-saio","accounts_in_message":[],"_revision_number":1},{"id":"02b3c3e02a9ea7fccea62ab7b3ccc97e8ce1691a","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-31 14:52:14.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nWeird that the original patch had passing tests :-/","accounts_in_message":[],"_revision_number":1},{"id":"f69ac1a8108ec892193e1d4d51bdb4ad94abeff8","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-03-31 15:04:38.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"4d9643d3ebdd511367f82d45020ad14b3692f6e9","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-03-31 16:38:06.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2bd4435efced992e093cc5e2aa90ed8294e91d58","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 17:03:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/14c896f595ea4168950b6cbbfbecb684 : SUCCESS in 8m 37s\n- grenade https://zuul.opendev.org/t/openstack/build/9e6b2486b5bf429d883e9cc512747893 : SUCCESS in 1h 13m 19s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/10cbc50986e34bfaaf16bd458781e2ba : SUCCESS in 1h 06m 50s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/b918726ba81a462cb8a7efe46c1175f7 : SUCCESS in 9m 17s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/8df7ab0b97b249edac7e2a57153a4c47 : SUCCESS in 9m 40s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/c4c1e6609a604c4b83e3ea5ce9d2c0bc : SUCCESS in 14m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/5b6e8b32273147e9b4e02eb2216020a0 : SUCCESS in 15m 08s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/7afcd881191c4ad2a2cad337c984c7a8 : SUCCESS in 15m 51s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/02bd7bf60b324d85ba560f5a9767b350 : SUCCESS in 14m 48s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/5284b426658e45f6a59a5faf8ebb3002 : SUCCESS in 15m 12s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/46475ec5a3b14698af49a907174a4e51 : SUCCESS in 17m 33s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/ef53023224e64f5b93b60c64ce933671 : SUCCESS in 18m 53s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/138a3ac1189545c2b419e3355b8ede61 : SUCCESS in 24m 21s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c23d5d20180d4aec9e607c309f6c0f5c : SUCCESS in 20m 37s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/46234cb159b546178c09621d66033bab : SUCCESS in 20m 46s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/5fd2d312fadf4239bce6ee21645c3a88 : SUCCESS in 23m 00s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/3ef2c717b1fd4fa880e5c9b10d6bf72f : SUCCESS in 6m 33s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/60893a42eb694ecaa14efb0e7f7c754a : FAILURE in 24m 25s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/528207d2623f4de7bf376e5ed7e13b38 : SUCCESS in 49m 24s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/ea5117a6fa7c4a9ba943bc3511d39583 : SUCCESS in 47m 49s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/dc2e8a2ab7214dd99a90d8f88ef98a1f : SUCCESS in 44m 46s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/33749cb9521b42eca2fa9cc6de04009b : SUCCESS in 39m 33s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fae6cb1fe19946e2b497934a70f664e4 : SUCCESS in 18m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/304df5aeb9f44158bfd1f489bdf729a0 : SUCCESS in 8m 28s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/1e70ce31ae994fbfa574a1d5e170207c : SUCCESS in 28m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/681f1993a72a4d478cdc6df813deb4f1 : SUCCESS in 48m 47s","accounts_in_message":[],"_revision_number":1},{"id":"ed4efd1fd2dbb3b3a9d736b79c9c57fc40839675","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-31 17:04:08.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ca0fbd445e152b4450938848a32b1f57f15ca0a3","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-04-01 03:35:00.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"266cbec06a882fccc7650227bdc16bd7d552312b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 04:39:57.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c7a1992289784114a69dbb3ba272febc : SUCCESS in 8m 52s\n- grenade https://zuul.opendev.org/t/openstack/build/c58690dafadf40c98863995db2b31f34 : SUCCESS in 1h 04m 05s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/297aa96032974c229306058baeccce6c : SUCCESS in 45m 55s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/947c5387fae24281b966ccd4a3bb8bfc : SUCCESS in 8m 19s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/e160af41d4864330ab0024ba9fabd23e : SUCCESS in 6m 40s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/5ed9fb2b43b548858f696c430db8d50b : SUCCESS in 15m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/59d1e9a0f4434aa2b4c7dbfca0c69313 : SUCCESS in 18m 39s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/a8d286bb2f3e42b486d80b718f1caf93 : SUCCESS in 18m 35s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/1098ec4007684ee5aa6e0d3f4dca2043 : SUCCESS in 19m 01s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/074a7d01e1ac4cf298abba8571beb127 : SUCCESS in 18m 56s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/7c144c78aac6450899785d466e13cdda : SUCCESS in 20m 03s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/efd61847d36f4adfb9f078284a7df96b : SUCCESS in 20m 52s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c36953689a4047009c2173a8a4e57ff7 : SUCCESS in 21m 34s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/ac955702e595475fa5821e59bc2b38ef : SUCCESS in 20m 59s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/212230132564442e91b5f45adbd91bc0 : SUCCESS in 21m 09s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/265399efe66d43fbad0d89af2e0d8503 : SUCCESS in 22m 12s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/06bcafd3976442b58ac68abd459effa9 : SUCCESS in 6m 44s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/15d07f659f4245b5812125b5dcb424ee : SUCCESS in 25m 15s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/23a862c6adb040d7b79c170f336bdf9d : SUCCESS in 55m 34s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/c3262cca1f134320973550361732785c : SUCCESS in 48m 55s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/3db8e324f98940679fb4722762ca59f0 : SUCCESS in 43m 35s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/8edbca1e4f684ef495d80f97de64f515 : SUCCESS in 42m 20s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/943f11796f214b5993322610c32ca777 : SUCCESS in 17m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8c689a7a1144ce1a864b2d0ccb5d533 : SUCCESS in 5m 50s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/5af09d2cf5fc4fb5ac87e23b76c7ceb1 : SUCCESS in 28m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/6388e94e7ea7404d9329d9579fd0615b : SUCCESS in 1h 00m 07s","accounts_in_message":[],"_revision_number":1},{"id":"0060614f08acc43d834213ed3c1cbf291275f437","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 04:40:21.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"a106255a0954e017546e89b99715cb5c89daeeb9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 06:54:46.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f22a4a501d5e4a29a519edebaae97aa7 : SUCCESS in 12m 21s\n- grenade https://zuul.opendev.org/t/openstack/build/41a07167a5424365a83ce97071b05bb3 : SUCCESS in 49m 01s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/2b53accfcfac478d978cb0491814f97c : SUCCESS in 39m 57s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/9101e40b3e5f4264941008f90ed74338 : SUCCESS in 10m 25s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/75c46a1f2aaa49f991254391b6455059 : SUCCESS in 8m 35s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/4b51cb63ff774fba84b54c1d8f572480 : SUCCESS in 15m 16s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/35d2cd00e7a84c3ea84b008000cfa8f8 : SUCCESS in 15m 42s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/1fbd3fb9e52f4594beedd680012ab708 : SUCCESS in 15m 19s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/fa5d8a16806b4bb797e342b0eb345a40 : SUCCESS in 15m 23s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/410711a6fd964a4487b96fd10e8f508e : SUCCESS in 14m 38s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/195155aee818433fa32b933adc778ae1 : SUCCESS in 18m 04s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/c2aa920f993c4358967127b9050126c9 : SUCCESS in 16m 42s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/c884acb41cf445deba79ff2eb06a82dd : SUCCESS in 18m 48s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c9acc7ed5a4943c38514ba49e25ee18a : SUCCESS in 17m 51s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/5ee7bae1a81f4b8a927525c7e575e907 : SUCCESS in 20m 28s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/3566a46664ae40f6a833b805bc0e145b : SUCCESS in 18m 10s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/887880a7404f42288a426de71c5ab32f : SUCCESS in 6m 34s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/49b9feecf98c4d0aa8a07bbf477a3ff6 : TIMED_OUT in 2h 01m 55s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/791485a2b21b443ea00b0af6a4b202c3 : SUCCESS in 51m 57s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/6a11d370fb98440e8ce831e6869803d3 : SUCCESS in 43m 38s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/6f5dda91292f4668974a9f29b1d2dd03 : SUCCESS in 42m 40s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1ff676f13ba841aab92705cf2ce9f06c : SUCCESS in 15m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7fdd45fb0253413190836a9f3b683010 : SUCCESS in 6m 12s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/5cd9950a9b9d4aa19520b87453aa0878 : SUCCESS in 23m 48s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/adad88c03fbb4da8a93659a4b2c86864 : SUCCESS in 1h 03m 07s","accounts_in_message":[],"_revision_number":1},{"id":"3305962a59ab222b4515387472adcb281b0a67f9","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-04-01 08:30:06.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"3afc714e2fc36618a6745338d86c9753e5909e7c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 09:55:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b6463bd25b354a939bcc64d5f2e85384 : SUCCESS in 8m 48s\n- grenade https://zuul.opendev.org/t/openstack/build/3ed4ccb2f26e4cc49e4924a966a73d1e : SUCCESS in 1h 18m 24s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/adf55811cd94440c8344d449c4319e6a : SUCCESS in 50m 36s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/c24c205be39349389ee24fc384651a1e : SUCCESS in 8m 35s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/a67b06c62cc1449cb121fcfd5c9c9d4e : SUCCESS in 6m 51s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/1d5dfd42bb2141c98a01d69c184f543c : SUCCESS in 15m 54s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/f014760bc0cf49bb89473bbb713ca039 : SUCCESS in 16m 00s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/7a5e15e5c60f4f36b758075a9c9c1a16 : SUCCESS in 16m 09s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/19de97150d274acdadc932589b823ee2 : SUCCESS in 18m 07s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/8aca8c9546864443afcb62d663e0d0c7 : SUCCESS in 14m 29s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/006443d1921a42d6ae7e56224a10ccd7 : SUCCESS in 20m 18s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/42a7f85087d14c32904997b960ffedc4 : SUCCESS in 16m 32s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/281b67fed1e5473b8d1fa4bd7425adeb : SUCCESS in 21m 16s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/a303fb64f32d41d99a9a78103c0191d5 : SUCCESS in 19m 09s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/a94e554fd1ec4cf8a6101325c393e1e7 : SUCCESS in 17m 56s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/15b714e4f45f465e80dcc8d5140ce125 : SUCCESS in 19m 34s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/eba31e4f288b4a4995ef42610b8fa18c : SUCCESS in 6m 46s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/f761bf305b1449bea1e14666f6c4f377 : SUCCESS in 24m 44s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/e2a79709a21242d2bc9b54e953115d66 : SUCCESS in 53m 03s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/e4f7d3b0982b48dab3434723f1c4de43 : SUCCESS in 46m 15s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/3273d2bd549044119fe284640e80aa7e : SUCCESS in 40m 53s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/84df140f05ec4beab1463ee66e51bed7 : SUCCESS in 44m 10s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2a744613812a484ca0b2faed41345387 : SUCCESS in 16m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4b04ad58fac8449cb53db8cb037e9f05 : SUCCESS in 6m 20s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/43ae93da564142048e855dfeb5e40fe2 : SUCCESS in 29m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/284dc48b2ac045fab5c2fe3627a471e7 : SUCCESS in 59m 32s","accounts_in_message":[],"_revision_number":1},{"id":"dda7cec88825ce2060c5fb2fe8a6fdda4e898178","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 09:59:12.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"d04a17a80861b7c6cbb057dd125f4e51195c07ea","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 11:58:58.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8ceddd9563ca46e68bda627c82f49c51 : SUCCESS in 11m 58s\n- grenade https://zuul.opendev.org/t/openstack/build/c64fe64d62db49ce8776e6b08f7c8198 : SUCCESS in 1h 10m 36s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/c3c04466b23a4ae9a789a8afdfd63814 : SUCCESS in 47m 03s\n- swift-upload-image https://zuul.opendev.org/t/openstack/build/cee05f2d2b7740b58e243eb23c49654a : SUCCESS in 12m 48s (non-voting)\n- swift-upload-image-py3 https://zuul.opendev.org/t/openstack/build/a6377d14d20d420a8daca5dc6c553149 : SUCCESS in 7m 48s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/ea0b54cb49a948fa99e79e0ca5ad643b : SUCCESS in 15m 53s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/2e9d8099b4ef4170aa1cfdfb3d0047cb : SUCCESS in 18m 50s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/009d1db78ccb426b863f6c0bc67ddae8 : SUCCESS in 15m 14s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/99863710037d45588ff9e499bbae75d4 : SUCCESS in 14m 47s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/ca3e454c1cc74ff5961addf44e814073 : SUCCESS in 19m 14s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/0ec04bbf4f4846a1b9df6e03d8e6534f : SUCCESS in 20m 33s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/9d7437738c0b47c79f6d0350b7480b9d : SUCCESS in 22m 19s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/87af789c919a489b94be479c03313320 : SUCCESS in 21m 34s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/8f908d1b073646cc9df8afc6e300cdac : SUCCESS in 21m 25s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/1c9bc0540955429ba3a7373a0043a378 : SUCCESS in 19m 48s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/ff92aceda8c341a9b65be1fe61661923 : SUCCESS in 17m 54s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/78c16b7c9ca149259b6a6ba3d0b5afb5 : SUCCESS in 8m 13s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/725bcb64e0c443d98adf680a7cd1d1da : SUCCESS in 56m 26s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/b202a554b8224ec7bd9784d4a71bb52b : SUCCESS in 52m 11s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/a6f11b9149ea4cdd893279ee5701d424 : SUCCESS in 40m 11s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/7d363bbfc2284c7c85cbe9d5e0957a54 : SUCCESS in 39m 35s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c0be32d9bca4304ae0e827ee6300b1a : SUCCESS in 17m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/4c22d451fcbb4ee493f36420738e6a57 : SUCCESS in 7m 02s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/20b9950dcccb4bfdb6565f5979a7949d : SUCCESS in 22m 30s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/8b85fb6bdcda4792af54414fcebc6589 : SUCCESS in 50m 20s","accounts_in_message":[],"_revision_number":1},{"id":"a038fe51b962acc0fd8d13c1bb8da6a88e2c6364","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 11:59:04.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"5665f178a5d25f9166fb6e2663dbd415bf88fde3","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-01 12:01:47.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/580fed5279b040e1af611759153913d5 : SUCCESS in 58s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/a9cc91aa0aa349ae8b7e0d2c2d651c14 : SUCCESS in 43s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/eac7b5480c894a808d92764d83b58b69 : SUCCESS in 44s (non-voting)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2a672b678838dfa9ff130b431245209cfe011992","revisions":{"2a672b678838dfa9ff130b431245209cfe011992":{"kind":"REWORK","_number":1,"created":"2021-03-31 14:33:52.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/08/784108/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/08/784108/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/784108/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/784108/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/08/784108/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/08/784108/1"}}},"commit":{"parents":[{"commit":"e0040c4c5553f4d093fa892e3562e65376c7a037","subject":"Merge \"Get func tests passing with a minimal proxy pipeline\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/e0040c4c5553f4d093fa892e3562e65376c7a037"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-31 13:37:39.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-03-31 14:01:19.000000000","tz":60},"subject":"py2: diskfile.valid_suffix should allow unicode","message":"py2: diskfile.valid_suffix should allow unicode\n\nWhen the replicator update method calls diskfile._get_hashes on a\nlocal partition the partition path can be unicode [1]. If _get_hashes\ndoes a listdir then os.listdir will return unicode values, and any new\nsuffixes will be written to the hashes.pkl as unicode. When the\nhashes.pkl is next read, these unicode suffixes would previously fail\nthe valid_suffix check and read_hashes would return {\u0027valid\u0027: False},\ncausing a rehash.\n\nWhen _get_hashes is called from an object server REPLICATE handler,\nthe device path is bytes and any listdir would return suffixes as\nbytes, so the suffix would then be written to hashes.pkl as bytes, and\nnot cause an error when read_hashes was next called.\n\nThis patch modifies diskfile.valid_suffix to allow suffixes to be\nunicode or byte strings.\n\n[1] the replication job device is set from the ring devs, and rings\ncan have unicode device values.\n\nChange-Id: I5291aea2b4f1b3dbb6906f943ccf63ad8e716ef7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2a672b678838dfa9ff130b431245209cfe011992"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/2a672b678838dfa9ff130b431245209cfe011992"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}