)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"d838b04ace4a6ca9b3b06476c0161b867f8c6f80","unresolved":true,"context_lines":[{"line_number":753,"context_line":"                and own_shard_range.state in (ShardRange.SHARDING,"},{"line_number":754,"context_line":"                                              ShardRange.SHARDED)):"},{"line_number":755,"context_line":"            if db_state \u003d\u003d SHARDED:"},{"line_number":756,"context_line":"                contexts \u003d CleavingContext.load_all(broker)"},{"line_number":757,"context_line":"                if not contexts:"},{"line_number":758,"context_line":"                    return"},{"line_number":759,"context_line":"                context_ts \u003d max(float(ts) for c, ts in contexts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc84e70d_1b244aab","line":756,"updated":"2021-04-07 01:03:43.000000000","message":"contexts is a generator, so the:\n  if not contexts\n\nbelow wont work. This need to be changed into a list or tuple so we can do a `not` test:\n\n  contexts \u003d list(CleavingContext.load_all(broker))","commit_id":"0f4ea0772720dc5adc52bd42ba52098d595fb85d"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"5f6035d5fb7e65351fbae24afe0086c746a6f5e4","unresolved":true,"context_lines":[{"line_number":2690,"context_line":"            context.delete(broker)"},{"line_number":2691,"context_line":""},{"line_number":2692,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":2693,"context_line":"            sharder._record_sharding_progress(broker, {}, None)"},{"line_number":2694,"context_line":""},{"line_number":2695,"context_line":"    def test_identify_sharding_old_style_candidate(self):"},{"line_number":2696,"context_line":"        brokers \u003d [self._make_broker(container\u003d\u0027c%03d\u0027 % i) for i in range(6)]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b40d2bfe_7d919c0f","line":2693,"updated":"2021-04-07 11:26:12.000000000","message":"ok, so this checks that no exception is raised, but there must be some assertion we could also make that the progress is not recorded","commit_id":"90696b3a1c8907c59d63f948720d745f10618d72"}]}