)]}'
{"id":"openstack%2Fswift~787637","triplet_id":"openstack%2Fswift~master~I4ba3e01e59fde6a85e5c3bc10055e65ccbd280c0","project":"openstack/swift","branch":"master","hashtags":[],"change_id":"I4ba3e01e59fde6a85e5c3bc10055e65ccbd280c0","subject":"sharding: Don\u0027t consider responses generated from cache as \"already visited\"","status":"NEW","created":"2021-04-22 20:37:33.000000000","updated":"2021-05-06 19:55:50.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"87b50ba909ec6ae0e2a6a6fa42f4f6f1772af9c0","_number":787637,"virtual_id_number":787637,"owner":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-23 20:31:46.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":-1,"date":"2021-04-23 09:12:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-22 21:42:16.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-23 09:12:02.000000000","updated_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"reviewer":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"state":"REVIEWER"}],"messages":[{"id":"d97944ffa1ffafb6ce4d194406dae3f79fdf5f91","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-04-22 20:37:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c99033d06771d87f4ce42fd009c1a63c85174212","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-22 21:42:16.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d696beaf002a46e28203c89d17b540af : SUCCESS in 8m 05s\n- grenade https://zuul.opendev.org/t/openstack/build/f9cdf0266bec48d18361e0babeeed68c : SUCCESS in 1h 01m 28s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/576ea244bfa141159e1c81c623cb3b7d : SUCCESS in 44m 02s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/c7a2e5fe4abe40ac8dfd2238174a2455 : SUCCESS in 9m 03s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/bbb81fb5d2254ee39895ba99dc93edbe : SUCCESS in 6m 43s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/fc5e6d958bab4fc69b4abdbe4674fce9 : SUCCESS in 14m 18s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/83a3d351115142acb867fe166f5c3905 : SUCCESS in 16m 15s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/f99bacbc681847439acbcb4537b0ddbf : SUCCESS in 14m 24s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/7462df191e394341a7ca2b0fdbc90a3e : SUCCESS in 12m 39s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/5f0192a4d57c4aff9aab1da8c5959151 : SUCCESS in 17m 46s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/8e189911d802443f936b64bea8760119 : SUCCESS in 16m 05s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/65d82933d549438abf65542d7a1bc1c7 : SUCCESS in 16m 01s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/9e3188862d6b441d84d2ef3de51f0603 : SUCCESS in 16m 30s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/2fe67bf28f3646f7b6afa0b8a7c11510 : SUCCESS in 16m 14s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/2cd49a07dd8f4bbda203182ccb5ee414 : SUCCESS in 16m 46s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/22bf7f74b7be4b3395542bc203c5f8ec : SUCCESS in 18m 25s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/9502649b26ff45768b72b1032d417f5a : SUCCESS in 7m 07s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/8ebf0406b295405c9a3511ed634961b1 : SUCCESS in 19m 10s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/4131e3def9fb4e54908b055c570c7843 : SUCCESS in 45m 10s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/35248bdc836341119ef53661e5d8da08 : SUCCESS in 45m 44s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/cd7ee447d6c44f6a9392fef24556ee7d : SUCCESS in 35m 29s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/eceaec99e409416e9139ac6622d33693 : SUCCESS in 35m 50s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/454e75c1c0a44bb386c57cf1759b96c1 : SUCCESS in 14m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ac2a606528c842b0a2cf9ad4d0d4a8e3 : SUCCESS in 5m 43s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/d3eff32fd64d483ba0e6f49c4385650a : SUCCESS in 21m 28s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/dee522ed45134e9a80e415efd1a2ce8d : FAILURE in 48m 52s","accounts_in_message":[],"_revision_number":1},{"id":"447eb73d8f93f0a25009bac2122eecfae3043847","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-04-23 09:12:02.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nnot sure what the goal is here so I may have misunderstood","accounts_in_message":[],"_revision_number":1},{"id":"81c29d724f34e0667e9c3cf60ee1a1757ce2150c","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-04-23 17:03:43.000000000","message":"Patch Set 1:\n\nrecheck\n\nWhile playing with shrinking, I found myself in a state where *everything* in my container listings dropped out. IIRC, what happened was\n\n* Root had a single shard; listings were done so I had that shard cached for listings.\n* I manually shrunk everything back to the root. Listings were still good because the (now deleted) shard pointed back to the root.\n* I sharded the container again. *Now* listings are broken: we get a cached set of shard ranges for the root that still points to the old, deleted shard; the old shard points back to the root (either live or from cache); then since the root is considered \"visited\" we include `X-Backend-Record-Type: object` and get back an empty listing.\n\nWith this, we\u0027ll still do that ping-ponging, but we\u0027ll get the new shard set when we actually contact the root and can then go to the new shards.","accounts_in_message":[],"_revision_number":1},{"id":"1d5b072350bbabdbac4bb2c2ff98c23fe95193f7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-23 20:31:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ef8a97b6ca5b41558dc89a83875dbbb8 : SUCCESS in 10m 37s\n- grenade https://zuul.opendev.org/t/openstack/build/65c183c011774c5980a84614b2ff6c73 : SUCCESS in 1h 12m 07s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/c0142309ec9c4ada97c17f8e6c4de75d : SUCCESS in 48m 28s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/81c1810c0a4344bb8e57ee8b8d1df55f : SUCCESS in 8m 35s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/bf76e1cfddd34fa6924c5a2a4d4a65d2 : SUCCESS in 6m 26s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/b3d0ed50964545178f6e21c192c933f0 : SUCCESS in 15m 40s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/3857bc4be30c4b839ab48e09a6908b39 : SUCCESS in 16m 28s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/3d1993b2eda34ea8b14172bf57d0903e : SUCCESS in 15m 26s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/50b43688191241fc80760c4f469260ac : SUCCESS in 14m 54s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/cced8c48378b44ae8a34111fb03536bc : SUCCESS in 20m 54s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/13018bd99808435d893b6ddd19f32cf5 : SUCCESS in 16m 28s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/2e34c8a14be8454d9d825f18c9a69d68 : SUCCESS in 16m 47s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/8a0817b73443433395a323d0c6fd5ddf : SUCCESS in 21m 05s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/09d5b92839fa489fa081bd5249c78a77 : SUCCESS in 16m 50s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/d7b0bfb88dea415fa379a3c01a004b48 : SUCCESS in 19m 14s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/511e4a366eb245aab40279ce93c22169 : SUCCESS in 22m 25s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/02d7433f79464761a3836cd07b0cb7f0 : SUCCESS in 7m 12s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/08e7d65df5a74ccfb23cd9cb5c6bccfa : SUCCESS in 26m 23s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/56581f31988a479c9a8f3ea957e530cc : SUCCESS in 53m 49s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/611e30d0ea4e4b03985d46ada573cba1 : SUCCESS in 56m 10s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/54ebfc3b412b468ea1f12f42f2fc77aa : SUCCESS in 1h 06m 09s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/65103c129d544976b3b807f7394d30a9 : SUCCESS in 54m 19s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/ed00deebcb9a423b85215132ae15baed : SUCCESS in 16m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3af7a1425de940038f045f0930d6d5d6 : SUCCESS in 6m 42s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/66d3a2692dfe4d89aafcd7188877e678 : SUCCESS in 24m 13s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/385e193a68874a8ca2171ae26ed2affe : SUCCESS in 59m 57s","accounts_in_message":[],"_revision_number":1},{"id":"87b50ba909ec6ae0e2a6a6fa42f4f6f1772af9c0","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-05-06 19:55:50.000000000","message":"Patch Set 1:\n\nSo I\u0027m realizing that part of why I saw an issue was that I cranked up the listing cache time to something like 16hrs. I think this patch is still a good/reasonable idea, though -- today, once the ranges get into cache, you can\u0027t *just* turn down the config value again; you\u0027ve also got to flush memcache or shut down all sharders until the listing caches have all expired out.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b9eda63d53aaef1685a0786bc0fe75105d20474","revisions":{"5b9eda63d53aaef1685a0786bc0fe75105d20474":{"kind":"REWORK","_number":1,"created":"2021-04-22 20:37:33.000000000","uploader":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"ref":"refs/changes/37/787637/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/37/787637/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/787637/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/787637/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/37/787637/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/37/787637/1"}}},"commit":{"parents":[{"commit":"c9b5d44e9e8d4a75e4a1e2d31036823560e9a0a1","subject":"Merge \"Update AUTHORS\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c9b5d44e9e8d4a75e4a1e2d31036823560e9a0a1"}]}],"author":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-04-21 22:22:28.000000000","tz":-420},"committer":{"name":"Tim Burke","email":"tim.burke@gmail.com","date":"2021-04-22 20:37:08.000000000","tz":-420},"subject":"sharding: Don\u0027t consider responses generated from cache as \"already visited\"","message":"sharding: Don\u0027t consider responses generated from cache as \"already visited\"\n\nChange-Id: I4ba3e01e59fde6a85e5c3bc10055e65ccbd280c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5b9eda63d53aaef1685a0786bc0fe75105d20474"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/5b9eda63d53aaef1685a0786bc0fe75105d20474"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}