)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a5ea6ae3847832e6b2dda6065926c43526e9e17b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"reconstructor: extract closure for handle_response"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since _get_response was already a method, and called after the inline"},{"line_number":10,"context_line":"definition of the handle_repsonse closure (but before we called the"},{"line_number":11,"context_line":"closure) I found the control flow to be confusingly different from"},{"line_number":12,"context_line":"visual layout of the code."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d7390ccf_e13549c8","line":10,"range":{"start_line":10,"start_character":18,"end_line":10,"end_character":34},"updated":"2021-04-28 17:42:39.000000000","message":"nit: typo","commit_id":"5da23cc2d7cf747d007344c49c7afcbde0d21410"}],"swift/obj/reconstructor.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a5ea6ae3847832e6b2dda6065926c43526e9e17b","unresolved":true,"context_lines":[{"line_number":395,"context_line":"                    \u0027full_path\u0027: full_path})"},{"line_number":396,"context_line":"        return resp"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    # job, datafile_metadata, nodes"},{"line_number":399,"context_line":"    def _handle_fragment_response(self, node, policy, partition, fi_to_rebuild,"},{"line_number":400,"context_line":"                                  path, buckets, error_responses, resp):"},{"line_number":401,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"4073e4dd_b983821c","line":398,"updated":"2021-04-28 17:42:39.000000000","message":"not sure what the comment is for? was it a hint - or an idea - to pass those as args???","commit_id":"5da23cc2d7cf747d007344c49c7afcbde0d21410"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a5ea6ae3847832e6b2dda6065926c43526e9e17b","unresolved":true,"context_lines":[{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    # job, datafile_metadata, nodes"},{"line_number":399,"context_line":"    def _handle_fragment_response(self, node, policy, partition, fi_to_rebuild,"},{"line_number":400,"context_line":"                                  path, buckets, error_responses, resp):"},{"line_number":401,"context_line":"        \"\"\""},{"line_number":402,"context_line":"        Place ok responses into a per-timestamp bucket. Append bad"},{"line_number":403,"context_line":"        responses to a list per-status-code in error_responses."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a6ff033_feb84da6","line":400,"updated":"2021-04-28 17:42:39.000000000","message":"so I actually had exactly this at one point, but balked at the number of args, so I considered passing job, node, datafile_metadata and pulling out the params again, at which point I decided that reviewers would ding me either way, and anyway I\u0027d rather have it all encapsulated in a class.\n\nLOL. I should learn to believe in myself more.","commit_id":"5da23cc2d7cf747d007344c49c7afcbde0d21410"}]}