)]}'
{"id":"openstack%2Fswift~789413","triplet_id":"openstack%2Fswift~master~I654c3d954711d4892ff43d7a8df7c3248cdf7aff","project":"openstack/swift","branch":"master","topic":"probe/badsudo","hashtags":[],"change_id":"I654c3d954711d4892ff43d7a8df7c3248cdf7aff","subject":"Drop the unnecessary sudo from probe tests","status":"MERGED","created":"2021-05-03 20:22:40.000000000","updated":"2021-05-11 22:28:02.000000000","submitted":"2021-05-11 22:26:10.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"789413-probe/badsudo","meta_rev_id":"6498374bfe55456f1b5e41fb8369cfa93428f8d2","_number":789413,"virtual_id_number":789413,"owner":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-11 22:26:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-11 21:27:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-05-11 21:27:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-03 21:16:44.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-03 21:44:42.000000000","updated_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"reviewer":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"state":"REVIEWER"}],"messages":[{"id":"6490ae4d3e305e9710d30b74a9be73ce127d6e0a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-05-03 20:22:40.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4bb2f5ba6ceb6712afbbb9d0288ce1ad98b6ead9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-03 21:16:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/72165bff88dd4aed839e07d336339052 : SUCCESS in 9m 05s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/b570b86732864affa23765f48930897e : FAILURE in 49m 30s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/faf12d6bef5d4fe2be9791a9a5dee122 : SUCCESS in 49m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6cfefb97758b409291b142e4ec687217 : SUCCESS in 5m 58s","accounts_in_message":[],"_revision_number":1},{"id":"6d58b5af1431070f0fb8137ddaf2a540ff5d2250","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-05-03 21:44:42.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"20d9dda64f518bd57821f436f0de663adc70cb2e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-05-10 22:28:12.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ee7ebedd48b39ad9c9c4b45a47bc15ac4899e93f","author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"date":"2021-05-10 22:30:11.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nLet\u0027s see if this new revision works across filesystems.\n\nAlso, I forgot to mention in the commit message that I only\nstarted doing it because I cannot run probe tests anymore.\nIt\u0027s not like I care about the invocation costs of sudo.","accounts_in_message":[],"_revision_number":2},{"id":"c0d549b2d999ca79424212357884aaefb11d06ec","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-10 23:16:33.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d8de739626fa4a75a13917eb7c9a0973 : SUCCESS in 9m 54s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/8f59b95d285349d393a228b3ffeae416 : SUCCESS in 47m 40s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/8d797ba0f9a442f8b96cc39ea6d510de : SUCCESS in 44m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/26dbe74100954d3c9bb7a542245083c9 : SUCCESS in 5m 30s","accounts_in_message":[],"_revision_number":2},{"id":"bb315ef90fa75cbccbb6392db1700a4c43bda341","author":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"},"date":"2021-05-11 21:27:42.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"7fa1e83fd611fe6e3e6a15d06128bf6bd6652baf","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 21:28:01.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ebf6cd8c1cb256be437e6c172b5ea1177532571f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 22:26:09.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6829985fc184422c9a40c1c98f67e864 : SUCCESS in 8m 50s\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/3333de276b2f41d9a6eee8ef9753fb2e : SUCCESS in 15m 34s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/15eca91bcc834e1db84e9744955b9127 : SUCCESS in 15m 25s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/fcd9f635862948dfb10e663fd574248e : SUCCESS in 15m 57s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/26daf66ec87d46d6905cca993f3e10de : SUCCESS in 21m 50s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/cfe3f8e620754a3c957d92e745c74635 : SUCCESS in 16m 57s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/36e04cc5fef647049f196935b0219862 : SUCCESS in 27m 37s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/74a56a1ead434cefb23a3b77fbc27400 : SUCCESS in 30m 14s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/52e8badcd5544c64ab759ed20c7fe29b : SUCCESS in 27m 05s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/c7c0c8e197124249a0a85380e75991bb : SUCCESS in 30m 27s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/9db235a4593e489f9227723ea64dcfdc : SUCCESS in 28m 44s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/ef74303a60694bb29f4a8bbd16d2db64 : SUCCESS in 34m 09s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/bca97dc199de4d408dc06252ea14f9d8 : SUCCESS in 16m 37s\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/ba24428d92aa4196962075c5ed40f40b : SUCCESS in 52m 17s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/6f87f75117294294a3598fd20650188d : SUCCESS in 51m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ab305dfb357248cca1a9ed51b8acb3d4 : SUCCESS in 6m 25s","accounts_in_message":[],"_revision_number":2},{"id":"3f48025dc298b5ab2f4e142b427bd79ad45f1c77","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 22:26:10.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"6498374bfe55456f1b5e41fb8369cfa93428f8d2","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 22:28:02.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/8147b98cbd464f5e9d5022f548f10489 : SUCCESS in 1m 10s\n- swift-promote-image https://zuul.opendev.org/t/openstack/build/a86877ba91e746c3a0e217da2a3d76e1 : FAILURE in 49s (non-voting)\n- swift-promote-image-py3 https://zuul.opendev.org/t/openstack/build/4bff7c2ba0a94906b7b32f704d01c9a2 : FAILURE in 44s (non-voting)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c20d6110163a28bad83065d0a1f8d03fc2232c9e","revisions":{"27d0c470e87d102265df2f64a9c9b4092b239390":{"kind":"REWORK","_number":1,"created":"2021-05-03 20:22:40.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/13/789413/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/13/789413/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/13/789413/1"}}},"commit":{"parents":[{"commit":"8bf93f1f40f213428188d17216c0d3af864448fc","subject":"Merge \"Include sharding cycle time in recon\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8bf93f1f40f213428188d17216c0d3af864448fc"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2021-04-30 04:22:54.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2021-05-01 00:20:13.000000000","tz":-300},"subject":"Drop the unnecessary sudo from probe tests","message":"Drop the unnecessary sudo from probe tests\n\nThe code checks very explicitly above that these operations\nwould be allowed, and thus the sudo is unnecessary.\n\nChange-Id: I654c3d954711d4892ff43d7a8df7c3248cdf7aff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/27d0c470e87d102265df2f64a9c9b4092b239390"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/27d0c470e87d102265df2f64a9c9b4092b239390"}]},"branch":"refs/heads/master"},"c20d6110163a28bad83065d0a1f8d03fc2232c9e":{"kind":"REWORK","_number":2,"created":"2021-05-10 22:28:12.000000000","uploader":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"ref":"refs/changes/13/789413/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/13/789413/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/13/789413/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/13/789413/2"}}},"commit":{"parents":[{"commit":"8bf93f1f40f213428188d17216c0d3af864448fc","subject":"Merge \"Include sharding cycle time in recon\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/8bf93f1f40f213428188d17216c0d3af864448fc"}]}],"author":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2021-04-30 04:22:54.000000000","tz":-300},"committer":{"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","date":"2021-05-10 22:25:09.000000000","tz":-300},"subject":"Drop the unnecessary sudo from probe tests","message":"Drop the unnecessary sudo from probe tests\n\nWhile innocently running probe tests that usued to work,\nthey started dropping to [sudo] prompt and hang. Apparently,\nsomeone added an harmless-looking sudo, but this does not work\nif the testing user does not have sudo priviletes.\n\nThe code checks very explicitly above that these operations\nwould be allowed, and thus the sudo is unnecessary. We can\njust omit it, and get probe tests working again.\n\nChange-Id: I654c3d954711d4892ff43d7a8df7c3248cdf7aff\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c20d6110163a28bad83065d0a1f8d03fc2232c9e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/c20d6110163a28bad83065d0a1f8d03fc2232c9e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":15343,"name":"Tim Burke","email":"tburke@nvidia.com","username":"tburke"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
