)]}'
{"swift/container/sharder.py":[{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a0bb2026fec22bd0feca55dd412c5bf398275a9a","unresolved":true,"context_lines":[{"line_number":449,"context_line":"    def __init__(self, ref, cursor\u003d\u0027\u0027, max_row\u003dNone, cleave_to_row\u003dNone,"},{"line_number":450,"context_line":"                 last_cleave_to_row\u003dNone, cleaving_done\u003dFalse,"},{"line_number":451,"context_line":"                 misplaced_done\u003dFalse, ranges_done\u003d0, ranges_todo\u003d0,"},{"line_number":452,"context_line":"                 rows_cleaved\u003d0):"},{"line_number":453,"context_line":"        self.ref \u003d ref"},{"line_number":454,"context_line":"        self._cursor \u003d None"},{"line_number":455,"context_line":"        self.cursor \u003d cursor"}],"source_content_type":"text/x-python","patch_set":5,"id":"2df20a05_e60f8309","line":452,"updated":"2022-03-14 16:23:57.000000000","message":"after upgrade there will be existing contexts with no rows_cleaved value. How do we want to treat those? We might need to make the default value None or -1 so we can differentiate a legacy context from a new context with zero rows cleaved.","commit_id":"6ca79c0edef16e6ba764b860c74bb65845da102c"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"a0bb2026fec22bd0feca55dd412c5bf398275a9a","unresolved":true,"context_lines":[{"line_number":553,"context_line":"        self.ranges_done \u003d 0"},{"line_number":554,"context_line":"        self.ranges_todo \u003d 0"},{"line_number":555,"context_line":"        self.cleaving_done \u003d False"},{"line_number":556,"context_line":"        self.rows_cleaved \u003d 0"},{"line_number":557,"context_line":"        self.misplaced_done \u003d False"},{"line_number":558,"context_line":"        self.last_cleave_to_row \u003d self.cleave_to_row"},{"line_number":559,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b26ca1c6_e5796594","line":556,"updated":"2022-03-14 16:23:57.000000000","message":"I don\u0027t think we\u0027d want this reset here: the CleavingContext is reset when the DB max_row has changed during cleaving (so some extra rows unexpectedly crept in to the retiring DB). We then cleave again but only the rows from last_cleave_to_row, so rows_cleaved should continue to increment rather that revert to zero.","commit_id":"6ca79c0edef16e6ba764b860c74bb65845da102c"}]}