)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b3e4a475_e8b5da50","updated":"2024-08-19 10:45:44.000000000","message":"Still working through tests (and removing some instances of the old ACTIVATING state which now isn\u0027t needed) but it\u0027s getting late into the evening and I want to call it a night.. but wanted to get what I had up.","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"}],"test/probe/test_sharder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":true,"context_lines":[{"line_number":1019,"context_line":"            self.assertLengthEqual(found[\u0027shard_dbs\u0027], 1)"},{"line_number":1020,"context_line":"            self.assertLengthEqual(found[\u0027normal_dbs\u0027], 2)"},{"line_number":1021,"context_line":"            for sr in orig_root_shard_ranges:"},{"line_number":1022,"context_line":"                sr[\u0027state\u0027] \u003d ShardRange.ACTIVE"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Now that everyone has shard ranges, run *everyone*"},{"line_number":1025,"context_line":"        self.sharders.once(additional_args\u003d\u0027--partitions\u003d%s\u0027 % self.brain.part)"}],"source_content_type":"text/x-python","patch_set":9,"id":"482dfbad_a8cf075b","line":1022,"updated":"2024-08-19 10:45:44.000000000","message":"THIS WILL BE REMOVED TOO, HAVEN\u0027T MADE IT THIS FAR YET, PROBE TEST WILL BE LAST 😊","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b1d3d5df5d70e5ec99ea004b9d571d42fca3b141","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"            self.assertLengthEqual(found[\u0027shard_dbs\u0027], 1)"},{"line_number":1020,"context_line":"            self.assertLengthEqual(found[\u0027normal_dbs\u0027], 2)"},{"line_number":1021,"context_line":"            for sr in orig_root_shard_ranges:"},{"line_number":1022,"context_line":"                sr[\u0027state\u0027] \u003d ShardRange.ACTIVE"},{"line_number":1023,"context_line":""},{"line_number":1024,"context_line":"        # Now that everyone has shard ranges, run *everyone*"},{"line_number":1025,"context_line":"        self.sharders.once(additional_args\u003d\u0027--partitions\u003d%s\u0027 % self.brain.part)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ceb7f793_21a8d259","line":1022,"in_reply_to":"482dfbad_a8cf075b","updated":"2024-08-22 03:39:25.000000000","message":"Done","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"}],"test/unit/container/test_sharder.py":[{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":true,"context_lines":[{"line_number":2045,"context_line":"        # CLEAVING shards."},{"line_number":2046,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":2047,"context_line":"            self.assertTrue(sharder._cleave(broker))"},{"line_number":2048,"context_line":""},{"line_number":2049,"context_line":"        # now they have reached CLEAVED state, the first 2 shard ranges should"},{"line_number":2050,"context_line":"        # have updated object count, bytes used and meta_timestamp"},{"line_number":2051,"context_line":"        shard_ranges[0].bytes_used \u003d 23"}],"source_content_type":"text/x-python","patch_set":9,"id":"2a3bdf5f_4f10d180","line":2048,"updated":"2024-08-19 10:45:44.000000000","message":"STILL IN THE MIDDLE OF THIS TEST, ALMOST THROUGH IT. but too late in the evening for me to finish now.","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":true,"context_lines":[{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"        # and for completeness sake let\u0027s let audit complete to fill ACTIVE"},{"line_number":3087,"context_line":"        # state"},{"line_number":3088,"context_line":"        self._add_extra_complete_contexts(broker, 2)"},{"line_number":3089,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":3090,"context_line":"            sharder._audit_cleave_contexts(broker)"},{"line_number":3091,"context_line":"        self.assertEqual([ShardRange.ACTIVE] * 4,"}],"source_content_type":"text/x-python","patch_set":9,"id":"6f112cb6_d345abb0","line":3088,"updated":"2024-08-19 10:45:44.000000000","message":"THIS WILL BE REMOVED TOO, HAVEN\u0027T MADE IT THIS FAR YET\n\nthis function has been removed","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b1d3d5df5d70e5ec99ea004b9d571d42fca3b141","unresolved":false,"context_lines":[{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"        # and for completeness sake let\u0027s let audit complete to fill ACTIVE"},{"line_number":3087,"context_line":"        # state"},{"line_number":3088,"context_line":"        self._add_extra_complete_contexts(broker, 2)"},{"line_number":3089,"context_line":"        with self._mock_sharder() as sharder:"},{"line_number":3090,"context_line":"            sharder._audit_cleave_contexts(broker)"},{"line_number":3091,"context_line":"        self.assertEqual([ShardRange.ACTIVE] * 4,"}],"source_content_type":"text/x-python","patch_set":9,"id":"225c610d_e2ecd6fd","line":3088,"in_reply_to":"6f112cb6_d345abb0","updated":"2024-08-22 03:39:25.000000000","message":"Done","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":true,"context_lines":[{"line_number":3505,"context_line":"        warning_lines \u003d sharder.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":3506,"context_line":"        self.assertFalse(warning_lines)"},{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"        # To make the final ACTIVATING -\u003e ACTIVE state transition we need"},{"line_number":3509,"context_line":"        # a quorum of done cleave contexts"},{"line_number":3510,"context_line":"        self._add_extra_complete_contexts(broker, 2)"},{"line_number":3511,"context_line":"        with self._mock_sharder() as sharder:"}],"source_content_type":"text/x-python","patch_set":9,"id":"47f1fdcb_f025b85c","line":3508,"updated":"2024-08-19 10:45:44.000000000","message":"THIS WILL BE REMOVED TOO, HAVEN\u0027T MADE IT THIS FAR YET","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b1d3d5df5d70e5ec99ea004b9d571d42fca3b141","unresolved":false,"context_lines":[{"line_number":3505,"context_line":"        warning_lines \u003d sharder.logger.get_lines_for_level(\u0027warning\u0027)"},{"line_number":3506,"context_line":"        self.assertFalse(warning_lines)"},{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"        # To make the final ACTIVATING -\u003e ACTIVE state transition we need"},{"line_number":3509,"context_line":"        # a quorum of done cleave contexts"},{"line_number":3510,"context_line":"        self._add_extra_complete_contexts(broker, 2)"},{"line_number":3511,"context_line":"        with self._mock_sharder() as sharder:"}],"source_content_type":"text/x-python","patch_set":9,"id":"f1ec23d7_e26abc0f","line":3508,"in_reply_to":"47f1fdcb_f025b85c","updated":"2024-08-22 03:39:25.000000000","message":"Done","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"a60c3704c0a6675be8fa35d123153a7389dda1ba","unresolved":true,"context_lines":[{"line_number":8307,"context_line":"        expected_error_string \u003d \u0027Cannot find local handoff; no local devices\u0027"},{"line_number":8308,"context_line":"        self.assertEqual(str(dev_err.exception), expected_error_string)"},{"line_number":8309,"context_line":""},{"line_number":8310,"context_line":"    def test_get_active_state_from_quorum(self):"},{"line_number":8311,"context_line":"        conf \u003d {\u0027shard_container_threshold\u0027: 100}"},{"line_number":8312,"context_line":""},{"line_number":8313,"context_line":"        def do_test(broker, expected_state):"}],"source_content_type":"text/x-python","patch_set":9,"id":"e05f5da0_d49cf0ad","line":8310,"updated":"2024-08-19 10:45:44.000000000","message":"THIS WILL BE REMOVED... haven\u0027t got down this far yet.","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"},{"author":{"_account_id":7233,"name":"Matthew Oliver","email":"matt@oliver.net.au","username":"mattoliverau"},"change_message_id":"b1d3d5df5d70e5ec99ea004b9d571d42fca3b141","unresolved":false,"context_lines":[{"line_number":8307,"context_line":"        expected_error_string \u003d \u0027Cannot find local handoff; no local devices\u0027"},{"line_number":8308,"context_line":"        self.assertEqual(str(dev_err.exception), expected_error_string)"},{"line_number":8309,"context_line":""},{"line_number":8310,"context_line":"    def test_get_active_state_from_quorum(self):"},{"line_number":8311,"context_line":"        conf \u003d {\u0027shard_container_threshold\u0027: 100}"},{"line_number":8312,"context_line":""},{"line_number":8313,"context_line":"        def do_test(broker, expected_state):"}],"source_content_type":"text/x-python","patch_set":9,"id":"dbeadd0d_680288f1","line":8310,"in_reply_to":"e05f5da0_d49cf0ad","updated":"2024-08-22 03:39:25.000000000","message":"Done","commit_id":"5ba8e2064e73558e99ee538fd2157d82967f8c5f"}]}
