)]}'
{"swift/container/backend.py":[{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"36e3af342aaff7f11852f5860da517b92137137e","unresolved":true,"context_lines":[{"line_number":1895,"context_line":"        if own_shard_range:"},{"line_number":1896,"context_line":"            info \u003d self.get_info()"},{"line_number":1897,"context_line":"            own_shard_range.update_meta("},{"line_number":1898,"context_line":"                info[\u0027object_count\u0027], info[\u0027bytes_used\u0027])"},{"line_number":1899,"context_line":"        return own_shard_range"},{"line_number":1900,"context_line":""},{"line_number":1901,"context_line":"    def is_own_shard_range(self, shard_range):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c27d30d9_fbc2c7da","side":"PARENT","line":1898,"updated":"2021-05-11 14:51:09.000000000","message":"wait wait wait - this is writing anything *back* to the shard ranges table - it\u0027s just fixing the stats before returning the object to the caller.","commit_id":"4ce907a4ae97b150fa994237ebffd73ee8ac694d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"557e9489faa6acc1a85be97e467f03f53e8ad10e","unresolved":true,"context_lines":[{"line_number":1895,"context_line":"        if own_shard_range:"},{"line_number":1896,"context_line":"            info \u003d self.get_info()"},{"line_number":1897,"context_line":"            own_shard_range.update_meta("},{"line_number":1898,"context_line":"                info[\u0027object_count\u0027], info[\u0027bytes_used\u0027])"},{"line_number":1899,"context_line":"        return own_shard_range"},{"line_number":1900,"context_line":""},{"line_number":1901,"context_line":"    def is_own_shard_range(self, shard_range):"}],"source_content_type":"text/x-python","patch_set":1,"id":"cbbb3fe4_4a011060","side":"PARENT","line":1898,"in_reply_to":"5eed459f_4f07a4f5","updated":"2021-05-12 15:52:33.000000000","message":"I guess I was actually just thinking that two READ queries aren\u0027t as bad as I thought it was originally - when i heard \"update_meta\" yesterday I thought every call to get_own_shard_range was doing a sql write!","commit_id":"4ce907a4ae97b150fa994237ebffd73ee8ac694d"},{"author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"change_message_id":"1fc9bc205628187de6f00cd714b1bc664681ee4c","unresolved":true,"context_lines":[{"line_number":1895,"context_line":"        if own_shard_range:"},{"line_number":1896,"context_line":"            info \u003d self.get_info()"},{"line_number":1897,"context_line":"            own_shard_range.update_meta("},{"line_number":1898,"context_line":"                info[\u0027object_count\u0027], info[\u0027bytes_used\u0027])"},{"line_number":1899,"context_line":"        return own_shard_range"},{"line_number":1900,"context_line":""},{"line_number":1901,"context_line":"    def is_own_shard_range(self, shard_range):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5eed459f_4f07a4f5","side":"PARENT","line":1898,"in_reply_to":"c27d30d9_fbc2c7da","updated":"2021-05-12 11:10:51.000000000","message":"hmmm, yes, it\u0027s the callers responsibility to merge back in, so maybe we should ensure that when update_meta is True the result *is* merged so that subsequent calls at least get the most recent","commit_id":"4ce907a4ae97b150fa994237ebffd73ee8ac694d"},{"author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"change_message_id":"36e3af342aaff7f11852f5860da517b92137137e","unresolved":true,"context_lines":[{"line_number":1884,"context_line":""},{"line_number":1885,"context_line":"        The returned shard range will be updated with the current object stats"},{"line_number":1886,"context_line":"        for this broker and a meta timestamp set to the current time. For these"},{"line_number":1887,"context_line":"        values to be persisted the caller must merge the shard range."},{"line_number":1888,"context_line":""},{"line_number":1889,"context_line":"        :param no_default: if True and the broker\u0027s own shard range is not"},{"line_number":1890,"context_line":"            found in the shard ranges table then None is returned, otherwise a"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f3d8adf_d8b214be","line":1887,"updated":"2021-05-11 14:51:09.000000000","message":"maybe not true alays anymore","commit_id":"9f2eff0e08c4d9db72046fbf603d0c491ea605a7"}]}