)]}'
{"id":"openstack%2Fswift~790689","triplet_id":"openstack%2Fswift~master~I3f5bb0f3e19eb9af25557efb90470f2cdd1299d4","project":"openstack/swift","branch":"master","topic":"p-shard-update-tombstones","hashtags":[],"change_id":"I3f5bb0f3e19eb9af25557efb90470f2cdd1299d4","subject":"Update own_shard_range metadata less often","status":"ABANDONED","created":"2021-05-11 13:18:35.000000000","updated":"2023-07-13 14:14:09.000000000","total_comment_count":4,"unresolved_comment_count":2,"has_review_started":true,"meta_rev_id":"433eb25558bbe3b913220c22423fb9ca95a18168","_number":790689,"virtual_id_number":790689,"owner":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-05-11 14:39:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"all":[{"value":-2,"date":"2021-05-11 13:19:43.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":1,"date":"2021-05-11 14:51:09.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-11 14:39:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-11 14:51:09.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"}],"messages":[{"id":"69c36265181a749c3fa77b6f985654083c23fa7e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-05-11 13:18:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"440492cdce85602ed66007ec82bb83a802947e23","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-05-11 13:19:43.000000000","message":"Patch Set 1: Code-Review-2\n\nFloating the idea....but should we go further and remove the metadata update facility from get_own_shard_range completely?","accounts_in_message":[],"_revision_number":1},{"id":"31049bbe7d44b8064c54e8d8562ce2e4d0fe814b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-11 14:39:13.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1497185741554fe0b6435db55d669fad : SUCCESS in 9m 47s\n- grenade https://zuul.opendev.org/t/openstack/build/b56e14459dac43808c3279e7395e66bb : SUCCESS in 54m 12s\n- tempest-integrated-object-storage https://zuul.opendev.org/t/openstack/build/af5a36c3cc854065b0550ee4fc484fa8 : SUCCESS in 37m 28s\n- swift-build-image https://zuul.opendev.org/t/openstack/build/249b9732ce244f3e962a7233f41c8c4b : SUCCESS in 9m 42s (non-voting)\n- swift-build-image-py3 https://zuul.opendev.org/t/openstack/build/b5715f084a51439d9f653e8bb55d8fce : SUCCESS in 7m 53s (non-voting)\n- swift-tox-py27 https://zuul.opendev.org/t/openstack/build/59a967e4f5464fa5b867f52c5b149a48 : SUCCESS in 15m 48s\n- swift-tox-py36 https://zuul.opendev.org/t/openstack/build/9144a04d2e4b4b1280b7268418aad654 : SUCCESS in 15m 08s\n- swift-tox-py37 https://zuul.opendev.org/t/openstack/build/ceb4ef2577c64fac9137b0499c0022db : SUCCESS in 14m 59s\n- swift-tox-py38 https://zuul.opendev.org/t/openstack/build/e283104e119a4364ab4f215f9639d868 : SUCCESS in 15m 48s\n- swift-tox-py39 https://zuul.opendev.org/t/openstack/build/0792c27826d14ed2948e6e3291e4ca22 : SUCCESS in 12m 47s\n- swift-tox-func-py27 https://zuul.opendev.org/t/openstack/build/c7826494064c461099e256bd2ebb8ed0 : SUCCESS in 19m 44s\n- swift-tox-func-encryption-py27 https://zuul.opendev.org/t/openstack/build/b9048d011b8840b18ca2fe1e08aa5b08 : SUCCESS in 21m 34s\n- swift-tox-func-ec-py27 https://zuul.opendev.org/t/openstack/build/7afc413166b54c6a846382cdbb0a4abd : SUCCESS in 18m 41s\n- swift-tox-func-py37 https://zuul.opendev.org/t/openstack/build/0aa26d8a79a94d11900d653dad340ec5 : SUCCESS in 19m 26s\n- swift-tox-func-encryption-py37 https://zuul.opendev.org/t/openstack/build/f53faa58fea74ce88b65461e785e7316 : SUCCESS in 21m 12s\n- swift-tox-func-ec-py37 https://zuul.opendev.org/t/openstack/build/7c667d2e68b24f90b00ffbd41c336b64 : SUCCESS in 20m 22s\n- swift-func-cors https://zuul.opendev.org/t/openstack/build/4dd1b0b7118947918a0279eaed16c2ae : SUCCESS in 6m 51s\n- swift-tox-func-s3api-ceph-s3tests-tempauth https://zuul.opendev.org/t/openstack/build/5627b781ce9640e998d8c5e4cd88d5cc : SUCCESS in 26m 36s (non-voting)\n- swift-probetests-centos-7 https://zuul.opendev.org/t/openstack/build/f2eacf1a27d84874b06934c7905ee2ee : SUCCESS in 1h 17m 45s\n- swift-probetests-centos-8 https://zuul.opendev.org/t/openstack/build/7b91c9a31d4745c2b1cbf55576f6b38c : SUCCESS in 48m 26s\n- swift-dsvm-functional https://zuul.opendev.org/t/openstack/build/ecdb73f1f2594fef977c2fdc61557984 : SUCCESS in 42m 02s\n- swift-dsvm-functional-ipv6 https://zuul.opendev.org/t/openstack/build/5cb7d37d02374e3b82fc41139647129e : SUCCESS in 44m 21s\n- swift-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6ae2bfa5dc2d4315b73f91312c84fd30 : SUCCESS in 14m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dc6dbcb8187049188d2dec3e671fb575 : SUCCESS in 6m 18s\n- swift-multinode-rolling-upgrade https://zuul.opendev.org/t/openstack/build/42400f08dac7468d89215f9943b32250 : SUCCESS in 40m 16s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1b9294021e794e71b00cdeddd2fe6ae7 : SUCCESS in 57m 59s","accounts_in_message":[],"_revision_number":1},{"id":"36e3af342aaff7f11852f5860da517b92137137e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-05-11 14:51:09.000000000","message":"Patch Set 1: Code-Review+1\n\n(2 comments)\n\nthis is an interesting investigation!\n\nBefore we commit this direction, I\u0027d like to see what it would look like to swap the default... but having \"more correct by default\" info isn\u0027t a bad thing!\n\nWe could also try to optimize everything into one sql query that just hits both tables","accounts_in_message":[],"_revision_number":1},{"id":"1fc9bc205628187de6f00cd714b1bc664681ee4c","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2021-05-12 11:10:51.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"557e9489faa6acc1a85be97e467f03f53e8ad10e","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2021-05-12 15:52:33.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nmaybe https://review.opendev.org/c/openstack/swift/+/791015 ???","accounts_in_message":[],"_revision_number":1},{"id":"433eb25558bbe3b913220c22423fb9ca95a18168","tag":"autogenerated:gerrit:abandon","author":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"date":"2023-07-13 14:14:09.000000000","message":"Abandoned\n\nsuperseded by https://review.opendev.org/c/openstack/swift/+/852283","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"9f2eff0e08c4d9db72046fbf603d0c491ea605a7","revisions":{"9f2eff0e08c4d9db72046fbf603d0c491ea605a7":{"kind":"REWORK","_number":1,"created":"2021-05-11 13:18:35.000000000","uploader":{"_account_id":7847,"name":"Alistair Coles","email":"alistairncoles@gmail.com","username":"acoles"},"ref":"refs/changes/89/790689/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/swift","ref":"refs/changes/89/790689/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/swift refs/changes/89/790689/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/swift refs/changes/89/790689/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/swift refs/changes/89/790689/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/swift refs/changes/89/790689/1"}}},"commit":{"parents":[{"commit":"4ce907a4ae97b150fa994237ebffd73ee8ac694d","subject":"relinker: Add /recon/relinker endpoint and drop progress stats","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/4ce907a4ae97b150fa994237ebffd73ee8ac694d"}]}],"author":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-05-11 12:53:59.000000000","tz":60},"committer":{"name":"Alistair Coles","email":"alistairncoles@gmail.com","date":"2021-05-11 13:09:57.000000000","tz":60},"subject":"Update own_shard_range metadata less often","message":"Update own_shard_range metadata less often\n\nPreviously, the ContainerBroker get_own_shard_range method always\nupdated the returned shard range\u0027s metadata, requiring a DB query\nduring every call. However, the returned shard range was often not\nrequired to have up-to-date metadata, for example when only its bounds\nwere used by the caller.\n\nNow the get_own_shard_range method will only update metadata when the\noptional update_meta argument is set True, and by default metadata is\nnot updated.\n\nChange-Id: I3f5bb0f3e19eb9af25557efb90470f2cdd1299d4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9f2eff0e08c4d9db72046fbf603d0c491ea605a7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/swift/commit/9f2eff0e08c4d9db72046fbf603d0c491ea605a7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":["label:Code-Review\u003dMIN"],"failing_atoms":["label:Code-Review\u003dMAX"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}